d8088777ea
Add Equals method to IssueTemplate
...
This will be useful in tests.
2021-04-13 01:21:34 +02:00
19a154ddf1
Rename checkOrigin -> check
...
More consistent with `Issue.ctor`'s "template".
2021-04-12 17:28:12 +02:00
bb720c23a0
Remove check ctors and locals
2021-04-12 17:12:37 +02:00
62c1812282
Remove redundant parameter naming
2021-04-12 23:37:47 +09:00
36bd235021
Move nested classes to bottom of file
2021-04-12 23:36:10 +09:00
6d50d01186
Make IssueTemplate.Check readonly
2021-04-12 16:23:05 +02:00
caaaba5950
Rename Check -> ICheck
2021-04-12 16:20:53 +02:00
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
a2fc9c398f
Rename CreateChecker -> CreateBeatmapVerifier
2021-04-12 10:08:30 +02:00
65ebdd8f7a
Move check origin from IssueTemplate to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
78bbc8f5c8
Tidy some remaining code
2021-04-12 15:52:18 +09:00
8c31e96cdf
Change some methods to get properties
2021-04-12 15:52:18 +09:00
f78239c7f2
Move enums out of nesting
2021-04-12 15:52:18 +09:00
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
257acf9cd8
Colour constants to private
2021-04-12 15:52:18 +09:00
136627b9ac
Wrap xmldoc less and make a few fixes
2021-04-12 15:52:18 +09:00
1c553b5d48
Checker -> BeatmapVerifier
2021-04-12 15:29:05 +09:00
14bd5bdc77
Merge branch 'master' into verify-tab
2021-04-12 15:14:37 +09:00
3289bb0379
Merge Check and BeatmapCheck
...
We're probably not going to need GeneralChecks or BeatmapsetChecks.
The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
bc4f3351f3
Replace checks with realistic ones
2021-04-10 13:03:16 +02:00
b30e41b805
Fix comment; mode -> ruleset
2021-04-10 13:02:36 +02:00
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00
9aa30fb323
Merge pull request #11688 from Syriiin/diffcalc/dynamic-history
...
Implement dynamic previous hitobject retention for Skill class
2021-04-10 01:25:07 +09:00
bfd3d0cce9
Implement custom enumerator for ReverseQueue to avoid allocations
2021-04-10 01:16:54 +10:00
76981f2547
Remove unused using
2021-04-09 13:58:24 +09:00
8293b06c0a
Remove obsolete code
2021-04-09 13:56:58 +09:00
a8839792fd
Merge branch 'master' into circular-arc-freeze
2021-04-08 14:33:03 +09:00
0343ef7f14
Add ruleset-specific checker
2021-04-07 14:36:43 +02:00
b24ce66a0d
Add check/issue classes
2021-04-07 14:35:33 +02:00
37e30b00bf
Refactor to keep a consistent API
2021-04-06 16:39:02 +09:00
784552022f
Merge pull request #12303 from smoogipoo/fix-last-control-point-segmenting
...
Make last control point not able to make an implicit segment
2021-04-06 13:35:55 +09:00
5cd43b3a7f
Set default history retention to 0 for Skill and override in StrainSkill
...
Some skills might not even require history retention, so why waste the allocations?
2021-04-06 11:53:31 +10:00
4f614a703e
Merge branch 'master' into diffcalc/dynamic-history
2021-04-06 11:34:33 +10:00
65f93d6f9d
Add more descriptive xmldoc for ReverseQueue
2021-04-06 11:30:58 +10:00
ffe7edc16a
Update xmldocs
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-04-06 11:06:10 +10:00
9d8a26f373
Merge branch 'master' into diffcalc/refactor-strain-skill
2021-04-06 08:21:38 +09:00
5bdd15f746
Refactor Skill.Process() to not require calling base.Process()
2021-04-05 22:14:59 +10:00
57983ae61f
Fix whitespace
2021-04-05 22:14:59 +10:00
4b29d0ebe2
Fix last control point starting new segment
2021-04-05 17:49:36 +09:00
6bcbef9f25
Merge pull request #12294 from smoogipoo/mania-scoring-adjustments
...
Adjust scoring values to better fit osu!mania expectations
2021-04-05 17:19:28 +09:00
3acc612a67
Adjust scoring values to better fit osu!mania
2021-04-05 13:28:46 +09:00
85d2b1232a
Refactor to abstract out strain logic into StrainSkill class
...
While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.
2021-04-03 20:52:39 +11:00
5b2dcea8a8
Refactor to encapsulate strain logic into Skill class
...
As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.
2021-04-03 20:47:43 +11:00
fe66b84bed
Implement dynamic previous hitobject retention for Skill class
...
There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.
2021-04-03 20:28:51 +11:00
345779b19a
Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay
2021-04-02 20:58:29 +09:00
5b1dc7d2b4
Remove unused using directive
2021-04-02 02:45:26 +03:00
fcd56dba44
Guard against same ruleset file with loaded assembly filenames instead
2021-04-02 02:12:25 +03:00
7e47922fb7
Merge branch 'master' into circular-arc-freeze
2021-04-01 17:09:45 +02:00
