Commit Graph

26683 Commits

Author SHA1 Message Date
481e4dedb0 Move PopoverContainer to OsuGameBase 2021-07-13 16:51:31 +09:00
6409a518db Focus password text box on popover display 2021-07-13 16:35:37 +09:00
5a2667ae89 Merge branch 'master' into add-password-support 2021-07-13 14:27:59 +09:00
125bd36ab1 Send password in request ctor directly 2021-07-13 14:27:07 +09:00
35b5f0462c Merge branch 'master' into add-password-support 2021-07-13 14:26:56 +09:00
35841fa4f7 Merge branch 'master' into fix-difficulty-bindable-bind-order 2021-07-13 13:42:53 +09:00
5cff379cd9 Merge pull request #13860 from smoogipoo/fix-bindable-ctor
Fix DifficultyBindable not binding correctly and not having default ctor
2021-07-13 13:42:44 +09:00
5af2190246 Merge branch 'master' into fix-bindable-ctor 2021-07-13 12:46:01 +09:00
ac15dae930 Update framework 2021-07-13 12:35:25 +09:00
351a46b379 Merge pull request #13823 from ekrctb/catch-editor-tests
Add some tests for catch editor blueprints
2021-07-13 08:27:41 +09:00
cce4a4dc31 Fix incorrect value copy order in BindTo() 2021-07-12 22:27:36 +02:00
4dea2d9778 Dismiss popovers on returning to lounge 2021-07-12 18:54:17 +09:00
c5319c06c2 Add password attributes to CopyFrom to make testing work better 2021-07-12 18:54:07 +09:00
bbc3a013c8 Use BasicPopover for now 2021-07-12 18:29:50 +09:00
413f8adb36 Update framework 2021-07-12 18:25:04 +09:00
947460c3c5 Add test flow for joining passworded rooms via UI 2021-07-12 18:25:04 +09:00
b4ca6b6188 Update popover logic to take advantage of new explicit popup functionality 2021-07-12 18:25:04 +09:00
a3e0168a46 Update tests 2021-07-12 18:25:04 +09:00
e25b3518dc Make password popover display inside RoomsContainer rooms 2021-07-12 18:25:04 +09:00
9f9d7f9125 Add remaining pieces of password flow (for osu-web join request) 2021-07-12 18:22:52 +09:00
3c49b46c5f Add lock overlay for rooms which are password protected 2021-07-12 18:22:52 +09:00
4b393209ec Implement UnbindFrom() 2021-07-12 17:33:29 +09:00
242982730f Fix incorrect DifficultyBindable binding implementation 2021-07-12 17:09:09 +09:00
36dd2c36de Merge pull request #13859 from peppy/update-realm-win-81-fix
Update realm libraries to fix windows 8.1 incompatibility
2021-07-12 16:40:35 +09:00
f35d55c32f Fix HasPassword not being in sync with Password value for client-side rooms 2021-07-12 15:49:19 +09:00
08c40938db Add support for updating a room's password 2021-07-12 15:49:19 +09:00
84b0a3290c Add multiplayer lounge test coverage 2021-07-12 15:49:19 +09:00
5148069efe Update signatures in line with no-overload methods (unsupported by signalr) 2021-07-12 15:49:19 +09:00
2ca11d458a Add password to room settings and multiplayer lounge interface 2021-07-12 15:49:19 +09:00
6a74fde082 Add has_password flag and region post only parameters 2021-07-12 15:49:19 +09:00
4fd6f2101c Add password textbox input 2021-07-12 15:49:19 +09:00
24f330e5c1 Avoid MatchSettingsOverlay base class potentially accessing an uninitialised field 2021-07-12 15:49:19 +09:00
0db316d644 Add password scaffolding 2021-07-12 15:49:19 +09:00
d5d7dd0e74 Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
f548ba4f69 Update realm libraries to fix windows 8.1 incompatibility 2021-07-12 14:07:17 +09:00
0c52b26d23 Merge pull request #13824 from peppy/da-mod-refactor
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
a6258d705e Make CurrentNumber internal 2021-07-12 11:26:30 +09:00
32b4f5fbd6 Do not store direct references to original bindable
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.

Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
f21ea3b790 Update player test scene Ruleset bindable from creation method 2021-07-11 03:46:19 +03:00
07ede7a147 Disallow custom rulesets from score submission 2021-07-11 03:34:57 +03:00
c44558e3c8 Add back LoadComplete override 2021-07-10 17:57:52 +03:00
1bd5b1a8b9 Merge branch 'master' into fix-access-denied-test-failures 2021-07-10 13:00:27 +02:00
6f89f8e572 Merge branch 'master' into da-mod-refactor 2021-07-10 11:41:54 +02:00
6a5f0e8237 Move handling of replay seek operations out of progress bar
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579).
2021-07-09 14:28:59 +09:00
741062a6da Simplify bindable update methods 2021-07-09 13:58:44 +09:00
e0277763d0 Refactor DifficultyAdjustSettingsControl to help with readability 2021-07-09 13:50:07 +09:00
f9cd7f10d8 Allow null values for ReadCurrentFromDifficulty
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
90326f8864 Standardise variables 2021-07-09 13:24:26 +09:00
df4bd86cfc Fix storage wrapping logic setting logger too early in startup sequence 2021-07-09 13:18:49 +09:00
f3b68a4fbf Fix storage wrapping logic setting logger too early in startup sequence 2021-07-09 13:17:25 +09:00