Commit Graph

11679 Commits

Author SHA1 Message Date
0e788ac714 Simplify bindable logic greatly 2022-07-15 19:02:12 +09:00
8a48cb701d Tidy up implementation and remove unnecessary enum 2022-07-15 19:02:04 +09:00
ab6665d88c Merge branch 'master' into Save-Score-Failed 2022-07-15 18:02:58 +09:00
e12e480393 Only expose bindable string rather than full textbox 2022-07-15 18:01:35 +09:00
ba0a158740 Show search online prompt even when no beatmaps are available locally 2022-07-15 17:50:10 +09:00
c8c79d2185 Standardise HasReplay implementation (and remove from persisting to realm) 2022-07-15 16:14:21 +09:00
c1dd1cfead Merge pull request #19082 from peppy/api-solo-score-model
Add and consume `SoloScoreInfo`
2022-07-15 15:20:18 +09:00
7e80a71020 Replace download tracker with local querying 2022-07-15 08:16:36 +03:00
86d019c2b2 Enable NRT on BeatmapDetails 2022-07-15 06:52:06 +03:00
97c3eea3aa Fix beatmap details source and tags not filtering on song select 2022-07-15 06:51:50 +03:00
a85a70c472 Fix potential nullref in ContextMenuItems 2022-07-14 05:04:28 +03:00
036e64382f Add beatmap details menu item to playlist items 2022-07-14 03:41:47 +03:00
102d0415f1 Merge branch 'master' into drawable-playlist-item-collection 2022-07-14 00:10:49 +03:00
7ac04d0478 Fix potential crash when exiting editor test mode 2022-07-14 01:00:18 +09:00
7ed05277f8 Merge pull request #19098 from peppy/last-played
Add "last played" sort mode to song select
2022-07-13 22:44:50 +09:00
937692604e Remove mention of autoplay mod for now 2022-07-13 22:37:20 +09:00
afaf8f5189 Merge pull request #19105 from peppy/fix-editor-disposed-track
Fix audio and background file equality incorrectly comparing `BeatmapSet.Hash`
2022-07-13 22:34:36 +09:00
6950223a7d Fix drawable mutation from disposal thread 2022-07-13 19:19:14 +09:00
952d97c66e Update comment regarding LoadTrack safety 2022-07-13 19:02:22 +09:00
fc274629f8 Add "last played" sort mode to song select
Note that this will consider the most recent play of any beatmap in
beatmap set groups for now, similar to other sort methods.
2022-07-13 16:43:43 +09:00
ab3ec80159 Update LastPlayed on gameplay starting in a SubmittingPlayer 2022-07-13 16:43:43 +09:00
f956955d4d Combine ScoreInfo construction helper methods 2022-07-12 18:00:25 +09:00
bd6f8bde9f Merge pull request #19079 from peppy/fix-audio-playback-disposed
Fix potential crash during shutdown sequence if intro playback was aborted
2022-07-12 17:29:23 +09:00
cad18ebc58 Reword comment to better explain what we are guarding against 2022-07-12 16:46:19 +09:00
cafe30fc4d Fix potential crash during shutdown sequence if intro playback was aborted
Fixes one of the audio related `ObjectDisposedException`s
(https://sentry.ppy.sh/organizations/ppy/issues/92/events/12f282f048cb4a4fae85810e8a70b68d/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=7d).

Ran into this while testing locally. See
`IntroScreen.ensureEventuallyArrivingAtMenu` for the related cause of
this happening (forced continuing to next screen if the intro doesn't
load in time).
2022-07-12 15:20:30 +09:00
b52ea16133 Show basic error message when score submission fails 2022-07-12 15:10:59 +09:00
d82d50e308 Merge pull request #19065 from Ludio235/master
Fix playlist room creation screen pushing content on opening dropdowns
2022-07-12 13:22:38 +09:00
3ca10ac02c Merge pull request #19063 from Joehuu/fix-samples-cancel-exit
Fix editor playing object samples while paused after cancelling exit
2022-07-12 12:51:27 +09:00
0434c10914 Use global WorkingBeatmap in PlayerArea for the time being 2022-07-11 02:57:44 +09:00
8116a4b6f6 Fix multiplayer spectator crash due to track potentially not being loaded in time 2022-07-11 02:51:40 +09:00
52aef09cd6 Update PlaylistsRoomSettingsOverlay.cs 2022-07-10 02:05:40 +00:00
834bb1f187 Fix editor playing object samples while paused after cancelling exit 2022-07-09 12:14:39 -07:00
d2406242ae rename updateTooltip to updateState 2022-07-09 00:38:17 +09:00
91f471ebe0 disabled button instead of shake
removed `ShakeContainer`
2022-07-09 00:37:53 +09:00
a38c6704c2 Use ContinueWith, Check is Task empty 2022-07-09 00:23:32 +09:00
5651eca06c Merge branch 'master' into custom-ruleset-score-import 2022-07-08 19:03:47 +09:00
e4ebab92c6 Rename lots of weird variables 2022-07-08 18:37:03 +09:00
f3a6e646a6 Merge branch 'master' into Save-Score-Failed 2022-07-08 18:32:13 +09:00
eab3eba70e Move event handlers to LoadComplete 2022-07-08 15:09:16 +09:00
1e159eb328 Add back fade to black duration
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-08 10:43:50 +09:00
67fa15f231 Remove no longer required context menu container in ParticipantsList 2022-07-08 01:42:55 +03:00
7b08501eaf Cover online-play room screens with context menu containers 2022-07-08 01:42:11 +03:00
1d0f2e359a Add collection context menu to room playlist items 2022-07-08 01:40:53 +03:00
a94fb62be3 Split collection toggle menu item to own class 2022-07-08 01:39:45 +03:00
07a08d28c6 Rename parameter and default to 0 2022-07-07 23:31:06 +03:00
15d070668d Move intro screen background to base implementation and use colour fading 2022-07-08 02:12:01 +09:00
216150b52d Avoid always loading new background at MainMenu
This was meant to be an optimisation to allow the background to load
while the intro is playing, but as the current default intro loads a
background itself, this was rarely the case and also counter-productive
as it would bypass the equality check and start a second load sequence.
2022-07-08 02:12:01 +09:00
789904ccd1 Avoid reloading background unnecessariyl when not yet loaded 2022-07-08 02:12:01 +09:00
9d730f8440 Fix custom rulesets not importing scores at all
Replaces the error with the ability to import, minus replays.

Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
e1b434b5dc Fix song select placeholder not showing convert hint for custom rulesets 2022-07-07 14:46:51 +09:00