bd6f8bde9f
Merge pull request #19079 from peppy/fix-audio-playback-disposed
...
Fix potential crash during shutdown sequence if intro playback was aborted
2022-07-12 17:29:23 +09:00
cad18ebc58
Reword comment to better explain what we are guarding against
2022-07-12 16:46:19 +09:00
cafe30fc4d
Fix potential crash during shutdown sequence if intro playback was aborted
...
Fixes one of the audio related `ObjectDisposedException`s
(https://sentry.ppy.sh/organizations/ppy/issues/92/events/12f282f048cb4a4fae85810e8a70b68d/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=7d ).
Ran into this while testing locally. See
`IntroScreen.ensureEventuallyArrivingAtMenu` for the related cause of
this happening (forced continuing to next screen if the intro doesn't
load in time).
2022-07-12 15:20:30 +09:00
b52ea16133
Show basic error message when score submission fails
2022-07-12 15:10:59 +09:00
d82d50e308
Merge pull request #19065 from Ludio235/master
...
Fix playlist room creation screen pushing content on opening dropdowns
2022-07-12 13:22:38 +09:00
3ca10ac02c
Merge pull request #19063 from Joehuu/fix-samples-cancel-exit
...
Fix editor playing object samples while paused after cancelling exit
2022-07-12 12:51:27 +09:00
0434c10914
Use global WorkingBeatmap in PlayerArea for the time being
2022-07-11 02:57:44 +09:00
8116a4b6f6
Fix multiplayer spectator crash due to track potentially not being loaded in time
2022-07-11 02:51:40 +09:00
52aef09cd6
Update PlaylistsRoomSettingsOverlay.cs
2022-07-10 02:05:40 +00:00
834bb1f187
Fix editor playing object samples while paused after cancelling exit
2022-07-09 12:14:39 -07:00
5651eca06c
Merge branch 'master' into custom-ruleset-score-import
2022-07-08 19:03:47 +09:00
eab3eba70e
Move event handlers to LoadComplete
2022-07-08 15:09:16 +09:00
1e159eb328
Add back fade to black duration
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com >
2022-07-08 10:43:50 +09:00
07a08d28c6
Rename parameter and default to 0
2022-07-07 23:31:06 +03:00
15d070668d
Move intro screen background to base implementation and use colour fading
2022-07-08 02:12:01 +09:00
216150b52d
Avoid always loading new background at MainMenu
...
This was meant to be an optimisation to allow the background to load
while the intro is playing, but as the current default intro loads a
background itself, this was rarely the case and also counter-productive
as it would bypass the equality check and start a second load sequence.
2022-07-08 02:12:01 +09:00
789904ccd1
Avoid reloading background unnecessariyl when not yet loaded
2022-07-08 02:12:01 +09:00
9d730f8440
Fix custom rulesets not importing scores at all
...
Replaces the error with the ability to import, minus replays.
Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
e1b434b5dc
Fix song select placeholder not showing convert hint for custom rulesets
2022-07-07 14:46:51 +09:00
4c3789ec5d
Split into a function
2022-07-05 11:15:37 +02:00
bb0f212448
Trigger the initial cookie with midi and joysticks
2022-07-05 00:38:18 +02:00
9bf91835b6
Merge pull request #18962 from peppy/slider-range-control
...
Move star difficulty filter to song select
2022-07-03 21:58:00 +09:00
724fd19038
Remove nullable disables
2022-07-03 21:15:13 +09:00
1ccfd69690
Merge pull request #18978 from peppy/send-beatmap-hash-to-server
...
Send beatmap hash to server on solo score request
2022-07-03 13:18:17 +09:00
052a786eff
Only show hover effect on one nub at a time
2022-07-03 03:06:03 +09:00
7d8ea5e286
Remove unnecessary proxying
2022-07-03 02:59:10 +09:00
2a1777fa85
Merge branch 'master' into fix-player-star-difficulty-display
2022-07-02 18:57:46 +09:00
19d300e311
Fix player loader not accepting star difficulty updates after display
2022-07-02 09:17:38 +03:00
a03abc747b
Tidy up comments and simplify bounding box centre logic
2022-07-02 12:58:34 +09:00
1fd9c64803
Change song select FooterButton sound
2022-07-02 12:48:33 +09:00
634b6cdbbe
Send beatmap has to server on solo score request
...
Right now, the client does nothing to ensure a beatmap is in a valid
state before requesting to submit a score. There is further work to be
done client-side so it is more aware of this state (already handled for
playlists, but not for the solo gameplay loop), but the solution I have
in mind for that is a bit more involved.
This is not used server-side yet, but I want to get this sending so we
can start using it for some very basic validation.
Will resolve the basic portion of #11922 after implemented server-side.
2022-07-02 12:16:17 +09:00
3b1842a2c2
Merge pull request #18835 from peppy/beatmap-update-flow
...
Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow
2022-07-01 20:28:04 +09:00
6baccad058
Merge pull request #18821 from ggliv/locked-room-filter
...
Add room access type filter to multiplayer lounge screen
2022-07-01 19:37:43 +09:00
b829884861
Merge pull request #18963 from peppy/more-placeholder-suggestions
...
Add difficulty filter reset to song select "no results" suggestions
2022-07-01 17:55:23 +09:00
b460a52faf
Merge pull request #18966 from smoogipoo/fix-flaky-multiplayer-test
...
Fix test sometimes referencing old ModSelect object
2022-07-01 17:55:06 +09:00
e213c1a4ef
Rename enum to explicitly mention it is a filter
2022-07-01 17:27:03 +09:00
9911c6cbf0
Merge branch 'master' into locked-room-filter
2022-07-01 17:17:01 +09:00
58c9bb031f
Apply PR reviews/fixes
2022-07-01 16:51:15 +09:00
c22e77e481
Fix test sometimes referencing old ModSelect object
2022-07-01 16:46:27 +09:00
58e25a3a01
Fix potential crash in BeatmapLeaderboard during rapid refresh operations
2022-07-01 15:42:35 +09:00
3e0f4e7609
Add test coverage of difficulty filter reset
2022-07-01 15:28:55 +09:00
f3af612133
Suggest removing difficulty filter if no matches found at song select
2022-07-01 15:18:04 +09:00
545df0a8e8
Display difficulty on nub
2022-07-01 15:17:26 +09:00
cb9947b1c9
Align song select components a bit better
2022-07-01 15:17:12 +09:00
32139ac13f
Tidy up implementation and add basic visual test
2022-07-01 15:16:58 +09:00
d54f7fc728
Move slider range control to song select
2022-07-01 14:41:36 +09:00
aab4dcefbd
Remove unnecessary invalidation handling flow
2022-06-30 17:13:26 +09:00
98938821e5
Merge branch 'master' into beatmap-update-flow
2022-06-30 16:44:17 +09:00
e3eba58cb6
Catch in triangles intro
2022-06-29 13:37:42 +03:00
6bfd351dec
Add logging of GameplayClockContainer seeks
2022-06-28 15:23:29 +09:00
