Commit Graph

6841 Commits

Author SHA1 Message Date
da7ff4b160 Update remaining tooltip implementations to use generics 2021-08-31 20:01:13 +03:00
208f66cc76 Simplify user graph tooltips logic
The same tooltip can be used for the rank graph, the play history graph,
and the replay history graph.

The only difference between those three is the displayed label, which
has now been included as part of the `TooltipContent`, rather than
unnecessarily recreating tooltips just for different sprite texts.
2021-08-31 19:59:38 +03:00
a190801291 Revert no longer required tooltip content changes 2021-08-31 19:36:27 +03:00
9afc482598 Merge branch 'master' into move-incompatibility-icon 2021-08-31 19:27:43 +03:00
999386da29 Cleanup 2021-08-31 21:47:49 +09:00
fee94236de Fix update-thread pauses 2021-08-31 21:36:31 +09:00
bfcadcc4ac Revert some changes 2021-08-31 19:18:01 +09:00
570d36fde7 Make toolbar handle mouse events instead 2021-08-30 20:53:43 -07:00
e19d81c88c Fix potential incorrect ordering 2021-08-30 19:41:44 +09:00
458ce250f0 Use new ScoreManager method in ScoreTable 2021-08-30 19:34:12 +09:00
b217dd1a65 Order scores by score 2021-08-30 19:03:16 +09:00
47061c0210 Trigger refresh on scoring mode change 2021-08-30 18:57:30 +09:00
1aeae2b8c8 reverse ternary operator 2021-08-30 10:11:41 +01:00
678386f5c4 Fix missed null coalesce 2021-08-30 16:05:56 +09:00
fa2bf42188 Update tooltip implementations 2021-08-30 16:05:00 +09:00
90c313e2ad add methods to get a user from their username 2021-08-29 19:19:55 +01:00
6dc11543ad Handle (null?) PP in PerformanceTable 2021-08-29 17:20:33 +03:00
6aaef7b0be Handle null PP during score set in TopScoreStatisticsSection
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
8f3416d853 Assert PP not null when showPerformancePoints is true 2021-08-29 16:03:39 +03:00
e374ef163d Update localisable formattable extensions usages inline with framework change 2021-08-29 15:00:28 +03:00
9a5445bded Fix overlays closing when clicking any empty area of the toolbar instead 2021-08-28 22:25:13 -07:00
38912bfc16 Fix floating overlays not closing when clicking some empty area of the toolbar 2021-08-28 20:38:35 -07:00
589f2863ca Move incompatibility tooltip logic to local player mod select overlays
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.

That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.

Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
e527bfd4bf Move incompatibility icon logic to local player mod select overlays 2021-08-28 02:37:46 +03:00
6a916a264f Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
a5f6c287ea Split out pinned comment content to only be constructed when required 2021-08-24 14:43:28 +09:00
8cd972a9fe Merge branch 'master' into pinned-comment 2021-08-24 14:37:31 +09:00
c3b7ce0b05 Remove stray newline 2021-08-24 14:02:50 +09:00
afd01d22d6 Adjust visuals of incompatible icon and move to own class 2021-08-24 14:01:49 +09:00
bf0a1167ec Improve update flow and ensure selected mods is read from local context 2021-08-24 13:35:39 +09:00
3c9718339c Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables
Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable
2021-08-24 11:58:13 +09:00
b8fe03b77f Use Mod.Equals for comparison 2021-08-24 09:50:09 +08:00
6e3d05c7ce Display an icon to signify incompatibility instead of a red tint 2021-08-24 09:42:53 +08:00
6bea744e34 invalidate scroll position 2021-08-23 17:13:25 +01:00
f8a7e0bdb6 Update rankings overlay ruleset bindable with parent on initial display 2021-08-23 13:50:39 +03:00
d3958eb3fb Revert initial ruleset value logic 2021-08-23 13:28:21 +03:00
f4b69ceb8a Remove unused using embedded in reverted changes 2021-08-23 12:40:20 +03:00
257934a144 Revert "Revert ruleset when not applied filters (includes scope change)"
This reverts commit 9fa39cd34e.
2021-08-23 12:38:30 +03:00
eeeaefbd7d Revert "Store default ruleset value for ability to revert"
This reverts commit cb7c2f713b.
2021-08-23 12:38:24 +03:00
9fa39cd34e Revert ruleset when not applied filters (includes scope change) 2021-08-23 11:11:06 +03:00
cb7c2f713b Store default ruleset value for ability to revert 2021-08-23 11:09:26 +03:00
1d89d757af Fix beatmap ruleset selector selecting initial ruleset 2021-08-23 09:57:05 +03:00
2ba88923b6 Select user preferred ruleset on overlay ruleset selectors initially 2021-08-23 08:58:54 +03:00
45b8bd175c Decouple rankings overlay's ruleset bindable from game-wide bindable 2021-08-22 16:25:35 +03:00
9b1720bd6c Merge branch 'master' into localise-beatmap-set-overlay 2021-08-22 10:53:31 +03:00
3795030ebb Merge branch 'master' into mod-incompatibility-ui 2021-08-22 11:14:24 +08:00
0bbddd297c Remove unused code 2021-08-22 11:05:53 +08:00
e213562b2a Add a red tint on mods incompatible with the current selection 2021-08-22 11:01:17 +08:00
ef6faf04be Use FirstOrDefault in TooltipContent 2021-08-22 10:22:18 +08:00
3d402d9e78 List incompatible mods in tooltip of mod button 2021-08-22 10:13:34 +08:00