Commit Graph

7035 Commits

Author SHA1 Message Date
ef3d0ee0db Merge branch 'master' into realm-integration/skins-rebase 2021-11-30 19:59:59 +09:00
8fdb9ab4e5 Merge branch 'master' into realm-integration/live-queryable-fix 2021-11-30 18:54:14 +09:00
daa7135381 Merge branch 'master' into realm-nested-context-creation-deadlock-fix 2021-11-30 18:01:00 +09:00
a286838b3a Merge branch 'realm-nested-context-creation-deadlock-fix' into realm-integration/skins-rebase 2021-11-30 16:17:55 +09:00
e83ada40f9 Merge branch 'realm-nested-context-creation-deadlock-fix' into realm-integration/skins-rebase 2021-11-30 15:56:34 +09:00
1ff0326f8e Merge branch 'master' into realm-integration/skins-rebase 2021-11-30 15:50:10 +09:00
0feec09966 Refactor beatmap importer tests to ensure realm is refreshed when waiting on state 2021-11-30 14:12:49 +09:00
a73919917c Fix intermittent test failures in TestScenBeatmapInfoWedge due to async load
https://github.com/ppy/osu/runs/4358685294?check_suite_focus=true

Occurs due to the wedge content also reloading on ruleset change, which
wasn't being accounted for. In a fail case, the content would change
during the "select beatmap" step's async load wait, causing incorrect
results.

51a353e12d/osu.Game/Screens/Select/BeatmapInfoWedge.cs (L70)
2021-11-30 12:32:09 +09:00
6b0999052f Merge branch 'master' into realm-integration/live-queryable-fix 2021-11-30 12:02:37 +09:00
2e31f5a338 Update tests to match new behaviour 2021-11-30 11:55:13 +09:00
0fc4d6dc2a Implement beatmap card difficulty list 2021-11-29 22:04:09 +01:00
431ac1d97b Remove unused using directive 2021-11-29 20:57:55 +01:00
8a188b74b1 Merge pull request #15850 from peppy/realm-integration/misc-qol
Apply a couple of realm related documentation/interface changes
2021-11-29 18:58:15 +09:00
566e10f8cc Refactor test to be easier to follow 2021-11-29 18:55:23 +09:00
f6a3709060 Store default skins to database 2021-11-29 18:28:25 +09:00
23146d59d1 Use ILive for current skin 2021-11-29 18:28:25 +09:00
2a9c7c00c8 Update tests and file access code 2021-11-29 18:28:25 +09:00
4c2b0dd2d1 Update RealmLive tests in line with modified behaviour 2021-11-29 18:28:25 +09:00
c411a755c7 Merge branch 'realm-nested-context-creation-deadlock-fix' into realm-integration/compiled 2021-11-29 18:28:07 +09:00
29f1ad10ba Merge branch 'realm-integration/misc-qol' into realm-integration/compiled 2021-11-29 18:28:03 +09:00
bac7966337 Update RealmLiveTests to use interface type 2021-11-29 18:17:30 +09:00
071a8c6709 Add test coverage showing RealmLive failure after an attach 2021-11-29 17:34:58 +09:00
54798eabc9 Add test coverage of potential deeadlock scenario with nested realm context fetching 2021-11-29 16:29:53 +09:00
791f7e3801 Update RealmLive tests in line with modified behaviour 2021-11-29 15:16:16 +09:00
d73e81ee63 Add test coverage of non-optimised existing model check 2021-11-29 14:48:28 +09:00
05f7ea6b6d Remove mentions of "panel" and "direct" from names of old download buttons 2021-11-27 15:08:03 +01:00
a043d1e427 Move old beatmap download button to more general namespace 2021-11-27 15:06:57 +01:00
567c985da0 Remove beatmap panel test scene 2021-11-27 14:56:27 +01:00
e1445dcb05 Only show owner in match subscreen 2021-11-26 17:40:45 +09:00
e9a19aacd7 Fix tests by requiring host 2021-11-26 17:23:50 +09:00
8541db1e85 Merge branch 'master' into playlist-item-add-owner 2021-11-26 17:13:23 +09:00
5e53f51c99 Merge pull request #15812 from peppy/realm-live-unmanaged-fetch-fix
Avoid attempting to fetch a non-managed `RealmLive` instance from the realm backing
2021-11-26 15:37:58 +09:00
40d1b97af1 Avoid attempting to fetch a non-managed RealmLive instance from the realm backing
For compatibility reasons, we quite often convert completely unmanaged
instances to `ILive`s so they fit the required parameters of a property
or method call. This ensures such cases will not cause any issues when
trying to interact with the underlying data.

Originally I had this allowing write operations, but that seems a bit
unsafe (when performing a write one would assume that the underlying
data is being persisted, whereas in this case it is not). We can change
this if the requirements change in the future, but I think throwing is
the safest bet for now.
2021-11-26 15:06:14 +09:00
13612c0d02 Add equality support to ILive types 2021-11-26 14:56:16 +09:00
1f5d95666e Add owner avatar to multiplayer items 2021-11-25 23:15:29 +09:00
7a3c69544b Merge pull request #15799 from smoogipoo/fix-songselect-test-failures-2
Fix SongSelect-related test failures
2021-11-25 23:01:06 +09:00
d0c0b7ce47 Fix intermittent beatmap thumbnail test 2021-11-25 22:05:39 +09:00
09dd054283 Fix SongSelect-related test failures 2021-11-25 21:11:13 +09:00
f712aeee01 Merge pull request #15795 from peppy/realm-integration/separate-download-flow
Split out download logic from main manager classes
2021-11-25 20:59:23 +09:00
eeccf836ec Remove unnecessary GameHost parameter 2021-11-25 17:42:41 +09:00
a2ab9f457d Move score download logic out of ScoreManager 2021-11-25 17:33:04 +09:00
716543b5b3 Move beatmap download logic out of BeatmapManager 2021-11-25 17:29:41 +09:00
e6cfe44652 Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel 2021-11-25 16:29:06 +09:00
306e13fa7b Remove all usages of FileStore.QueryFiles 2021-11-25 14:06:02 +09:00
1533e245de Merge pull request #15767 from bdach/beatmap-card/track-preview
Add preview track playback function to beatmap card
2021-11-25 12:08:03 +09:00
1907b42f82 Use constant online IDs in tests to avoid preview not working randomly 2021-11-24 20:34:33 +01:00
20f71da2c4 Merge branch 'master' into fix-mp-resuming 2021-11-24 20:17:58 +01:00
132bb59203 Update working beatmap when returning to match 2021-11-24 19:56:02 +09:00
ce8500a732 Merge branch 'master' into remove-model-file-list-inits 2021-11-24 19:46:42 +09:00
e176083898 Merge pull request #15781 from peppy/beatmap-set-status
Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`
2021-11-24 19:25:29 +09:00