b9d8b7e413
Fix end time extent not being accounted for in new snap implementation
2022-05-05 18:49:12 +09:00
7b71fb860b
Expose DistanceSpacingMultiplier for test usage
2022-05-05 18:49:12 +09:00
b2e9be70a5
Rewrite CircularDistanceSnapGrid snapping implementation to use snap provider
2022-05-05 17:52:36 +09:00
947a68006a
Add note about IDistanceSnapProvider not multiplying DistanceSpacing itself
2022-05-05 17:50:17 +09:00
4c884aea5d
Fix CircularDistanceSnapGrid returning an incorrect time value when distance spacing is not 1.0
2022-05-05 17:09:14 +09:00
786c7f14d3
Expose DistanceSpacingMultiplier to distance
2022-05-05 17:08:53 +09:00
de9b3d33eb
Rename misleading DistanceSpacing variable
2022-05-05 17:08:09 +09:00
4226583afd
Merge branch 'cache-at-interface'
2022-05-05 16:52:03 +09:00
19cf9dc20b
Merge branch 'snapping-tidy-distance'
2022-05-05 16:51:32 +09:00
5a1ac71d90
Remove unnecessary type specification in HitObjectComposer's caching
2022-05-05 16:44:37 +09:00
1c6a233cc0
Move snap provider caching to interfaces
2022-05-05 16:44:37 +09:00
b411b59006
Move IPlacementHandler caching to interface
2022-05-05 16:43:02 +09:00
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
6227e3f876
Add comprehensive documentation of BeatmapInfo.DistanceSpacing
2022-05-05 16:25:45 +09:00
1fce0da331
Reword slightly, to allow better conformity with IDistanceSnapProvider
2022-05-05 16:04:34 +09:00
f6fc926f1a
Add xmldoc and rename methods in IPositionSnapProvider for legibility
2022-05-05 15:58:21 +09:00
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity
...
Port test coverage from old mod select overlay to new design
2022-05-04 20:24:50 +09:00
5f11ff564b
Merge branch 'master' into mod-overlay/test-coverage-parity
2022-05-04 19:40:56 +09:00
3eead5a6a3
Rename FlushAnimation to FlushPendingSelections to better match purpose
2022-05-04 19:40:08 +09:00
bf80dd864c
Merge branch 'master' into fix-editor-toolbox-click-through
2022-05-04 11:57:32 +02:00
4e0f899159
Rename value changed variable
2022-05-04 18:13:30 +09:00
f5d4f02200
Use ToUpper for key binding text
2022-05-04 11:59:29 +03:00
0b8fd2e39f
Improve distance spacing toast inline with key binding changes
2022-05-04 11:43:19 +03:00
b325f0ee0b
Combine editor toolbox container implementation and fix input blocking
...
Until now, toolbox scroll areas would block input from arriving behind
them, even when no visible element was clicked.
In addition, clicking on a button inside a toolbox would still send a
`MouseDown` event to things behind it. Specifically, the editor's
`HitObjectComposer` would receive these events and also place objects
when the user does not expect them to be placed.
This fixes another regression that occurred due to `ScrollContainer`s no
longer blocking input theirselves.
2022-05-04 17:41:30 +09:00
3d2072498e
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:41:12 +03:00
a66743266f
Remove unused ScrollingToolboxGroup class
2022-05-04 17:20:58 +09:00
6f52a0b5eb
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:10:18 +03:00
40f1ceca0a
Merge branch 'master' into distance-spacing-keybinding
2022-05-04 16:34:01 +09:00
732739715a
Remove "grid" from strings
2022-05-04 16:31:20 +09:00
504ca5be31
Fix scrolling no longer adjusting distance spacing by amount
2022-05-04 09:52:33 +03:00
813d6fed48
Split activation keybind to separate increase/decrease keybinds
2022-05-04 09:00:54 +03:00
df530cb5ab
Add highlighting to the position snap grid edges in addition to centre lines
2022-05-04 13:49:04 +09:00
0bb90c7b07
Fix gridline centering and ensure lines are always rendered using a fixed screen-space width
2022-05-04 13:41:55 +09:00
f5fa41356e
Rewrite mod instance management again to pass tests
2022-05-03 22:31:34 +02:00
970361676b
Fix setting items not creating if mods initially not empty
2022-05-03 21:45:40 +02:00
e3641213e1
Always hide unimplemented mods on mod select screen
2022-05-03 21:45:40 +02:00
f91ee4b042
Reset panel mod instance settings to defaults on deselect
2022-05-03 21:45:40 +02:00
7c04bf5c53
Refactor mod reference management to meet test expectations
2022-05-03 21:45:40 +02:00
fe59f4ae58
Fix multiselection operation not flushing on close
2022-05-03 21:45:39 +02:00
746a4a7403
Fix mod column using wrong equality type
2022-05-03 21:45:39 +02:00
e17756fe25
Merge branch 'master' into sheared-search-textbox
2022-05-03 16:45:54 +02:00
0dd2e1652c
Mark OnScreenDisplay dependency as nullable
2022-05-03 11:15:28 +03:00
b8287f3687
Display toast notification on editor distance spacing change
2022-05-03 10:30:32 +03:00
521ec1a225
Add keybind for distance grid spacing activation
2022-05-03 10:15:24 +03:00
637f817696
Ignore zero-sections on a per-case basis
2022-05-03 16:06:20 +09:00
a555c47212
Reduce sorting complexity in worst-case of diffcalc
2022-05-03 15:02:57 +09:00
983eed32fc
Reduce complexity of icon container nesting
2022-05-03 14:48:00 +09:00
b5ea26f2fa
Fix incorrect shear masking on nested textbox
2022-05-03 14:45:17 +09:00
bc88c4ee8e
Reduce container nesting by one level
2022-05-03 14:34:18 +09:00
8e0235392f
Inline single-use constants
2022-05-03 14:31:20 +09:00
