Commit Graph

7463 Commits

Author SHA1 Message Date
91e0d1021f Merge branch 'master' into fix-out-of-order-events-on-block-fail 2022-01-26 15:21:10 +09:00
cd71ec0edd Remove ILive<> interface (and use abstract Live<> instead) 2022-01-26 13:38:56 +09:00
bdf215c576 Merge branch 'master' into improve-timeline-zoom 2022-01-26 03:40:53 +09:00
ad18bc4983 Update timeline selection test scene with zoom changes 2022-01-25 18:57:39 +03:00
5b82eaf112 Merge branch 'master' into fix-beat-divisor-not-saving 2022-01-25 23:29:37 +09:00
6c69df815a Update editor test scenes to set working beatmap properly 2022-01-25 15:56:27 +03:00
4d8c5ebb0c Merge branch 'master' into fix-beat-divisor-not-saving 2022-01-25 12:30:05 +03:00
b2b6672095 Add failing test asserts 2022-01-25 11:56:38 +03:00
ffd7877a1e Remove synchronization context hacks in realm tests 2022-01-25 17:41:22 +09:00
d8270fe14f Merge pull request #16604 from peppy/less-async-import
Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`
2022-01-25 16:47:07 +09:00
1c6ad56821 Merge pull request #16595 from peppy/realm-block-timeout-assert-failure
Fix a failed `BlockAllOperations` leaving update realm in unretrieved state
2022-01-25 16:03:13 +09:00
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
ae0fea8e26 Fix compilation issues due to misnamed fild 2022-01-25 15:29:45 +09:00
47a13c2eb0 Merge pull request #16603 from peppy/update-framework
Update framework
2022-01-25 15:15:49 +09:00
35e1c7de7d Merge branch 'master' into realm-block-timeout-assert-failure 2022-01-25 15:05:11 +09:00
bda77fb6b3 Merge branch 'master' into realm-block-timeout-assert-failure 2022-01-25 14:47:34 +09:00
56d7d81465 Fix broken test due to SynchronizationContext never running expected work 2022-01-25 14:47:21 +09:00
bfa521bdd2 Merge pull request #16593 from peppy/realm-clean-up
Clean up realm naming
2022-01-25 14:33:53 +09:00
b2114bd2f0 Merge pull request #16601 from peppy/fix-storage-migration-test-failures
Fix `TestMigration` failing due to changes in realm migration logic
2022-01-25 14:33:35 +09:00
86c844bd58 Update remaining usages of GetSuitableHost in template projects 2022-01-25 14:15:29 +09:00
8116806db3 Add test coverage of calling BlockAllOperations a second time after timeout 2022-01-25 14:00:58 +09:00
dd2caea694 Update GetSuitableHost usages in line with new HostOptions 2022-01-25 13:52:02 +09:00
bbcc149e2e During import if files are found to be missing, ensure they are restored
This is one step closer to sanity in terms of physical files. As per the
comment I have left in place, we really should be checking file sizes or
hashes, but to keep things simple and fast I've opted to just cover the
"missing file" scenario for now.

Ran into this when testing against a foreign `client.realm` by:
- Noticing a beatmap doesn't load
- Deleting said beatmap
- Downloading via beatmap overlay
- Beatmap is restored but still doesn't work

Note that I've kept the logic where this will undelete an existing
import rather than create one from fresh, as I think that is beneficial
to the user (ie. it will still keep any linked scores on restore).
2022-01-25 13:44:54 +09:00
d7342880f5 Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications 2022-01-25 13:09:48 +09:00
e23b10e6a5 Update remaining cases of clashing variable name in realm.Run(realm.. 2022-01-25 13:04:05 +09:00
3e5c9e8436 Fix cases of Access instead of Realm 2022-01-25 12:58:15 +09:00
2d34831b5f Fix TestMigration failing due to changes in realm migration logic
Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true.
2022-01-25 12:54:40 +09:00
f30894840c Update terminology to realm "instance" rather than "context"
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
9ff9611296 Merge branch 'master' into realm-stable-subscriptions 2022-01-24 18:25:47 +09:00
d7db6fa918 Merge branch 'master' into custom-meter 2022-01-24 15:46:44 +09:00
6581e8c2d3 Merge pull request #16549 from Susko3/LoginPanel-flag
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
40aa873190 Rename register methods to better explain their purpose 2022-01-24 14:37:36 +09:00
e236f5d604 Add failing test coverage for correct beatmap filename generation on save 2022-01-23 20:28:19 +01:00
0709a2ac9b Add test coverage of realm subscription scenarios 2022-01-23 20:28:13 +09:00
db86394355 Fix TestResources returning a test BeatmapSetInfo that can't be laoded directly into realm 2022-01-23 20:28:04 +09:00
1ea5a2e6a7 Fix incorrect assert step name 2022-01-23 10:11:12 +03:00
f39f2c93b5 Add control for arbitrary-numerator time signatures 2022-01-22 20:50:31 +01:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
6a076a684e Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions 2022-01-22 13:14:25 +09:00
c9db0181d0 Attempt to fix test failures on windows due to context being held open 2022-01-22 12:24:05 +09:00
9b63f15e68 Add failing test 2022-01-21 13:58:30 +01:00
1f157d729d Update existing subscriptions to new style
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00
114c9e8c1f Update all usages of CreateContext to use either Run or Write 2022-01-21 17:27:08 +09:00
70cc03fe43 Avoid constructor overhead for realm RealmKeyBinding parameterless constructor 2022-01-20 17:29:07 +09:00
7509b31176 Merge pull request #16519 from peppy/fix-legacy-score-import-classic-mod
Fix legacy score imports not correctly getting classic mod assigned
2022-01-20 14:28:29 +09:00
4f86a2cb61 Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
4cad5890c6 Add test coverage for news sidebar showing wrong headers 2022-01-19 23:12:35 +01:00
d925e44b40 Add test coverage for beatmap card expanded content clipping 2022-01-19 22:08:52 +01:00
fea4400c03 Remove unused using directive 2022-01-19 18:49:37 +01:00