Commit Graph

40673 Commits

Author SHA1 Message Date
0cf13dab8d Merge pull request #12391 from frenzibyte/replays-tooltip-graph
Display separate "replays watched" tooltip for replays subsection
2021-04-13 19:25:50 +09:00
2884ed3ab9 Merge pull request #12350 from smoogipoo/multiplayer-spectator-player-grid
Add the multiplayer spectator player grid
2021-04-13 19:25:32 +09:00
4618728bf0 Add test case 2021-04-13 11:35:12 +02:00
d41e3690fc Merge pull request #12390 from peppy/fix-import-multiple-file-types
Fix import multiple file types via drag potentially reaching the wrong importer
2021-04-13 18:21:54 +09:00
a0513f64f9 Merge branch 'master' into replays-tooltip-graph 2021-04-13 18:21:10 +09:00
fd32c7d7df Merge pull request #12393 from peppy/update-timeline-design-a-bit
Update timeline tick display to differentiate tick type using width
2021-04-13 18:14:58 +09:00
130bd0bee1 Merge pull request #12394 from peppy/change-default-waveform-opacity
Change default waveform opacity
2021-04-13 18:14:51 +09:00
aa5fe2e9fc Rename BeatmapVerifier -> IBeatmapVerifier 2021-04-13 11:02:01 +02:00
7c53bebfd4 Fix beatmap background not hiding when user settings ignored and storyboard replaces background 2021-04-13 12:00:13 +03:00
15658eda55 Add failing test case 2021-04-13 12:00:13 +03:00
304fe5cd34 Add CheckBackground to OsuBeatmapVerifier 2021-04-13 10:41:02 +02:00
60c2494b31 Make BeatmapVerifier an interface 2021-04-13 10:40:56 +02:00
b41e3a2e7a Remove unused using statement 2021-04-13 17:38:32 +09:00
c8cb4286f6 Add reference for screen bounding box numbers 2021-04-13 10:35:06 +02:00
98c25b2e71 Remove unused import 2021-04-13 10:33:08 +02:00
36510309d1 Merge EnableUserDim and IgnoreUserSettings to one bindable 2021-04-13 10:58:56 +03:00
0932daeaa8 Force the new default on update 2021-04-13 16:50:03 +09:00
5a06db8a11 Change default editor waveform opacity to 25%
The previous setting felt way too high.
2021-04-13 16:48:06 +09:00
27e851c2ee Also adjust height 2021-04-13 16:43:29 +09:00
ebf97ff48f Update timeline ticks to use width as a differentiation method, rather than height 2021-04-13 16:29:35 +09:00
a9652b7b25 Start TimelineTestScene in a more visible place 2021-04-13 16:05:12 +09:00
57ba7b7cbb Partially revert the changes of CurrentFrame and NextFrame for compatibility
Making those always non-null is postponed as when a replay's frame contains keypress the behavior is changed.
Previously, the key is pressed at the time of the first frame. But using non-null frames means the key is pressed at negative infinity.
However, I think the new way of always using non-null frames makes the client code so I plan to bundle the change to more breaking changes.
2021-04-13 15:55:23 +09:00
20a432c083 Merge pull request #12392 from peppy/avoid-score-online-id-conflicts
Don't store online IDs from score submission responses for now
2021-04-13 15:40:03 +09:00
20e84f14e6 Merge pull request #11328 from frenzibyte/mod-using-reference-equality
Fix mods using reference equality unless cast to `IMod`
2021-04-13 15:36:22 +09:00
fbc6fb8fc5 Split out common logic into private method and add inline comment for future visitors 2021-04-13 15:35:57 +09:00
9f8af03a70 Remove irrelevant change 2021-04-13 09:28:58 +03:00
b45d7de4ec Update asserts to use better nunit specifications 2021-04-13 15:04:01 +09:00
4837cef095 Use static for playfield centre positioning 2021-04-13 14:44:52 +09:00
273099d53c Don't store online IDs from score submission responses for now
Closes remaining portion of https://github.com/ppy/osu/issues/12372.
2021-04-13 14:31:44 +09:00
d0f30b7b42 Delay map completion one frame after the last judgment
This is a workaround of a timing issue.
KeyCounter is disabled while break time (`HasCompleted == true`).
When the last keypress is exactly at the same time the map ends, the last frame was considered in a break time while forward play but considered not in a break time while rewinding. This inconsistency made the last keypress not decremented in the key counter when a replay is rewound.
The situation regularly happens in osu!standard because the map ends right after the player hits the last hit circle. It was caught by `TestSceneGameplayRewinding`.

This commit makes the update of the map completion delayed one frame. The problematic keypress frame is now processed strictly before the map completion, and the map completion status is correctly rewound before the keypress frame.
2021-04-13 14:29:47 +09:00
4852630c93 Fix import multiple file types via drag potentially reaching the wrong importer 2021-04-13 14:03:42 +09:00
a664efe12b Fix history graph tooltips leaking to others
Since there was no check about which tooltip content came from which graph, all history graphs use the "Replays Watched" tooltip, as it is the latest created one.
2021-04-13 07:59:14 +03:00
38d10755cb Merge branch 'master' into refactor-framed-replay-input-hander 2021-04-13 13:47:22 +09:00
516bd138e3 Add (previously failing) test coverage of drag from selection 2021-04-13 13:46:38 +09:00
7c975359d9 Add basic select/deselect tests 2021-04-13 13:29:37 +09:00
05d7fe289f Rename test scene in preparation for increasing scope 2021-04-13 13:09:18 +09:00
66e74da2b7 Fix regression in quick delete mouse action blocking 2021-04-13 13:03:14 +09:00
16d34bcc0a Expose the latest end time of storyboard elements
Co-authored-by: Marlina Bowring <marlina@umich.edu>
2021-04-12 23:08:43 -04:00
17c2c4e885 Fix test case filename not matching 2021-04-13 05:31:56 +03:00
6d3f9fa9ce Use is class instead of Equals with template index
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
0bcc39bd36 Remove redundant space 2021-04-13 02:17:35 +02:00
8a6dfcfae1 Add CheckOffscreenObjects tests 2021-04-13 01:22:36 +02:00
47cf4bcf25 Add CheckBackground tests 2021-04-13 01:22:24 +02:00
d8088777ea Add Equals method to IssueTemplate
This will be useful in tests.
2021-04-13 01:21:34 +02:00
8f84abf348 Display "replays watched" tooltip for replays subsection 2021-04-12 21:51:06 +03:00
9679bdfed2 Merge branch 'master' into mod-using-reference-equality 2021-04-12 20:56:24 +03:00
589e1a2a47 Add mod settings equality test 2021-04-12 20:51:24 +03:00
92fab653e1 Take current mod settings value into account on equality comparsion 2021-04-12 20:51:13 +03:00
d9e3276d0e Don't update path type once immediately 2021-04-12 19:18:22 +02:00
84e1ff79a0 Merge pull request #12352 from smoogipoo/multiplayer-spectator-leaderboard
Implement the multiplayer spectator leaderboard
2021-04-13 01:51:14 +09:00