Commit Graph

252 Commits

Author SHA1 Message Date
35f97dfc75 Style changes 2020-04-09 18:59:18 +03:00
f40bdcd34e Initial rewrite, moving API logic to SongSelect 2020-04-09 18:47:28 +03:00
260de77304 Merge branch 'master' into select-recommended 2020-04-09 15:30:35 +09:00
ed3e0a01e1 Re-namespace into song select 2020-04-07 15:31:22 +09:00
1e8badb14a Move all logic to TopLocalRank and remove CarouselBeatmapRank 2020-04-04 22:28:36 +03:00
faa2b49be4 Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly 2020-03-28 18:13:39 +02:00
1c711147f3 Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank) 2020-03-28 17:22:01 +02:00
ee112c6f50 Move and change logic 2020-03-26 18:42:08 +02:00
2f5dc93d61 Select recommended difficulty 2020-03-26 00:19:54 +02:00
8f9e97b4cc Fix carousel not remembering last selection correctly 2020-03-19 18:07:39 +09:00
9bb3a6c677 Merge branch 'master' into click-group-difficulty-icons 2020-03-16 12:01:09 +09:00
d6be8eec0c Merge branch 'master' into click-disabled-difficulty-icons 2020-03-16 11:30:57 +09:00
3f8b454ff4 Reword comment to match new filtering behaviour
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-13 10:01:28 +09:00
6e11c3014c Allow grouped difficulty icons to be clicked 2020-03-12 18:42:08 +09:00
ce5d01ed19 Allow filtered difficulty icons to be clicked 2020-03-12 18:42:08 +09:00
fc058f8896 Remove unnecessary this. prefix 2020-03-12 18:03:18 +09:00
933a8ffc8a Add test coverage 2020-03-12 17:10:51 +09:00
63edcddaf1 Apply ruleset filter in all cases (even when bypassing filter for selection purposes) 2020-03-12 15:06:26 +09:00
9119e32f63 Merge branch 'master' into better-filter-bypass 2020-03-11 13:37:55 +09:00
ed837d3115 Use framework extension method for FromHex 2020-03-11 10:18:41 +09:00
a2d3f20409 Merge branch 'master' into better-filter-bypass 2020-03-11 02:55:14 +09:00
979988235d Increase flexibility of StarCounter component 2020-03-08 15:56:22 +09:00
332f56a7f8 Fix nullref in tests 2020-03-05 20:34:24 +09:00
f8776a0be4 Display all difficulties from overriding selection 2020-03-04 22:59:49 +09:00
a62550b323 Reapply filters on next change after a forced beatmap display 2020-03-04 20:14:18 +09:00
7ad6ad0bb0 Remove hacks that bypassed layout shortcomings 2020-02-27 13:32:23 +09:00
cd666166d5 Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
8c81f1e684 Move CarouselBeatmap access to private, test using indices 2020-02-15 17:51:55 -08:00
8e1ecddb1d Add testing 2020-02-14 17:23:24 -08:00
c46d828716 Preserve permitNulls 2020-02-14 20:59:51 +07:00
10798aeab3 Fix code formatting 2020-02-14 20:30:27 +07:00
c753cb46c5 Use [Resolved] wherever possible 2020-02-14 20:14:00 +07:00
368e6f9579 Use CarouselBeatmap.State to select 2020-02-13 17:47:16 -08:00
c871f07d2e Use CarouselBeatmap action to select beatmap 2020-02-13 17:14:46 -08:00
ad0de27964 Safer dependency injection and accessibility levels 2020-02-12 22:11:26 -08:00
f8b69fe632 Remove unnecessary carousel variable, fix code formatting 2020-02-12 20:11:39 -08:00
b126c00292 Use dependency loader to get SongSelect instance 2020-02-12 19:05:08 -08:00
2901ec9f26 Select specific difficulties using their icons 2020-02-11 20:05:26 -08:00
66fb72cd8a Fix song select not showing active beatmap if it is filtered by local criteria 2020-02-10 16:59:54 +09:00
9e0e7be8d0 Modernise filter implementation 2020-01-24 18:57:17 +09:00
12cc97ca31 Merge remote-tracking branch 'origin/master' into star-filtering
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
#	osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs
#	osu.Game/Screens/Select/FilterControl.cs
#	osu.Game/Screens/Select/FilterCriteria.cs
2020-01-24 18:30:52 +09:00
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
caf3f774ba CA1309: compare strings correctly. 2019-12-17 13:00:15 +08:00
48287459a0 Optimise filters to avoid property retrieval
Also reduces number of instantiations of SearchableTerms array in the case of multiple criteria terms.
2019-12-05 01:52:22 +09:00
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
c181edaedf Replace manual comparer implementation
Replace manually-implemented CriteriaComparer with a call to
Comparer<T>.Create() to decrease verbosity.
2019-10-28 15:07:36 +01:00
c8d3dd0e5a Make carousel item sorting stable
Migrate beatmap carousel item sorting from List<T>.Sort()
to IEnumerable<T>.OrderBy(), as the second variant is documented to be
a stable sorting algorithm. This allows for eliminating unnecessary
movement of carousel items occurring whenever any set of items is tied
when changing sorting criteria.
2019-10-27 23:14:14 +01:00
f15953d65c Fix carousel including filtered difficulties in sort comparisons 2019-10-07 15:17:03 +09:00
b262ba13cd Add creator= and artist= filters
To match stable, add creator= and artist= filters to the beatmap
carousel on song select screen. Contrary to stable, this implementation
supports phrase queries with spaces within using double quotes.

The quote handling is not entirely correct (can't nest), but quotes
should rarely happen within names, and it is an edge case of an edge
case - leaving best-effort as is. Test coverage also included.
2019-09-22 00:20:55 +02:00
7683f7ff23 Make OnlineStatus use OptionalRange 2019-09-19 17:12:07 +09:00