Commit Graph

681 Commits

Author SHA1 Message Date
eb716455b7 Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
0bc6a026eb Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
c3bf6a0287 Remove weird vestigial Current reimplementation
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
01eff7f316 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 16:30:08 +09:00
93f10330e3 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 16:29:10 +09:00
ad398165a2 Update AccuracyCounter components to use DI to attach data source 2021-05-07 16:27:25 +09:00
a2e4fb5b6b Update ScoreCounter components to bind outwards 2021-05-07 16:16:48 +09:00
15603de6e9 Change scale multiplier to be closer to expectations 2021-05-03 15:25:18 +09:00
7d8be8cd83 Add comment about why we are running checkForComponents on a timer 2021-05-03 15:20:00 +09:00
a298a93070 Remove redundant storage of blueprint's related item 2021-05-03 15:18:18 +09:00
51f4077b27 Reorder methods in SkinSelectionHandler to follow standards 2021-05-03 15:15:00 +09:00
a2faa0b74c Remove dead code 2021-05-03 15:13:53 +09:00
01984de9c7 Use existing GetStateFromSelection helper function 2021-05-03 15:13:32 +09:00
f3b305bbe6 Rename and improve xmldoc of SkinEditorOverlay 2021-05-03 14:58:25 +09:00
cdef07b2ee Fix blueprints not hiding when deleting elements 2021-04-30 13:09:57 +09:00
8d056ff38f Remove redundant parenthesis 2021-04-29 18:23:22 +09:00
fb64f6faf2 Add ability to exit using game "back" binding 2021-04-29 17:40:58 +09:00
a7982787d4 Add basic header text 2021-04-29 17:40:48 +09:00
b936043956 Add the skin editor to the game 2021-04-29 17:20:22 +09:00
b460181f15 Add note about rotation not working as expected 2021-04-29 16:16:52 +09:00
1516e2ffef Update blueprint implementation in line with #12625. 2021-04-29 16:12:31 +09:00
3c84b0d8c6 Fix selection screen point being wrong since recent refactors 2021-04-29 16:12:15 +09:00
de73ac7cec Allow skin editor to be invoked from any context
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.

This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
4f9e1e4945 Check for new components every one second to handle late loaders 2021-04-29 16:12:15 +09:00
fd587a82ff Replace abstract class with interface, attached to the actual components (not skinnable wrapper) 2021-04-29 16:12:15 +09:00
59339aa4fd Add support for x/y position and scale back in 2021-04-29 16:12:15 +09:00
1cb8fc9a24 Extract editor classes out of test namespace and add anchor support 2021-04-29 16:12:15 +09:00
281c2041b2 Add failing test 2021-04-20 16:51:00 +09:00
1b6e08b3eb Fix incorrect default font overlap for score and combo 2021-03-26 10:35:46 +03:00
6aa0c9d8fd Merge branch 'master' into legacy-sprite-text-fonts 2021-03-25 14:52:01 +03:00
41cf261286 Merge pull request #12177 from peppy/fix-comment-parsing-regression
Don't strip comments from metadata during parsing
2021-03-25 15:02:10 +09:00
0324bfa857 Change checks back to Contains 2021-03-25 14:14:38 +09:00
e22650293d Remove unnecessary second call to StripComments in skin parsing logic 2021-03-25 13:35:42 +09:00
fc5719e445 Fix SkinManager not handling extensions casing comparsion properly 2021-03-24 21:31:53 +03:00
073dba5330 Remove local workarounds to attempt to avoid crashes on skin change 2021-03-22 14:05:37 +09:00
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
ca943a897a Fix back to front initialisation order 2021-03-20 10:51:58 +09:00
68aaf90702 Fix disposal rather than performing some weird hack 2021-03-19 20:30:52 +09:00
f59327cc3e Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-19 20:29:44 +09:00
b2d8db3a92 Rename incorrect variable 2021-03-19 20:25:21 +09:00
c0c8b3e46c Fix regression meaning SkinnableSound initialisation may never happen 2021-03-19 19:22:50 +09:00
9491e6394a Include the bundled skins when selecting a random skin 2021-03-19 15:46:43 +09:00
bf4317d3f0 Ensure looping is disabled on old samples when switching skins 2021-03-19 15:34:21 +09:00
0e821e857e Remove unnecessary duplicated skin changed handling
For some reason we were handling this both in `DrawableSkinnableSound`
and `PoolableSkinnableSample` in very similar ways. Only one seems
required.
2021-03-19 15:23:32 +09:00
b419d2c2e2 Fix invalid xmldoc indent 2021-03-18 19:52:38 +01:00
aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
5b0d75ee56 Only trim trailing spaces to avoid breakage in storyboard parsing 2021-03-18 16:30:30 +09:00
2bdffd1004 Move skin requery logic into extension methods 2021-03-15 13:11:58 +09:00
0a1e325fc7 Extract requerying of navigational properties from DbContext 2021-03-14 19:34:53 +03:00
43c1e1d217 Update existing usages
Resolve post-conflict issues
2021-03-13 06:09:07 +03:00