f2e56bd306
Refactor editor selection/blueprint components to be generic
2021-04-27 19:01:29 +09:00
3ea55314f2
Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-04-27 11:29:16 +02:00
003553aba3
Add test of HitObjectLifetimeEntry.KeepAlive behavior
2021-04-27 18:10:44 +09:00
3899e500d3
Adopt framework change of LifetimeEntry
...
Override SetLifetimeStart/SetLifetimeEnd separately to track individual assignment. It is necessary to ensure real lifetime is not lost when lifetime is partially updated.
2021-04-27 17:54:18 +09:00
aaf65b64f5
Merge pull request #12589 from Cublibre/admin-notification
...
Send a notification if game is run as admin/root
2021-04-27 15:25:13 +09:00
c9e6ca5378
Use now-public Entry.SetLifetime method
2021-04-27 15:25:05 +09:00
a2c0951d94
Use overriding instead of hiding in HitObjectLifetimeEntry
...
Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.
2021-04-27 15:23:33 +09:00
dbcb1259e2
Add a note about elevated privileges also breaking integrations
2021-04-27 14:38:19 +09:00
2673cd3d99
Remove unnecessary noop action
2021-04-27 14:36:15 +09:00
13de571b3c
Rename private method
2021-04-27 14:35:57 +09:00
2303d108bb
Simplify false return path
2021-04-27 14:35:14 +09:00
7980d16b4c
Add failing test showing the issue of DHO lifetime
2021-04-27 14:26:12 +09:00
ea3c5aed2f
Merge pull request #12590 from peppy/editor-minor-refactors
...
Fix a couple of inspections in editor code
2021-04-27 14:09:36 +09:00
ec1c336b0a
Fix a couple of inspections
2021-04-27 13:23:14 +09:00
5a3fbef5ac
Use a try-catch, notification activation does nothing
2021-04-27 00:23:08 -04:00
e0f54f5842
Move load() before LoadComplete()
2021-04-26 22:51:03 -04:00
a2723f3f57
Perform elevated check asynchronously, use a separate function w/ switch statement
2021-04-26 22:44:22 -04:00
c3bad1d4c5
Rename AdminChecker to ElevatedPrivilegesChecker, refactor elevated check
2021-04-26 21:05:18 -04:00
7a6e9e5070
Change category of unsnap check to timing
...
Makes more sense, as this is typically the result of timing changes.
2021-04-27 02:32:57 +02:00
9e49ecb573
Remove unused virtual keywords
...
Added these in a previous iteration, where I had the mania variant inherit this class.
No longer necessary as `IHasColumn` was used to make this check more generic.
2021-04-27 02:23:06 +02:00
260dd06f47
Move AdminChecker to osu.Desktop.Admin
2021-04-26 20:04:34 -04:00
a3c1b1fd52
Fix accessibility of areConcurrent
2021-04-27 01:24:38 +02:00
217ff8238e
Add snapping time comment
2021-04-27 01:23:03 +02:00
6d5883abcb
Return result of local variable instead
2021-04-27 01:19:38 +02:00
0f0870c8b8
Sort objects by time in concurrent check test
2021-04-27 00:36:26 +02:00
9ad30da729
Show a notification if game is run as administrator
2021-04-26 16:41:26 -04:00
ce258febf6
Rename CheckUnsnaps -> CheckUnsnappedObjects
...
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
b9e4f73f78
Add concurrent objects check to BeatmapVerifier
2021-04-26 20:28:59 +02:00
b8cdcf56c0
Add concurrent object check tests
2021-04-26 20:22:24 +02:00
a3570e18dd
Add concurrent objects check
...
Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`.
We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.
2021-04-26 20:17:18 +02:00
08a232f7fa
Add method to safely refresh DrawableHitObject transforms
2021-04-26 20:08:40 +02:00
71f880aa94
Fix duplicate code in unsnap test
2021-04-26 17:44:46 +02:00
9b9c473616
Remove redundant string formatting
2021-04-26 16:17:38 +02:00
7b9ed924be
Rename snapping methods
...
Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces.
Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.
2021-04-26 16:07:30 +02:00
bec16436b0
Merge pull request #12583 from smoogipoo/fix-score-export
...
Fix exported scores not being compatible with osu-stable
2021-04-26 22:32:18 +09:00
213ac88a8b
Fix exported scores not being compatible with osu-stable
2021-04-26 20:52:20 +09:00
6560dc2d1f
Fix exported replays being wrapped in zip packages
2021-04-26 20:46:44 +09:00
559d403abe
Rename ColourCodedNotes to TimingBasedNoteColouring
2021-04-26 19:05:12 +08:00
58ebec4803
Move BindValueChanged hooks to LoadComplete()
2021-04-26 19:00:40 +08:00
47925de7ae
Merge pull request #12500 from ekrctb/drawable-object
...
Factor out pooling and lifetime management logic of DHO to a base class
2021-04-26 19:30:43 +09:00
6d2a5b614c
Merge branch 'master' into drawable-object
2021-04-26 18:33:44 +09:00
72d9cdcdf9
Merge pull request #12580 from peppy/fix-editor-slider-repeat-animation
...
Fix slider repeats and tails still animating with editor hit animations disabled
2021-04-26 17:36:51 +09:00
1e0ee3cd61
Merge branch 'master' into fix-editor-slider-repeat-animation
2021-04-26 16:45:04 +09:00
0727728771
Merge pull request #12579 from peppy/rename-edit-classes
...
Rename "EditRuleset" and "EditPlayfield" to use full "Editor" keyword
2021-04-26 16:44:35 +09:00
8b60f6e7fb
Merge pull request #12581 from smoogipoo/fix-simultaneous-slider-input
...
Fix simultaneous slider input not allowing both keys to be accepted
2021-04-26 16:21:48 +09:00
0d0b4ea78a
Rewrite comment to hopefully be more readable
2021-04-26 15:47:37 +09:00
fd5fbaf0db
Rename ruleset wrapper class
2021-04-26 15:37:42 +09:00
f70e45b199
Prevent adding null enumerable
2021-04-26 15:35:08 +09:00
d10aac851d
Extract scale constant
2021-04-26 15:30:22 +09:00
8795c5f082
Update osu! editor transform logic to allow adjustments to DrawableSliderRepeat and DrawableSliderTail
2021-04-26 15:27:10 +09:00
