afdddb0195
Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes
...
Fix timeline blueprint display not showing correct combo number / colour during placement
2023-05-20 15:02:55 +02:00
ee522253cb
Remove a couple of unnecessary volume declarations
2023-05-18 14:12:57 +09:00
b58ab28765
Make EditorClock non-nullable in PlacementBlueprint
2023-05-17 21:40:52 +09:00
0b25818bd2
Update combo information on placement blueprint
2023-05-17 17:26:19 +09:00
e43f2c2c43
Improve previous hitobject lookup efficient and correctness
2023-05-17 17:19:29 +09:00
7d7d402d4e
Apply NRT to PlacementBlueprint
2023-05-17 17:19:29 +09:00
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
0c1959ef2f
Allow commiting / undoing placement of blueprints using back / select bindings
2023-05-12 16:06:20 +09:00
f443cfb93e
Move blueprint validity conditions to allow more correct external usage of EndPlacement
...
Until now, these were haphazardly enforce inline in blueprint
implementations. The only thing stopping complete breakage is that
`EndPlacement` wasn't called (too much) from outside the blueprint,
leaving them responsible for their own placement.
By moving this conditional out of the provided paramters to
`EndPlacement`, it allows more flexible usage of that method externally.
Coming in a future PR.
2023-05-12 16:02:22 +09:00
2a94757154
Make sure the first object you place has bank and volume
2023-05-01 00:49:01 +02:00
83111223e0
fix null sample
2023-04-30 01:08:52 +02:00
ebe1d852f5
remove other usages of hitobject SampleControlPoint
2023-04-25 16:01:43 +02:00
191259c050
Use equals instead and update other usage
2023-02-04 19:58:48 -08:00
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
bd5037fcad
Fix new hitobject placements not taking on the existing sample settings
...
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.
Closes https://github.com/ppy/osu/issues/18742 .
2022-06-18 13:49:59 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
b339c149d8
Copy BaseDifficulty to Beatmap<T> and move all write operations across
2021-10-06 15:10:45 +09:00
a92d499d7a
Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
2021-10-01 16:55:50 +09:00
6c4709e7b4
Fix PlacementBlueprint using the wrong beatmap when applying defaults
...
Closes #12855 .
2021-05-19 18:34:07 +09:00
9a7bf8109f
Allow certain mouse input to pass through PlacementBlueprints to the selection logic
2021-04-22 15:44:12 +09:00
119c9b4294
Fix placement blueprints not being correctly removed after a rolled back placement
2021-04-16 14:11:33 +09:00
e9730d4782
Move default sample addition to inside PlacementBlueprint
...
This isn't actually required to fix the behaviour but it does feel like
a better place to put this logic.
2021-02-11 17:16:18 +09:00
3ad2eeaff5
Fix outdated xmldoc
2020-11-30 18:35:30 +09:00
9811c46e35
Rename application method to better describe what it actually does
2020-11-26 19:16:18 +09:00
e009264f10
Add new combo toggle to main composer interface
2020-09-25 14:10:30 +09:00
b2fad91589
Add swell and drumroll blueprints
2020-05-29 16:45:47 +09:00
0cc6d6d97c
Merge pull request #9033 from smoogipoo/applydefaults-cancellation
...
Add cancellation token support to CreateNestedHitObjects()
2020-05-26 12:04:06 +09:00
cd65fc860b
Remove extra default application
2020-05-25 16:15:55 +09:00
b44beb4137
Remove double resolution of EditorClock
2020-05-25 15:40:45 +09:00
ed83ef202a
Merge branch 'master' into editor-clock-cache
2020-05-25 15:39:42 +09:00
a3a9810344
Merge branch 'master' into editor-clock-cache
2020-05-23 00:44:04 +09:00
83f4ba107f
Fix defaults not being applied correctly to blueprints after StartTime is changed
2020-05-22 22:42:17 +09:00
3e0ee310d0
Remove now incorrect comment
2020-05-22 18:30:39 +09:00
dd09d7830d
Cache and resolve editor clock as EditorClock in all cases
2020-05-22 16:44:06 +09:00
776b842fdb
Remove unused using
2020-05-21 14:53:36 +09:00
a9a1c00cf1
Move responsibility placement blueprint's StartTime set to within
2020-05-21 14:50:33 +09:00
82d6549161
Pass down snap result and remove local TimeAt usage
2020-05-20 21:01:29 +09:00
970bd86d2e
Remove local TimeAt usage in mania placement
2020-05-20 21:01:29 +09:00
3354d48a38
Change snapping to be screen space coordinate based
2020-05-20 21:00:29 +09:00
98125102a7
Add cancellation token support to CreateNestedHitObjects()
2020-05-15 18:07:41 +09:00
f38b64d201
Fix placement blueprints handling double clicks
2020-04-13 13:57:15 +09:00
b65e839bd2
Simplify blueprints by removing visible state
2020-02-13 10:00:09 +09:00
0fe41fd50a
Fix blueprint showing even when mouse outside of container
2020-02-13 09:03:48 +09:00
e31d69c749
Add commit status to EndPlacement; call BeginPlacement on initial movement
2020-02-07 18:02:48 +09:00
79b2c7b480
Make BeginPlacement() set the hitobject start time
2019-10-16 20:04:15 +09:00
652acac87f
Move placement movement event to BlueprintContainer
2019-10-03 16:14:42 +09:00
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
0bd35ab7bb
Turn on warnings, resolve issues
2019-04-25 17:36:17 +09:00
c39c37a18d
Apply more missed cases
2019-04-01 12:44:46 +09:00
