57a38374db
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-04 21:17:40 +09:00
840f084dc4
Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds
...
Add storyboards as a main menu background source
2021-06-04 19:50:40 +09:00
2069a5bd28
Merge pull request #13313 from ekrctb/factor-out-hoc
...
Factor out entry management logic of `HitObjectContainer` to the new base class
2021-06-04 16:06:48 +09:00
b283c48abb
Merge branch 'master' into factor-out-hoc
2021-06-04 15:31:35 +09:00
19a44d65c5
Tidy up code
2021-06-04 15:18:16 +09:00
23096c58bb
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-04 15:06:15 +09:00
071c07586a
Increase music volume back to 80% for the time being
2021-06-04 15:00:53 +09:00
996c156106
apply suggestions
...
- apply 0 alpha to beatmap background if storyboard replaces it
- use an AudioContainer to mute all samples coming from the storyboard
2021-06-04 13:56:10 +08:00
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder
...
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
eebd5745a8
Move full stop out of link and reword slightly
2021-06-04 11:44:43 +09:00
233551fc08
Merge pull request #13323 from gagahpangeran/extract-sidebar
...
Create abstract class `OverlaySidebar`
2021-06-04 11:38:36 +09:00
50c60c791f
Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods
...
Add seed option for all random mods
2021-06-04 11:26:13 +09:00
905472a20b
make NewsSidebar extends OverlaySidebar
2021-06-04 00:12:29 +07:00
076e498a63
create abstract class OverlaySidebar
2021-06-04 00:12:13 +07:00
d444fed46f
Detach gameplay score from replay recorder before importing
...
Closes #13320 .
2021-06-04 02:00:02 +09:00
7a4fc9ffc8
Move seed to base class
2021-06-03 18:16:11 +02:00
c5fc155cc0
Change text wording
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-06-03 20:37:27 +07:00
490ce0bbc5
load placeholder page when failed
2021-06-03 19:40:54 +07:00
5f5f3a8c5c
General comment cleanups
2021-06-03 14:20:52 +02:00
b2cc2a51ec
Rename method to be less misleading
...
Would rather avoid variations of Equals/Equal/IsEqual. There's not
really much equality involved as the types are different.
2021-06-03 14:13:01 +02:00
e8c2483f19
Use standard list instead of bindable list
...
No reason to use a bindable list there, as `CollectionChanged` was never
subscribed to.
2021-06-03 14:09:52 +02:00
8193691cbc
Invert condition to reduce nesting
2021-06-03 14:09:52 +02:00
acb4873157
Merge branch 'master' into keyboard_shortcuts
2021-06-03 14:09:48 +02:00
33ab411e39
Merge branch 'master' into drawavatar-use-avatar-url
2021-06-03 19:36:32 +09:00
e887807ae7
Apply review fixes
2021-06-03 18:32:05 +09:00
be03a2d7d2
Fix multiple calls to seek method potentially not working
2021-06-03 17:47:22 +09:00
c3280083a2
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-03 17:42:01 +09:00
662bbed5d1
Fix seeking to gameplay too soon
2021-06-03 17:38:51 +09:00
15b43beef1
Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects
...
Refactor catch Movement skill to not require explicit clockrate usage
2021-06-03 17:29:27 +09:00
420df124b5
Add framestable-bypassing seek for spectator
2021-06-03 17:27:21 +09:00
69009a36b7
Merge branch 'master' into autoplay-pause-support
2021-06-03 16:37:41 +09:00
48687028a3
Merge branch 'test-platform-actions' into keyboard_shortcuts
2021-06-03 15:35:57 +09:00
be91203c92
Add nested PlatformActionContainer to allow testing of platform actions in visual tests
2021-06-03 15:35:32 +09:00
f51413ead9
Refactor to pass clockrate in constructor rather than deriving from mods
2021-06-03 16:09:42 +10:00
e74fe68c96
Use new platform actions instead of hardcoded keys
2021-06-03 15:04:07 +09:00
b321b20e9d
Remove OnAdd/OnRemove of HitObjectContainer
...
Instead, override `AddDrawable`/`RemoveDrawable`.
2021-06-03 15:00:16 +09:00
0ce7baa3f3
Make HitObjectContainer.Clear non-virtual
...
It just call `Remove` for all entries.
2021-06-03 15:00:16 +09:00
2c9e5b6c7e
Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property
...
It can be used for dynamically added entries.
2021-06-03 15:00:16 +09:00
fe2934db1d
Factor out lifetime management logic of HitObjectContainer
2021-06-03 14:57:28 +09:00
a91015302e
Replace second usage of new function
2021-06-03 14:56:29 +09:00
a6cc37eb3b
Mark fields readonly
2021-06-03 14:56:21 +09:00
d7d0dde5d2
use created storyboard to check for drawables instead
2021-06-03 13:56:14 +08:00
4a5d8215f3
Merge branch 'master' into keyboard_shortcuts
2021-06-03 14:47:40 +09:00
62b07fb9ce
apply suggestions
...
- Replace the sprite with a solid black box when a storyboard requests it.
- Create a new storyboard instance and exclude the fail layer as well as strip all samples from it
- Do not attempt in creating the storyboard when it isn't needed
2021-06-03 13:27:00 +08:00
d00fb21188
prevent scaling container from creating a storyboard background
2021-06-03 13:24:21 +08:00
44b1102241
Merge branch 'master' into autoplay-pause-support
2021-06-03 13:26:00 +09:00
a62dd7cca0
Revert "refactor BeatmapBackgroundWithStoryboard to reduce overhead"
...
This reverts commit 277545bb06
2021-06-03 12:33:16 +09:00
d6656047e3
Fix beatmap statistics with value of zero not displaying correctly at song select
...
Closes #13307 .
2021-06-03 01:58:51 +09:00
277545bb06
refactor BeatmapBackgroundWithStoryboard to reduce overhead
...
This avoids loading the sprite if its not needed and instead of hiding it, it is removed when the storyboard replaces the background or there is a video.
This also only initializes DrawableStoryboard if there are any elements in any layer.
2021-06-02 20:27:12 +08:00
cde8de154d
Remove unused test property for now
2021-06-02 19:11:09 +09:00
