58cca9da06
Revert "Expose the skin lookup layers of SkinManager to a property"
...
This reverts commit 9e652715ce
2021-06-10 11:57:28 +03:00
530026b675
Add simple xmldoc to ctors explaining their deal with SkinSources
2021-06-10 11:56:13 +03:00
18edbdd135
Remove mentioning of "layer" in skin providers
...
`SkinSources` sounds better.
2021-06-10 11:55:26 +03:00
1aaad7bfd4
Apply few adjustments to skinning overlays comment
2021-06-09 22:49:31 +03:00
e30f6581b3
Wrap gameplay content within a RulesetSkinProvidingContainer
2021-06-09 22:49:31 +03:00
33a9cac398
Add special RulesetSkinProvidingContainer managing ruleset-compatible skin setup
2021-06-09 22:49:31 +03:00
9e652715ce
Expose the skin lookup layers of SkinManager to a property
2021-06-09 22:49:31 +03:00
6538d44708
Make SkinProvidingContainer able to perform lookup on multiple skins
...
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
89cdea8123
Merge branch 'master' into fix-results-exit-transition
2021-06-09 19:40:56 +02:00
222ae40a04
Merge branch 'master' into update-framework
2021-06-09 17:36:17 +02:00
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
f113c095ce
Update framework
2021-06-09 20:29:06 +09:00
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
a65b76bdbf
Add a simple fade to the results screen
...
Stops it from immediately disappearing.
2021-06-09 17:19:37 +09:00
7b0c5e9d32
Fix results screen changing applied colour to background on exit
...
The general rule is that screens should only apply colours and the likes
on enter / resume, and leave the outwards transition to whatever screen
is coming next.
2021-06-09 17:18:55 +09:00
258d05d1e0
Ensure PlayerLoader restores the background colour to its own value on resume
2021-06-09 17:17:39 +09:00
a7ef0173e9
Add safety to ensure background is correct tint when entering gameplay
2021-06-09 17:07:28 +09:00
023015f9a6
Merge branch 'master' into fix-skin-background-regression
2021-06-09 08:09:21 +02:00
a801a9a14d
Ensure background rotation on default skins
2021-06-09 07:59:47 +02:00
b8df3fff9e
Fix incorrect method referenced in xmldco
...
Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com >
2021-06-09 14:20:01 +09:00
62199a38a8
Add one missing obsoletion removal date
2021-06-09 14:11:50 +09:00
f41e34ae2c
Remove more obsoleted members
2021-06-09 14:10:48 +09:00
a87226ab10
Remove obsoleted DrawableJudgement methods
...
Undated, but change was made on 2020-11-18.
2021-06-09 14:09:23 +09:00
97204b6f27
Reduce unnecessary background changes via IEquatable implementation
2021-06-08 22:37:18 +02:00
a98c302211
Bring back skin background source
2021-06-08 22:04:59 +02:00
5bf4dd6358
Move skin background to separate file
2021-06-08 21:57:08 +02:00
00efed2c39
Add colours for tick judgements
2021-06-08 23:10:21 +09:00
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
c3ea1b26e1
Fix DT being doubled in multiplayer spectator
2021-06-08 22:51:42 +09:00
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
...
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
5a8cde7e6f
Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic
...
Move legacy `ScoreInfo` to be completely based on presence of classic mod
2021-06-08 19:15:13 +09:00
0b9916b266
Add parens to declare operator precedence
2021-06-08 18:39:52 +09:00
4ee7721c51
Extract first version out to constant
2021-06-08 18:38:47 +09:00
d31e3e8f1c
Fix nullref
2021-06-08 18:23:03 +09:00
b287366c8b
Remove forgotten classic mod addition
2021-06-08 18:09:57 +09:00
061e3d7f26
Move legacy ScoreInfo to be completely based on presence of classic mod
2021-06-08 18:00:09 +09:00
4d9fffc01b
Update score encoder version to be higher than any existing stable version
2021-06-08 17:59:43 +09:00
ab9290772b
Fix a similar case with online play sub-screens
2021-06-08 17:54:54 +09:00
860f1aebb3
Only call OnBackButton() if the screen has finished loading
2021-06-08 17:38:12 +09:00
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
e5e3509c87
Merge pull request #13264 from peppy/legacy-skin-default-fallback
...
Allow fallback to legacy defaults from legacy skins
2021-06-08 17:30:27 +09:00
c0fdbfba04
Merge pull request #13374 from peppy/update-framework
...
Update framework
2021-06-08 17:09:20 +09:00
7fa0ac6ed7
Fix possible nullref when exiting song select too fast
2021-06-08 17:03:50 +09:00
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
e3cb6f45f5
Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change
...
Clean up previous sample immediately on skin source change to avoid `Play` after disposal
2021-06-08 16:52:59 +09:00
89895f6ce4
Update framework
2021-06-08 16:24:00 +09:00
67135ce3db
Add null check
2021-06-08 16:15:17 +09:00
e0f568aa8f
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-08 15:19:52 +09:00
f3f634e969
Clean up previous sample immediately on skin source change to avoid Play after disposal
...
This seems to be the simplest way to avoid calls to `Play` after the
underlying sample may have been disposed. As per the issue thread, a
local workaround is acceptable here.
Closes #13223 .
2021-06-08 15:05:18 +09:00
