Commit Graph

40663 Commits

Author SHA1 Message Date
5885c24e00 Clear current user states on disconnect 2021-04-19 16:00:56 +09:00
25c7dc9ef0 Revert unnecessary change 2021-04-19 15:30:11 +09:00
ef3801b5dd Add helper method supporting RomanisableString 2021-04-19 15:29:26 +09:00
abfa6aec87 Remove completionState parameter 2021-04-19 01:58:19 -04:00
be5abea7ca Merge pull request #12446 from jvyden/master
Reset SessionStatics on inactivity
2021-04-19 14:44:39 +09:00
f4baff9e04 Make TimingScreen use rounded screen and adjust spacing/padding 2021-04-19 14:35:35 +09:00
e143afb598 Split out rounded content screen from SetupScreen for use in other places 2021-04-19 14:28:32 +09:00
0b36dd9bce Skip outro overlay and PerformExit() call updateCompletionState() instead of scheduleCompletion()
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-19 01:23:21 -04:00
ffc1e841e0 Fix sessionIdleTracker not being properly added to OsuGame 2021-04-19 01:06:26 -04:00
513e470b52 Adjust grid spacing to allow attributes to use more width 2021-04-19 13:24:53 +09:00
0c918410d0 Make "add" button more visible 2021-04-19 13:15:24 +09:00
658c23c925 Give more space to the parameter adjustment area 2021-04-19 13:15:17 +09:00
a854ce429a add blank line between method 2021-04-18 23:49:13 -04:00
f9f514ffec Add basic xmldoc to show how the two colour classes interact 2021-04-19 12:37:56 +09:00
999f2d810c Fix accidentally removed code 2021-04-18 23:30:07 -04:00
fd1241cc85 Added tests
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion

Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
99fab456b5 Storyboard completion calls updateCompletionState
- If the storyboard ends after the beatmap, call updateCompletionState as if the score processor has completed at that time. (completionProgressDelegate is null here since earlier when the score processor actually completed, updateCompletionState returned after showing the skip overlay.)

- If the storyboard ends before the beatmap does, updateCompletionState simply returns and waits until the score processor is completed.

- If the storyboard and beatmap end at the exact same time, make sure updateCompletionState() is called only once by the score processor completion.

Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:25:20 -04:00
e44d11667c Merge remote-tracking branch 'upstream' 2021-04-18 23:04:35 -04:00
c39ab2c692 Add SessionStaticsTest 2021-04-18 23:04:28 -04:00
b727faace3 Revert changes to IdleTracker 2021-04-18 23:03:43 -04:00
f74904f0aa Merge pull request #12481 from Joehuu/fix-download-button-check-scaling
Fix download button check icon not scaling on mouse down
2021-04-19 11:49:39 +09:00
dbb8f7f4a9 Tidy up initialisation code and avoid using DI on inherited class 2021-04-19 11:30:55 +09:00
2b6caf9b65 Fix duplicate code in setting default logic 2021-04-19 11:25:43 +09:00
89940e7bb9 Fix download button check icon not scaling on mouse down 2021-04-18 19:05:33 -07:00
98460c8feb Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field 2021-04-18 20:20:14 -04:00
6f2ebb20a7 Fix test failing due to null beatmap skin
Also annotate the field on `EditorBeatmap` as nullable for future
travelers.
2021-04-18 20:46:42 +02:00
07a00cd681 Add colours section with combo colour display 2021-04-18 20:46:42 +02:00
577755ee19 Add placeholder when no colours are visible
Will be removed once combo colours are mutable.
2021-04-18 20:46:42 +02:00
0cd1aa8c1c Add support for custom colour prefixes 2021-04-18 20:44:55 +02:00
a8027d87b6 Fix unreadable colour hex code text due to low contrast
Logic is shared with the timeline blueprints which also have the same
problem of displaying text on top of a combo colour.

Slightly modified the formula. Seems to yield better results on a
subjective check.
2021-04-18 20:44:55 +02:00
67c19df000 Add test coverage for adding/removing colours 2021-04-18 19:35:42 +02:00
1b2c43b92c Add basic structure of colour palette 2021-04-18 19:29:04 +02:00
0988af5449 Merge pull request #12476 from peppy/fix-volume-sideways-scroll 2021-04-18 18:34:43 +02:00
91b3a7ccf9 Merge branch 'master' into fix-volume-sideways-scroll 2021-04-18 17:52:40 +02:00
1a2679df4c Merge pull request #12473 from peppy/fix-selection-after-paste 2021-04-18 17:40:52 +02:00
af79ad537c Avoid unnecessary debounce triggers on zero-delta scrolls 2021-04-19 00:05:44 +09:00
e63edf5b49 Fix volume control displaying on non-vertical scroll events
Closes #12475.
2021-04-19 00:05:44 +09:00
488001d570 Support SpriteText for LinkFlowContainer 2021-04-18 20:58:08 +08:00
38a7c590c4 Make versionString private 2021-04-18 20:57:25 +08:00
cfc7664094 Use full path 2021-04-18 21:05:23 +09:00
e76565dbc5 Fix selection box not displaying after pasting a selection in the editor
Closes #12471.
2021-04-18 20:28:39 +09:00
2678089e0b Add test case failing on selection after paste 2021-04-18 20:28:39 +09:00
f45aed1259 Remove new line between skip overlay fields 2021-04-18 07:25:52 +03:00
f6a09be62d Add further xmldoc 2021-04-18 07:25:49 +03:00
a73bae7a66 Schedule completion when storyboard has actually ended 2021-04-18 07:25:33 +03:00
2847dd7e05 Merge branch 'master' into play-storyboard-outro 2021-04-18 06:40:22 +03:00
646403b826 Fix CI errors 2021-04-18 10:54:42 +08:00
7b1d40db7d Remove redundant string interpolation 2021-04-17 22:13:28 -04:00
1339c126a4 Remove unused using 2021-04-18 09:54:50 +08:00
cfaaf2e83e Add ToRomanisableString() 2021-04-18 09:52:25 +08:00