36a20ab0b3
Resolve failed test compilation
2021-09-20 10:26:07 -04:00
10fe2382b0
Address most issues
2021-09-20 10:07:42 -04:00
4e094b2127
Implement grid size toggling matching stable
2021-09-19 20:26:02 +02:00
56e80a0706
Add rectangular position snap grid
2021-09-19 18:07:19 +02:00
04715a5471
Add null-check when invoking OnSeek
2021-09-18 12:20:36 -04:00
f6e279baa1
Add xmldoc to HitErrorMeter.Clear
...
Explains how the method is called and what inheritors should do when implementing it.
2021-09-18 12:18:11 -04:00
12cc16c598
Remove unused property in SongProgress
2021-09-18 12:05:06 -04:00
b2b3108afa
Resolve addressed issues
...
+ Stopped using testing methods in non-testing classes
+ Resolve Player and add OnSeek event
+ Take bindings away from BarHitErrorMeter
+ Add support for ColourHitErrorMeter
2021-09-17 16:19:41 -04:00
f868feae44
Remove unnecessary Schedule
2021-09-17 21:12:39 +09:00
9485323a13
Add audio feedback for incorrect MP room password
2021-09-17 20:52:13 +09:00
a591fffdbd
Merge pull request #14782 from peppy/refocus-textbox-on-failed-password
...
Refocus the multiplayer password entry textbox on failed join
2021-09-17 18:59:09 +09:00
027912d4f6
Refocus the multiplayer password entry textbox on failed join
2021-09-17 18:25:25 +09:00
1c8e17cf11
Fix the default background parallax being set incorrectly when no screen is present
2021-09-17 18:14:39 +09:00
5f27f1c099
Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
...
Bit of an unfortunate one. Because we are applying the pitch adjustment
to the lowest level (`Track`), it's hard to filter out in parent clock
calculations.
Tried a few solutions but this feels the best. Note that we can't just
undo the `pauseFreqAdjust` adjustment as it will div-by-zero.
Closes https://github.com/ppy/osu/issues/14773 .
2021-09-17 15:43:38 +09:00
f524e913e1
Move AllowTrackAdjustments specification to RoomSubScreen
2021-09-17 13:24:01 +09:00
cd4ba71a6b
Revert "Merge pull request #14772 from Joehuu/lounge-disallow-track-adj"
...
This reverts commit 06ff4838fb5453ea0ce9
2021-09-17 13:22:39 +09:00
55feb47e61
Disallow track adjustments on playlists / multi lounge
2021-09-16 20:17:21 -07:00
e8dea0138c
Fix one more issue
2021-09-16 18:34:13 +09:00
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
3495fae519
Handle potential for OnResuming call without an OnSuspending first
2021-09-16 16:31:41 +09:00
b58415fe19
Make suspend stored state nullable to ensure we don't break it
2021-09-16 16:12:14 +09:00
fa693bb8a8
Move MusicController adjustment set to inside OsuScreen itself (and result nullable)
2021-09-16 16:08:09 +09:00
318f0941ca
Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen
2021-09-15 21:25:39 +03:00
931e873a7e
Merge branch 'master' into inheritable-allow-track-adjust
2021-09-15 22:26:13 +09:00
f0439ef50b
Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect
2021-09-15 13:12:57 +03:00
8acfefed1b
Merge pull request #14741 from smoogipoo/fix-lounge-beatmaps-counter
...
Fix incorrect beatmap count and SR range in multi lounge
2021-09-15 18:51:52 +09:00
1181317c72
Fix issues found by code quality ci
2021-09-15 12:01:56 +03:00
f54d554d30
Extract removal to method
2021-09-15 17:03:28 +09:00
48cf98ef93
Rephrase null meaning in IOsuScreen.AllowTrackAdjustments
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-09-15 11:00:49 +03:00
b87af3dd68
Move the inherited AllowTrackAdjustments into OsuScreen
2021-09-15 10:55:16 +03:00
1ba716d9f1
Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state
...
Preserve current time and clipboard contents when switching between difficulties
2021-09-15 12:38:56 +09:00
7b9e501fa0
Merge branch 'master' into 14421-multi-password-error-handling
2021-09-14 22:58:20 +02:00
b9193aae6d
Make IOsuScreen.AllowTrackAdjustments nullable
...
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
57f8ccca16
Remove nullability from EditorState properties
...
Also update the xmldoc to not be specific to difficulty switching
2021-09-14 23:36:28 +09:00
f8bdca542d
Make restoring state a public call on Editor
2021-09-14 23:36:17 +09:00
2a894e7a3f
Make EditorLoader state private
2021-09-14 23:26:02 +09:00
a775915338
Fix incorrect beatmap count and SR range in multi lounge
2021-09-14 18:20:28 +09:00
5058f28504
Remove breaking padding
2021-09-14 14:52:50 +09:00
8865e3cab8
Add back shake and tweak transform of text
2021-09-14 14:44:32 +09:00
7bd749d0eb
Remove weird shaking
2021-09-14 14:19:55 +09:00
e3c56f9ebd
Show error message in popover
2021-09-14 14:14:06 +09:00
eaac2bad3d
Fix incorrect child margin specifications
2021-09-14 13:49:02 +09:00
35ee889e5b
Restore clipboard content after difficulty switch
2021-09-13 21:04:27 +02:00
79d0f4835e
Add failing tests for preserving clipboard content
2021-09-13 21:03:30 +02:00
3fc72271f1
Restore editor clock time after difficulty switch
2021-09-13 20:59:31 +02:00
3c75094f43
Move BarHitErrorMeter's icon reorintation to Update()
2021-09-13 19:41:55 +03:00
7267602b95
Fix icon orientation for horizontal bar hit error meter
2021-09-13 17:14:39 +03:00
f6c4bbe2c9
Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults
...
Add missing screen level mod application settings for some screens
2021-09-13 15:22:22 +09:00
f9c82a9098
Merge pull request #14676 from nekodex/lobby-team-swap
...
Add sound for multiplayer team swaps
2021-09-13 15:01:58 +09:00
caf7ef6519
Add missing screen level mod application settings for some screens
...
Closes #7480 . But based on discussion in there this solution may change.
2021-09-13 15:00:34 +09:00
