Commit Graph

5884 Commits

Author SHA1 Message Date
f6b1405fa0 Merge branch 'master' into fix-listing-terminal-breakage 2022-01-04 11:49:02 +09:00
7cdba2f7c3 Add test coverage of score submission if player is exited during import 2022-01-03 22:00:47 +01:00
2660f41339 Add failing test case for old cards not expiring correctly 2022-01-03 19:28:14 +01:00
04d8fd3a58 Improve reliability of TestStoryboardSkipOutro
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
f53a675ca3 Fix TestSceneMultiSpectatorLeaderboard not waiting for user population 2021-12-31 00:48:31 +09:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
ef763e9bd7 Add failing test for storyboard not tracking current track 2021-12-27 12:28:49 +01:00
34b0101ff4 Add visual test coverage of "hidden by ruleset" combo option 2021-12-26 16:49:18 +01:00
8ad53138a6 Merge pull request #16234 from smoogipoo/fix-initial-button-colour
Fix OsuAnimatedButton animating when initially disabled
2021-12-25 15:34:40 +09:00
2ee3e61983 Merge branch 'master' into beatmap-card/extra-on-listing 2021-12-24 19:02:51 +09:00
c973739b08 Fix OsuButton event binding + inital-enablement colour 2021-12-24 11:56:12 +09:00
03d159d723 Refactor OsuAnimatedButton test scene 2021-12-24 11:56:12 +09:00
5cbaa028eb Use extracted ruleset config cache implementation in DI 2021-12-23 19:02:10 +01:00
27c5cc5bd8 Add testing for beatmap card size switching 2021-12-23 15:55:51 +01:00
1876617d8e Implement beatmap card size tab control 2021-12-23 15:55:36 +01:00
d31c9db08b Adjust testing methodology to improve reliability of mosue wheel volume adjust tests
There was previously a potential in headless runs for timing
discrepancies to cause the volume to never get adjusted.

As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.
2021-12-23 13:25:24 +09:00
e1b539fa9e Merge pull request #16213 from peppy/working-beatmap-live
Tidy up `WorkingBeatmap`
2021-12-23 13:02:37 +09:00
02fa1c21b7 Adjust existing placeholder test to demonstrate failure case 2021-12-22 15:03:20 +01:00
f3f491374b Remove unused load checks 2021-12-22 18:17:00 +09:00
967419c9ac Remove BeatmapSetInfo and Metadata from interface
There were very few accesses to this, and after realm they should all be
done via the `BeatmapInfo`, so let's remove this.
2021-12-22 18:17:00 +09:00
cfdfe81afb Merge pull request #16205 from smoogipoo/fix-multiplayer-tests
Fix multiplayer test failures when checking for parted room
2021-12-22 13:42:05 +09:00
a88800c99a Merge pull request #16198 from smoogipoo/fix-current-item-before-population
Fix delete button showing on current item before beatmap retrieval
2021-12-22 13:15:07 +09:00
24c6f8fafa Fix multiplayer test failures when checking for parted room 2021-12-22 12:55:37 +09:00
ee64ab6383 Fix delete button test failures
Can be tested by adding a Thread.Sleep() in
DrawableRoomPlaylistItem.load().
2021-12-22 09:55:19 +09:00
0bda7892f7 Merge pull request #16197 from bdach/beatmap-card/renames
Rename beatmap card-related classes
2021-12-21 18:51:34 +09:00
e2f8c71081 Fix test 2021-12-21 18:38:31 +09:00
a53c67b2ea Merge pull request #16194 from peppy/fix-results-screen-wait-test
Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step
2021-12-21 16:56:49 +09:00
88d4e95ad8 Rename BeatmapCard{ => Normal} 2021-12-21 08:26:21 +01:00
2707b2fbda Merge pull request #16012 from bdach/beatmap-card/extra
Implement "extra" beatmap card size
2021-12-21 15:40:33 +09:00
c0a8758839 Fix intermittent test failures on TestSceneResultsScreen due to long delay step
Using real time delays of 3 seconds doesn't play well with headless runs.
2021-12-21 15:15:05 +09:00
a8cd96278d Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure
Fix intermittent failures on `TestSceneBeatmapListingOverlay`
2021-12-21 15:11:25 +09:00
0f8a6a3f64 Fix intermittent failures on TestSceneBeatmapListingOverlay
In the specific method, there was no wait step after the initial fetch
(unlike all of the rest), meaning the fetch may not have finished in
time for the follow-up steps.

As seen at
https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.
2021-12-21 14:12:06 +09:00
bb3f375958 Add note about local button clicking usage 2021-12-21 13:49:51 +09:00
aad55ef89e Remove unused method in TestSceneMultiplayerQueueList 2021-12-21 13:49:51 +09:00
9aff646ff4 Centralise all multiplayer button clicking test logic
This adds the "wait for enabled" check in a way that can be easily
reused, as it keeps getting missed in test implementations.

This particular commit hopefully fixes
https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.
2021-12-21 13:49:51 +09:00
f1a03aced5 Merge branch 'master' into beatmap-card/extra 2021-12-20 15:49:00 +01:00
0b7daf542f Merge branch 'master' into fix-song-select-test-failure 2021-12-20 11:36:49 +01:00
f492cf84d9 Ensure presence of at least 1 difficulty for each ruleset 2021-12-20 11:34:39 +01:00
d8be455a43 Merge branch 'master' into fix-ready-button-test 2021-12-20 11:02:43 +01:00
ec0a6735eb Rename TestMultiplayerScreenStack to TestMultiplayerComponents 2021-12-20 18:24:59 +09:00
6907a9a3cc Name some screen stacks for better logging context 2021-12-20 18:24:14 +09:00
87051d5d61 Add better defined steps to TestLoseHostWhileReady ready button test
Not 100% sure this will solve the issue but it's worth a try. The button
state checks are using `Until` everywhere else so this brings the test
in line with the standards.

As seen
https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.
2021-12-20 17:47:06 +09:00
5c8e317a6e Chooser earlier items in song select tests to avoid potentially not having enough 2021-12-20 17:11:15 +09:00
af78a3e99d Fix weird loop logic 2021-12-20 17:09:08 +09:00
d79602a912 Add wait step to TestScenePlaylistResultScreen explicitly for screen load 2021-12-20 16:58:36 +09:00
2e47c4e25d Merge pull request #16164 from smoogipoo/fix-intermittent-background-test
Fix intermittent background screen test failures
2021-12-20 14:00:53 +09:00
9316abc278 Better fix for intermittent multiplayer tests 2021-12-20 13:10:13 +09:00
11f3ec0cb5 Wait for previous screen to be hidden in test 2021-12-20 12:44:23 +09:00
097402677d Add test for ranked/unranked user display 2021-12-19 13:40:22 +01:00