1bff4373b3
Allow specifying flipping support of selection box different from scaling
2021-07-21 15:59:45 +09:00
747c475b95
Merge pull request #13932 from peppy/fix-multiple-request-completion-states
...
Fix API request potentially firing failed events after completion
2021-07-21 15:11:03 +09:00
59dd3452fe
Merge pull request #13954 from bdach/user-profile-beatmap-api-adjustments
...
Adjust user beatmap section naming on profile overlay to match web
2021-07-21 08:21:10 +09:00
db9cf443c7
Allow confirming room password by pressing Enter
2021-07-21 00:04:51 +02:00
1e634d9db0
Adjust user beatmap sections on profile overlay to match web
2021-07-20 21:55:17 +02:00
738d321788
Merge pull request #13946 from peppy/fix-online-play-sub-screens-not-async-loaded
...
Fix `OnlinePlayScreen` sub-screens not loaded asynchronously
2021-07-20 19:51:13 +09:00
d066ebcd70
Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval
...
Refactor combo colours retrieval to use skin config lookups instead
2021-07-20 19:47:57 +09:00
15127f972e
Merge branch 'master' into fix-online-play-sub-screens-not-async-loaded
2021-07-20 18:47:41 +09:00
d87ea741ed
Fix OnlinePlayScreen sub-screens not loaded asynchronously
2021-07-20 16:38:39 +09:00
1af230c48c
Merge branch 'master' into refactor-combo-colour-retrieval
2021-07-20 10:08:25 +03:00
fe414b942f
Ensure online play subscreen is loaded before forwarding OnExiting
...
Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
framework issue; the framework correctly guards against this scenario,
see
4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)
2021-07-20 15:51:34 +09:00
6cc81c24b4
Merge pull request #13785 from ekrctb/dependency-providing-container
...
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
9ea1f5900a
Don't consider version suffixes when checking for updates
...
This is just to make life easier for me with deploys for now.
2021-07-20 01:05:37 +09:00
e77597c2b6
Merge pull request #13921 from Game4all/localise-profile-overlay
...
Localise user profile overlay
2021-07-20 00:37:01 +09:00
844152e1b1
Merge pull request #13861 from peppy/add-password-support
...
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
6e104fe084
Merge pull request #13894 from peppy/fix-beat-synced-container-alt
...
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
6a55cb9df0
Revert unintended change
...
It's a deeper issue with ScreenStack (see:
https://github.com/ppy/osu-framework/issues/4619 ).
2021-07-19 22:52:07 +09:00
57a99886d5
Fix password icon not disappearing when no password
2021-07-19 22:31:01 +09:00
892d858d5f
Fix compile error
2021-07-19 22:23:31 +09:00
b7c2d6b1ab
Merge branch 'master' into add-password-support
2021-07-19 22:23:09 +09:00
5ef1fe6948
Merge branch 'master' into fix-replay-date
2021-07-19 21:58:37 +09:00
f3bcaf7f11
Merge pull request #13929 from peppy/i-deep-cloneable
...
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
0a43e54dfc
Fix request failing due to parameters
2021-07-19 21:24:22 +09:00
a001e4aa16
Fix web request failing if password is null
2021-07-19 20:57:16 +09:00
3168a927dc
Fix possible exception
2021-07-19 20:50:30 +09:00
80c2b1449b
Fix API request potentially firing failed events after completion
...
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.
This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.
Closes https://github.com/ppy/osu/issues/13632 .
2021-07-19 20:27:01 +09:00
2eec524f27
Fix password not copied from multiplayer client
2021-07-19 20:20:08 +09:00
d6aa15e5d7
Remove local APIRoom from test multiplayer client
2021-07-19 20:19:23 +09:00
a5a0f12e19
Also copy password in test room manager
2021-07-19 20:07:56 +09:00
26d0eea485
Set HasPassword correctly in the response room
2021-07-19 20:03:32 +09:00
2515785f93
Use room password to fill settings textbox
2021-07-19 20:03:32 +09:00
8c0daa89a0
Make test multiplayer client validate password
2021-07-19 20:03:27 +09:00
063f14da98
Update test room manager to not return passwords
2021-07-19 20:03:27 +09:00
b3f60c8253
Fix date being updated on replays unexpectedly
2021-07-19 19:28:35 +09:00
f16b4957aa
Move clone to earlier in the process
2021-07-19 19:18:34 +09:00
23ef666f34
Merge pull request #13887 from ekrctb/legacy-converted-y
...
Preserve Y position of hit objects in osu!catch
2021-07-19 18:48:23 +09:00
f1f6af88a1
Merge pull request #13926 from peppy/set-rank-on-failed-submission
...
Set score's rank on a failed submission
2021-07-19 18:45:21 +09:00
473011070f
Merge pull request #13908 from peppy/editor-disallow-placement-when-untimed
...
Fix editor composer allowing object placement without timing present
2021-07-19 18:37:19 +09:00
13cb658d29
Mark identifiers as verbatim strings
2021-07-19 18:15:09 +09:00
80539fefe1
Merge branch 'master' into localise-profile-overlay
2021-07-19 18:14:59 +09:00
b29209d13f
Ensure tool is always set back to select tool when beatmap becomes untimed
2021-07-19 17:08:40 +09:00
bde35d9f21
Rename radio button classes to be local to editor
2021-07-19 16:57:12 +09:00
87c39909c6
Simplify DependencyProvidingContainer
...
Using an array of tuple for dependencies instead of using children.
2021-07-19 14:37:19 +09:00
caba78cb5d
Copy score during submission process to ensure it isn't modified
2021-07-19 14:14:28 +09:00
e507faef29
Add deep cloning support to Score/ScoreInfo/Replay
2021-07-19 14:14:28 +09:00
3c028ce05c
Add IDeepCloneable interface and update existing CreateCopy methods to use it
2021-07-19 12:54:17 +09:00
d7f997a7f3
Set score's rank on a failed submission
...
As we don't have a `RankInfo.F`, this is the next best choice. I am also
adding a check osu-web side for this - this is just to make sure we
aren't sending scores with SS when they are not actually completed.
I'm working on a separate PR to ensure this does not get mutated during
the player exit process.
2021-07-19 12:36:15 +09:00
fb5d25405e
Replace calls to obsoleted GetOrDefault() extension
2021-07-18 21:52:16 +02:00
80885301a3
Fix codefactor issues.
2021-07-18 19:36:34 +02:00
9257cd7fad
Revert the use of an enum in ProfileHeader.
2021-07-18 19:18:06 +02:00
