Commit Graph

113 Commits

Author SHA1 Message Date
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
fde7c88999 Merge branch 'master' into update-framework 2021-09-16 22:49:02 +09:00
d8f27633a4 Fix legacy approach circles accepting alpha 2021-09-16 19:35:15 +09:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
68e28f4903 Implement IHasApproachCircle in DrawableHitCircle as well 2021-06-21 07:35:07 +03:00
a46f730a69 Fix approach circle fade not running early on an early user hit
Regressed in https://github.com/ppy/osu/pull/12153.
Closes https://github.com/ppy/osu/issues/13531.
2021-06-17 15:09:05 +09:00
b82190e157 Fix hit circle animation reset when skin is changed
The transforms applied in `Animate` call was not applied because the piece is recreated.
2021-06-02 11:32:24 +09:00
aa7ade8186 Expose presence of MainCirclePiece via an interface 2021-04-26 15:22:17 +09:00
47a4a07024 Split out animation triggering of MainCirclePiece to be interface driven 2021-04-21 19:15:10 +09:00
ac0ed72d04 Keep hitcircles aligned with view in "Barrel Roll" mod 2021-04-20 18:36:11 +09:00
64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
03b7817887 Add flags to return to classic slider scoring 2021-02-03 22:12:20 +09:00
245be2c5ed Adjust namespace 2020-12-04 20:21:53 +09:00
c506b438bf Remove more code and make some methods private 2020-11-22 18:51:16 +09:00
04805b78c3 Tighten osu! ruleset lifetime expiry for past hitobjects 2020-11-17 23:20:19 +09:00
bf72961959 Add top-level osu! hitobject pooling 2020-11-12 15:39:02 +09:00
e190afbfed Remove initial value changed invocations 2020-11-07 00:00:25 +09:00
33b629a87a Make top-level osu! objects use new methods 2020-11-06 23:09:23 +09:00
0cadb31947 Merge branch 'master' into drawable-hit-object-hit-state-fix 2020-11-05 17:07:52 +09:00
9a7fcadabc Use BDL for top-level osu! DHOs 2020-11-05 13:51:46 +09:00
a3dc1d5730 Update existing implementations 2020-11-04 17:14:23 +09:00
1f0620ffd4 Replace assignment references to HitResult.Miss with Judgement.MinResult 2020-10-02 23:31:24 +02:00
2b1ef16f89 Replace comparison references to HitResult.Miss with IsHit 2020-10-02 23:31:24 +02:00
2771c95bec Merge remote-tracking branch 'upstream/master' into expand-number-piece-on-old-skins 2020-08-04 22:17:54 +03:00
eab00ec9d9 Move hit events to the ScoreProcessor 2020-06-19 19:58:35 +09:00
900da88498 Populate hit offsets from score processor 2020-06-15 22:44:55 +09:00
10e849d196 Separate into separate class 2020-04-10 02:02:09 +09:00
a2f5a469cf Merge branch 'master' into add-notelock 2020-04-10 01:18:54 +09:00
fb4b334ce2 Add support for legacy skin sliderstartcircle / sliderstartcircleoverlay 2020-03-28 14:10:26 +09:00
742698acab Add notelock implementation 2020-03-10 15:30:24 +09:00
77fd748035 Fix incorrect circle piece hitbox
Hitboxes of circle pieces in osu! have regressed with commit 8592335.
The reason for the regression was that hit detection was moved from
DrawableHitCircle itself to a newly-introduced private HitArea class
(now named HitReceptor).

As HitArea inherited from Drawable, it would return IsHovered == true
over its entire bounding box. This meant that the hit area could wrongly
pick up actions that are not within circle radius and make them into
hits.

To resolve, make HitReceptor a CompositeDrawable and set its corner
radius to match the circle piece. This fixes the invalid hitbox, as
IsHovered takes radius into account.
2020-03-06 21:21:20 +01:00
900882610d Merge branch 'master' into expand-number-piece-on-old-skins 2020-03-02 16:40:59 +09:00
434c0d92e4 Use Bindable{Float,Double}s everywhere
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
990f94dc34 Merge branch 'master' into expand-number-piece-on-old-skins 2019-12-05 01:42:13 +09:00
c34d3362df Fix hit circles selection area being too large 2019-10-21 17:14:08 +09:00
023c4d64d8 Remove redundant using directive 2019-10-03 06:00:22 +03:00
957bbee3e4 Scale pieces individually and use skin source directly 2019-10-03 05:58:20 +03:00
ef8f9aa276 Fix possible nullref exception 2019-10-01 08:43:03 +03:00
9e314cd664 Add expand number piece bindable to hit circle 2019-10-01 08:15:48 +03:00
3155a90501 Use bindables for displayed circle piece numbers 2019-09-26 16:58:20 +09:00
cfdac956c2 Fix issues with colour and skin application 2019-09-18 20:04:49 +09:00
5c2c055614 Set lifetime on initial state update 2019-09-13 18:49:21 +09:00
f21e47d6d2 Move expire to DrawableHitObject 2019-09-12 19:29:08 +09:00
f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
8302658186 Fix other potential nullref cases that rider missed 2019-09-02 18:31:33 +09:00
a15828ab25 Introduce the concept of SkinComponents
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
9752dbf950 Fix osu! approach circles fading in too late 2019-08-28 18:10:58 +09:00
e6bd02d276 Simplify namespace definition 2019-07-30 22:41:20 +09:00