Commit Graph

166 Commits

Author SHA1 Message Date
812a4b412a Move judgement result revert logic to Playfield
Previously, some judgement results were not reverted
when the source DHO is not alive (e.g. frames skipped in editor).
Now, all results are reverted in the exact reverse order.
2023-01-19 19:57:13 +09:00
b88091262d Remove #nullable disable from Catch.UI 2023-01-15 17:29:35 +09:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
c95eb2d2c1 Fix incorrect case in CatcherArea parameter 2022-07-06 14:28:50 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
95891bc655 Moved clear plate logic to Catcher class 2021-11-18 20:03:41 +01:00
2c4f1817d3 Fixed an issue where banana showers don't clear the plate when missing the last banana 2021-11-14 20:43:31 +01:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
3e56388ba8 Match casing in enum value 2021-08-02 15:08:42 +09:00
4e2f928d65 Fix comment 2021-07-30 15:44:09 +09:00
a204ef39dd Prevent catcher trail generation while rewinding 2021-07-29 17:32:38 +09:00
81f23e1111 Manage catcher trails by lifetime entries 2021-07-29 17:12:01 +09:00
a960a28d06 Replace "end glow" terminology with "hyper-dash after-image"
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
0bf04ece34 Avoid internal property by using ChildrenOfType 2021-07-28 18:13:43 +09:00
846f539428 Avoid usage of LINQ in last dash trail computation 2021-07-27 19:11:08 +09:00
da69867fd4 Move catcher trail generation logic to CatcherArea 2021-07-27 19:07:37 +09:00
d9f9ad35be Move catcher base size constant to Catcher. 2021-07-21 16:43:24 +09:00
30777795ce Add some doc comment to CatcherArea 2021-07-21 16:40:35 +09:00
94678064ff Rename CatcherArea.MovableCatcher to Catcher 2021-07-21 16:28:31 +09:00
97059a9f50 Create Catcher in CatchPlayfield 2021-07-19 19:44:40 +09:00
ae09c23e4e Resolve DroppedObjectContainer via DI 2021-06-24 16:09:13 +09:00
16d5893535 Add DroppedObjectContainer class 2021-06-24 15:51:54 +09:00
7f7c2c73e0 Move catcher movement logic of Catcher to CatcherArea 2021-06-11 15:39:06 +09:00
ccca7e0b25 more specific type droppedObjectContainer 2020-12-09 10:35:01 +09:00
0213f77b4b Move catcher state changing logic to OnNewResult method 2020-12-08 14:28:30 +09:00
e82ca66d3e Fix depth of dropped objects 2020-12-04 10:21:54 +09:00
5a5c956ced Move more logic to Catcher from CatcherArea 2020-12-03 16:44:36 +09:00
2eb2c934cc Refactor fruit dropping code
- The repeated `Remove` call was quadratic complexity.
  Now it is linear time.
2020-12-03 16:44:36 +09:00
8d32cca5d6 Use more specific type for caught object 2020-12-03 16:44:36 +09:00
a231a4aa6d Remove unused method 2020-12-03 16:44:36 +09:00
af45e8d97b Don't delay caught fruit loading
It is not needed anymore because
some code in DCHO is moved from `load` to constructor.
2020-12-03 16:44:36 +09:00
d1076778fd Convert switch expression to switch statement 2020-12-01 09:50:52 +09:00
05aaa377e7 Don't use CreateDrawableRepresentation in CatcherArea 2020-11-30 19:02:49 +09:00
3c3229ac4b Remove redundant StaysOnPlate 2020-11-25 07:59:45 +09:00
ab7251d742 Move members to PalpableCatchHitObject 2020-11-24 19:57:37 +09:00
4ca9a69de2 Use new hit results in catch 2020-09-29 16:33:38 +09:00
fcf3a1d13c Encapsulate combo display better 2020-09-12 22:40:34 +02:00
ba8a4eb6f0 Move osu!catch combo counter display to inside CatcherArea 2020-09-01 20:17:21 +03:00
28534c1599 Reintroduce PalpableCatchHitObject at data level 2020-08-20 19:06:26 +02:00
2624862e32 Fix osu!catch dropping fruit appearing above the plate instead of behind 2020-07-15 20:58:09 +09:00
3278a1d7d8 Standardize osu!catch coordinate system
There were two coordinate systems used:
- 0..512 (used in osu!stable)
- 0..1 (relative coordinate)

This commit replaces the usage of
the relative coordinate system to
the coordinate system of 0..512.
2020-07-02 00:21:45 +09:00
95de2c6f7f Mark Catcher.additiveTarget to never be null
And provide empty containers instead.
2020-04-22 05:04:07 +03:00
ee62739b08 Simplify process of adding catcher trails 2020-04-21 11:44:39 +03:00
19f39fe632 Change AdditiveTarget into a set method 2020-04-04 19:33:52 +03:00
fecafc2e48 Fix additive target accidentally clears all of the added containers
It sets the AdditiveTarget on the object initializer but then the catcher is set to Child which wipes up all of the existing children (containers added by Catcher through AdditiveTarget setter)
2020-03-26 09:14:44 +03:00
1733519c3a Split out CatcherArea nested classes and reorder methods 2020-03-13 12:59:30 +09:00
bc2a1cdb62 Apply suggestions 2020-03-12 12:04:36 +03:00
e46c070d95 Add test scene 2020-03-11 23:09:29 +03:00
09b9983286 Fix CatcherAnimationState is Fail if missing banana shower 2020-03-11 21:14:07 +03:00
03c8140d3c Merge branch 'master' into add-catcher-animation-states 2020-03-11 14:53:14 +09:00