Commit Graph

257 Commits

Author SHA1 Message Date
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
84a3cee452 Apply rate multiplier outside BPM rounding 2022-05-20 18:04:12 +03:00
596853da8f Fix song select potentially displaying BPM range with equal min/max values 2022-05-20 17:53:28 +03:00
f9f6248101 Simplify string bindings 2022-03-30 17:59:45 +09:00
bc0b982102 Remove song source from main wedge display
This was definitely added at someone's request, since I wouldn't have
put it here. But it's displayed below in the details section already and
also not displayed in the updated "wedge" in the new design.

See https://github.com/ppy/osu/discussions/17537 for discussion.
2022-03-30 17:59:40 +09:00
2de7795844 Fix always rolling up from zero
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-03-10 19:59:05 +09:00
671d614c92 Fix beatmap wedge mutating transforms incorrectly 2022-03-10 17:54:33 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
e6fdd0e969 Miscellaneous fixes that don't fit elsewhere 2022-01-12 16:39:36 +09:00
9ac8e6c81c Add missing null check before attempting to populate bpm info 2021-12-10 13:53:48 +09:00
e7e61cd9ab Fix potential crash due to children being mutated after disposal
This is a bit of an unfortunate edge case where the unbind-on-disposal
doesn't help, since the binding is happening in BDL, and the usage is in
a nested `LoadComponentAsync` call. Combine those and you have a recipe
for disaster.
2021-12-09 18:52:00 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
86540d1fb6 Update existing usages of Author as string to access Username directly 2021-11-04 18:57:54 +09:00
98367fc482 Update usages of GetLocalised{-> Bindable}String 2021-11-02 21:42:01 +01:00
6802e9ec10 Remove FixedWidth and add AutoSizeAxes specs to all usages 2021-10-25 20:24:48 +02:00
847726547a Move mod value change callback inside wedge info text component 2021-08-24 07:53:49 +03:00
9538a32b5e Explicitly update beatmap info wedge on mod change
This used to already be the case prior to b419ea7, but in a very
roundabout way. Changes to the value of the star difficulty bindable -
including indirect changes via the set of active mods changing - would
trigger the wedge display to regenerate and load asynchronously.

b419ea7 accidentally broke this by moving down the bindable retrieval to
a lower level, at which point `WedgeInfoText` would only receive the set
of mods selected at the time at which a given beatmap was selected, and
not receive any further updates, breaking the BPM display updating in
real time (as `WedgeInfoText` could not be aware that rate-changing mods
were even in effect).

To resolve, explicitly reload the wedge's contents on mod changes.
2021-08-22 19:16:46 +02:00
e4a8f72167 Add failing test case 2021-08-22 19:16:43 +02:00
a65cd36a5f Move some constants to consts 2021-08-19 19:19:46 +09:00
6bfae25cda Apply 5px vertical spacing on fill flow
Regressed, was margin { bottom = 5f } from the star rating display
creation method, which I've partly inlined.
2021-08-19 08:30:29 +03:00
25e6317e7f Use animated star display in beatmap info wedge and synchronise bar 2021-08-19 07:18:02 +03:00
102320f8ae Merge branch 'master' into mod-settings-difficulty-cache 2021-08-19 06:35:13 +03:00
9d2664cbb1 Merge branch 'master' into star-rating-display-v2 2021-08-18 17:22:33 +09:00
b419ea716b Refactor beatmap info wedge to not fully refresh on star difficulty change
Makes it look awkward when changing difficulty via mod settings for
example.

Now the changes should instead only affect the displayed components which consume it
directly.
2021-08-17 05:46:06 +03:00
0e66a05963 Hide left border of beatmap wedge 2021-08-13 22:29:22 +09:00
d4399f10f9 Merge both variants of the star rating display 2021-08-04 18:19:28 +03:00
9a5e052dc0 Use star difficulty colour spectrum game-wide 2021-08-03 15:02:18 +03:00
081dafc4e4 Update existing inline usages to use new extension method 2021-07-31 16:46:02 +09:00
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
165f443ab5 Merge branch 'master' into add-missing-author-links 2021-05-07 14:32:44 +09:00
cffeb8641f Make setters private for protected containers 2021-05-06 02:14:57 +09:00
fe9ade6754 Rename Container to DisplayedContent 2021-05-06 02:14:04 +09:00
b6b9a69601 Removed unnecessary class for wrapping 2021-05-05 18:50:49 +02:00
bb385f4255 Reverted difficulty and mod updates 2021-05-05 18:15:59 +02:00
2797507758 Reorganized elements for readability 2021-05-05 17:56:07 +02:00
88506a51dd reduced complexity 2021-05-05 17:51:29 +02:00
5049e2fbf9 Refactored out changes in DifficultyColourBar 2021-05-05 15:28:33 +02:00
4ef901d08d Remove unnecessary redirection property to Container.Info 2021-05-05 21:07:49 +09:00
cf6ed7a7cf Refactored out changes in StarRatingDisplay 2021-05-05 13:13:37 +02:00
713344ebad Reorganize methods 2021-04-23 10:31:49 +02:00
0dfd0bb59d Refactored background of BeatmapInfoWedge 2021-04-21 15:46:11 +02:00
d6928e91fd Removed BeatmapInfo in StarRatingDisplay 2021-04-21 15:43:48 +02:00
9fba87f67a Moved Info and Background into own container 2021-04-21 15:43:29 +02:00
e9571b72cf Fixed InspectCode 2021-04-20 14:53:35 +02:00
583754b22a Removed unnecessary whitespaces 2021-04-20 14:29:53 +02:00
df29e61147 Fix CodeFactor error 2021-04-20 14:22:49 +02:00
f799a6e733 Removed StarDifficulty binding passthrough 2021-04-20 14:18:41 +02:00
c5d35ab787 removed mods binding passthrough 2021-04-20 12:40:22 +02:00
4e6cd8082e WIP refresh BPM-Label on mod change 2021-04-20 12:00:04 +02:00