Commit Graph

1113 Commits

Author SHA1 Message Date
00d4d976b7 Move editor selections relative to hitobject start positions (#6431)
Move editor selections relative to hitobject start positions
2019-10-11 19:35:11 +09:00
51bf600ea7 Use empty hitwindows instead of null 2019-10-09 19:08:31 +09:00
8b661e624d Remove drag from class/method namings + refactor 2019-10-08 19:08:31 +09:00
08d043f447 Move selection relative to the hitobject start positions 2019-10-08 18:57:03 +09:00
0fdb07346b Merge branch 'master' into fix-mania-placement 2019-10-06 14:22:03 +08:00
80585d446c Split applyPositionOffset into two methods and add xmldocs 2019-10-03 18:40:48 +09:00
f1ff22cf8b Fix hold note blueprint placing in the wrong direction 2019-10-03 18:40:48 +09:00
39369620fa Remove position offset from ColumnAt 2019-10-03 18:40:48 +09:00
0a409075be Fix note placement offset not working for down-scroll 2019-10-03 18:40:48 +09:00
754fbc59e1 Fix note placement being offset 2019-10-03 18:40:48 +09:00
652acac87f Move placement movement event to BlueprintContainer 2019-10-03 16:14:42 +09:00
8efab559c8 Remove unused using directives 2019-09-25 01:13:42 +02:00
9323df26a1 Decouple bar line hitobjects from generator
Introduce an IBarLine interface, which together with generic constraints
helps decouple BarLineGenerator from the actual hitobject types it
creates. Thanks to this, all rulesets that want bar lines can provide
an implementation of IBarLine that also derives from the base hitobject
class.

This allows DrawableBarLines in taiko and mania to be migrated back to
DrawableTaikoHitObject and DrawableManiaHitObject base classes
respectively. This in turn resolves #6215 without code duplication,
since the missing anchoring application is now done in mania's
DrawableBarLine through deriving from DrawableManiaHitObject.
2019-09-25 00:36:27 +02:00
2d99d41a6d Remove unused CORNER_RADIUS 2019-09-20 18:17:35 +03:00
61b396f235 Remove redundant length check 2019-09-18 17:09:43 +09:00
381daffe52 Generate better temporary frames to support framed handling flaws 2019-09-18 16:09:48 +09:00
77947e8309 Fix rewind tests failing 2019-09-17 22:33:27 +09:00
a407e267a2 Fix PF/SD legacy mod conversion
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
624e5644a4 Change osu!catch key trigger to occur on frame before positional change 2019-09-13 23:06:35 +09:00
125b3fda6c Merge branch 'master' into improve-catch-replay-frames 2019-09-13 19:23:15 +09:00
9fc60aeefc Merge branch 'master' into reset-dho-lifetimes 2019-09-12 19:29:14 +09:00
f21e47d6d2 Move expire to DrawableHitObject 2019-09-12 19:29:08 +09:00
acdfeef1dc Improve how osu!catch stores and replays key actions 2019-09-12 18:33:46 +09:00
f9b64446e9 Merge branch 'master' into mania-note-sizing 2019-09-12 14:20:28 +09:00
b941f12688 Cleanup 2019-09-12 14:09:21 +09:00
141e83fada Merge branch 'master' into mania-hit-explosion 2019-09-12 13:53:42 +09:00
bbf80f63aa Publicly expose column width constant 2019-09-12 13:53:05 +09:00
b1c0b080ec Fix bad hit explosion anchoring 2019-09-12 13:52:27 +09:00
06618b6d02 Fix osu!mania minor barline alpha not being respected 2019-09-11 18:45:47 +09:00
b9e71d26b2 Dim column backgrounds further 2019-09-11 18:21:39 +09:00
c7186efd53 Reduce opacity of judgement area 2019-09-11 18:21:29 +09:00
6bfdadb22f Increase column width 2019-09-11 18:20:41 +09:00
8f6bc6fd5c Make osu!mania hit explosions more explodey 2019-09-11 18:19:47 +09:00
44d90a4e86 Increase note height 2019-09-11 18:16:14 +09:00
da6ba20fc8 Reduce glow on notes 2019-09-11 18:15:03 +09:00
e682ca4fd9 Adjust osu!mania scroll speed defaults to be more sane 2019-09-11 12:51:54 +09:00
af3bb5a2cd Centralise and share bar line generation code between rulesets 2019-09-10 13:30:54 +09:00
f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
8302658186 Fix other potential nullref cases that rider missed 2019-09-02 18:31:33 +09:00
4c150839c0 Fix potential diffcalc hitwindow nullref 2019-09-02 17:38:58 +09:00
f3656475de Return null hitwindows for non-time-based objects 2019-09-02 16:10:30 +09:00
70e417533f Update naming 2019-08-30 15:13:29 +09:00
a15828ab25 Introduce the concept of SkinComponents
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
6641811125 Add EditorWorkingBeatmap for reuse of the playable beatmap 2019-08-29 19:41:12 +09:00
6ab2b20c70 Add an interface for working beatmaps 2019-08-29 19:38:44 +09:00
d8a48a37d1 Merge branch 'master' into editor-refactor 2019-08-29 18:22:42 +09:00
87e28ab1f9 Remove non-generic DrawableEditRuleset 2019-08-29 18:12:29 +09:00
1597cf874e Merge branch 'master' into relative-beat-lengths 2019-08-28 20:26:20 +09:00
ecfcbe3723 Merge remote-tracking branch 'upstream/master' into relative-beat-lengths 2019-08-28 20:21:56 +09:00