1edfac4923
Fix test failing
2020-07-01 23:21:08 +09:00
47a732ef60
Address review comments
...
Now asserting instead of an if-statement, change cast from OsuStorage to MigratableStorage and make internal virtual properties protected.
2020-06-24 23:01:56 +02:00
063503f4db
Move null check outside of the loop
2020-06-24 20:43:56 +02:00
af11340849
Fix nullref exceptions and redundant explicit type
2020-06-24 02:13:28 +02:00
c32ef5e718
Address formatting issues
2020-06-24 00:37:29 +02:00
a47d34f1db
make ignore properties protected virtual get-only in base
2020-06-23 23:34:26 +02:00
21774b8967
Move static properties to parent class and inherit OsuStorage from it
2020-06-22 11:38:50 +02:00
1d4d749b53
Undo blank line removal
...
Was too excited to add blank lines before submitting the PR that I overdid it
2020-06-11 15:56:34 +02:00
222ac86304
Add newlines at the end of the file
2020-06-11 15:52:14 +02:00
800c46f752
Fix test function override
2020-06-02 14:39:15 +09:00
2c6887e610
Remove unnecessary use of and remove StartupStorage
2020-05-31 19:49:03 +03:00
82fe99cf4a
Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory
...
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
2020-05-31 02:24:49 +03:00
bc6b64b1d7
Add failing test
2020-05-17 22:10:09 +02:00
aea192080a
Fix incorrect storage name
2020-05-15 13:02:46 +09:00
7641507c90
Ensure test directories are deleted before subsequent run
2020-05-15 10:45:57 +09:00
0690d81bbb
Add protection against migrating to a nested folder
2020-05-15 10:40:26 +09:00
19f117ae53
Update test logic for new exception type
2020-05-15 10:28:03 +09:00
827d75b152
Revert "Add protection against migrating to a nested folder"
...
This reverts commit ef8375b442
2020-05-14 22:44:27 +09:00
ef8375b442
Add protection against migrating to a nested folder
2020-05-14 22:42:42 +09:00
e4a23b3e7d
Fix ignored excluding more than top level
2020-05-12 12:39:04 +09:00
6c350db097
Add connection flushing support
2020-05-11 21:39:44 +09:00
36640f5dda
Merge branch 'master' into migration-backend
2020-05-11 18:52:36 +09:00
384862d48b
Fix incorrect relative paths when using GetStorageForDirectory
2020-05-10 13:20:13 +09:00
5dda94187e
Add more edge case testing
2020-05-09 20:13:44 +09:00
1348bdaa15
Merge branch 'custom-data-directory' into migration-backend
2020-05-09 19:32:29 +09:00
abb32b3256
Merge branch 'master' into custom-data-directory
2020-05-08 10:05:11 +09:00
5e65bda8d8
Add test coverage
2020-05-07 22:12:24 +09:00
4ac5ed71f4
Remove redundant string interpolation
2020-05-07 21:48:57 +09:00
90e17853a8
Update tests in line with framework changes
2020-05-07 18:12:11 +09:00
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
6621d363da
Add basic custom data directory support
2020-05-04 17:01:05 +09:00
8118747732
Make PeriodTracker actually immutable
2020-05-02 01:33:33 +02:00
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
6e76e5900a
Rename is-in-any check method to a more legible name
2020-04-29 05:11:44 +03:00
587f946dc6
Adjust, simplify and make the test code more flexible to some degree
2020-04-29 05:11:43 +03:00
3d975f30a3
Merge branch 'timing-equivalence' of https://github.com/Alchyr/osu into timing-equivalence
2020-04-08 01:45:53 -07:00
65823fb2e1
Use redundancy test
2020-04-08 01:42:35 -07:00
65db64e13e
Add failing test cases
2020-04-07 22:41:20 +02:00
036efb9947
Merge branch 'master' into fix-effect-points
2019-12-18 01:43:15 +09:00
927ba4c113
Update expected exception in test.
2019-12-17 15:20:05 +08:00
36f541d8e5
Fix incorrect asserts
2019-12-13 18:14:06 +09:00
87a7f340e3
Fix first sample point being treated as redundant
2019-12-13 18:14:01 +09:00
205eda8566
Use readonly field when not reflected.
2019-11-12 19:56:43 +08:00
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
4e80eda6da
Add test coverage
2019-10-28 11:40:42 +09:00
40fc655b50
Add equality check test to ensure correct values
2019-10-17 01:19:50 +03:00
70842f71f4
Fix floating point handling in filter intervals
...
Due to floating-point rounding and representation errors, filters could
wrongly display results incongruous with the wedge display text (ie.
a beatmap with the BPM of 139.99999 would be displayed as having 140
BPM and also pass the bpm<140 filter).
Apply tolerance when parsing floating-point constraints. The tolerance
chosen is half of what the UI displays for the particular values (so
for example half of 0.1 for AR/DR/CS, 0.01 for stars, etc.)
Tests updated accordingly.
2019-09-22 00:20:55 +02:00
b262ba13cd
Add creator= and artist= filters
...
To match stable, add creator= and artist= filters to the beatmap
carousel on song select screen. Contrary to stable, this implementation
supports phrase queries with spaces within using double quotes.
The quote handling is not entirely correct (can't nest), but quotes
should rarely happen within names, and it is an edge case of an edge
case - leaving best-effort as is. Test coverage also included.
2019-09-22 00:20:55 +02:00
41569fd2b6
Add filter evaluating unit tests
...
Introduce unit tests covering the actual evaluation of filters for
beatmaps. Partially covers most scenarios.
2019-09-22 00:20:54 +02:00
d11d932a87
Add filter parsing tests
...
Introduce unit tests covering parsing for the originally introduced
filtering features. The introduced improvements (lower and upper
interval and decimal point support) also tested.
2019-09-22 00:20:54 +02:00
