Commit Graph

7884 Commits

Author SHA1 Message Date
ebce39cd1c Add test coverage of failing sample bank transfer 2023-05-16 18:52:52 +09:00
8528fcaedc Rename editor sample adjustment test scene to increase scope of tests 2023-05-16 18:52:52 +09:00
83dcd78826 Make HitSampleInfo.Bank non-nullable 2023-05-16 18:12:56 +09:00
a99bf0fc5a Add test coverage 2023-05-14 12:29:24 +02:00
9a327d95b8 Add test coverage 2023-05-14 11:24:24 +02:00
9160711470 Change "Show main page" test steps to actually load the main page 2023-05-08 15:32:00 +09:00
f002038137 Add test coverage of failing wiki return to page scenario 2023-05-08 15:29:05 +09:00
8514b2758a Fix rapid back button test failure 2023-05-07 21:07:38 +02:00
80ac8abaa6 Merge branch 'master' into chat-report 2023-05-06 15:30:44 +02:00
fba3c587cf Add test coverage for info message failing to display 2023-05-06 15:26:29 +02:00
8391e2a538 Move reporting code out of DrawableChatUsername into more correct locations 2023-05-05 14:03:42 +09:00
698baa78bf Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
99e8b2ce70 Make getMod() method generally better 2023-05-04 19:12:22 +02:00
aa7885ab97 Use better test step names 2023-05-04 19:11:51 +02:00
bdd96caaa9 Merge branch 'master' into edit-mods-preset 2023-05-04 18:59:47 +02:00
e43fc23606 Fix typos in test 2023-05-04 18:50:21 +02:00
2cb6642b0d use AddUntilStep or not wait 2023-05-04 13:18:25 +09:00
59ece64d25 Merge branch 'master' into skin-editor-change-handler-improvement 2023-05-03 19:42:42 +02:00
c609e6345c remove Use Current Mods menu item 2023-05-03 23:02:50 +09:00
3a15783a3c remove wait, use AddUntilStep 2023-05-03 22:59:01 +09:00
25bf4e68ec remove useless wait 2023-05-03 22:53:13 +09:00
b932e4d986 Rename DrawableUsername to DrawableChatUsername and only pass message ID 2023-05-03 18:53:22 +09:00
4f55afb60d Merge branch 'master' into chat-report 2023-05-03 18:50:38 +09:00
384693a431 Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308.
2023-05-03 14:30:58 +09:00
6b017ac05f Merge pull request #23308 from OliBomby/sample-control-points
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
e394b487e0 Merge branch 'master' into edit-mods-preset 2023-05-03 12:06:16 +09:00
e42b0cc5b1 Merge pull request #23370 from peppy/fix-editor-playfield-padding
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
95badb9455 Adjust composer tests to new screen layout
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b were added, it is impossible
for a toolbox button to be in front of the playfield in the collapsed
state, which the test was relying on.

The test scenario is still however relevant in the case of the toolbox
being expanded, as in that state the toolbux buttons may very well end
up being in front of the playfield, and they still should not result in
a hitobject being placed. To ensure that this is the case, add a few
extra test steps ensuring that the toolbox is expanded first before
trying to retrieve an overlapping button.
2023-05-02 18:45:45 +02:00
94ae9d7664 Merge pull request #23357 from OliBomby/fix-reverse-crash
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
1e4a628cb1 Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
e3c384c6b5 Merge branch 'master' into sample-control-points 2023-05-02 14:38:39 +09:00
983a8f7dfe Merge branch 'master' into fix-reverse-crash 2023-05-02 13:14:34 +09:00
87db891143 Adjust test to reliabily fail 2023-05-02 13:12:11 +09:00
1fb4c814f4 Remove no longer needed API call mocking
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.

This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
8ab3a87b13 Add failing test case covering online ID reset on save
This test scene passes at e58e1151f3 and
fails at current master, due to an inadvertent regression caused by
e72f103c17.

As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
dbb2a8980b add test 2023-05-01 15:56:23 +02:00
4d52ce769b Revert SaveState() calling on initialization 2023-05-01 12:53:58 +02:00
608fa3cc73 Merge remote-tracking branch 'upstream/master' into sample-control-points 2023-04-30 19:47:03 +02:00
7cedbca9be Merge branch 'master' into multiplier-doesnt-update-with-preset-mod 2023-04-30 17:36:00 +02:00
d35355970f Add test case covering failure scenario 2023-04-30 17:23:45 +02:00
8f02bd80f9 Addressed changes 2023-04-30 16:11:52 +02:00
949dc1c0f9 Improved logic 2023-04-30 12:05:55 +02:00
585318400c Refactor tests 2023-04-30 02:32:20 +02:00
9a9e02b110 Added tests 2023-04-30 02:00:35 +02:00
2643100644 Add xmldoc to new test mentioning failure rate and general purpose 2023-04-29 11:05:10 +09:00
32f8c674f4 Extract beatmap retrieval method for more legibility 2023-04-29 11:01:29 +09:00
a6f0186112 Improve legibility and code quality of new test 2023-04-29 10:51:56 +09:00
428b5fad3c Rename test scene to explicitly mention navigation testing 2023-04-29 10:51:56 +09:00
d9b3c97179 Fix testing 2023-04-29 10:29:33 +09:00
c5357d30ab Add test 2023-04-29 10:29:33 +09:00