Commit Graph

26353 Commits

Author SHA1 Message Date
5031707048 Merge pull request #13690 from smoogipoo/fix-action-posting
Fix commands posted to the wrong channel
2021-06-30 00:39:02 +09:00
2f1203085b Also add logging of realm block/flush operations 2021-06-29 20:23:25 +09:00
9acc5e38bb Add basic logging for osu! storage migration
When looking into the test failure at https://github.com/ppy/osu/runs/2940065457, it became apparent that we are not showing the migration process anywhere in logs. It's the cause of many issues, and we would want to see this in CI and user logs when occurring.
2021-06-29 20:23:25 +09:00
ca0eaab8e2 Add test 2021-06-29 16:30:46 +09:00
7a86686f40 Make nullable 2021-06-29 16:30:40 +09:00
9132c42f87 Fix actions posted to the wrong channel 2021-06-29 15:58:07 +09:00
697b07acb1 Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
471bf9a752 Merge pull request #13681 from peppy/score-submit-ruleset-id
Serialise and send ruleset ID as part of score submission
2021-06-29 11:27:13 +09:00
e4ca6a4266 Serialise and send ruleset ID as part of score submission 2021-06-29 01:55:09 +09:00
a9084db665 Merge pull request #13673 from peppy/import-early-checksum-abort
Shortcut import process to speed up duplicate imports
2021-06-28 19:55:09 +09:00
8950757b61 Merge pull request #13618 from peppy/fix-realm-state-change-crashes
Fix realm threading issues to make it releaseable
2021-06-28 19:54:49 +09:00
92fcf90768 Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
a8597b6213 Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
2021-06-28 17:03:56 +09:00
d4ea73d727 Simplify disposal exceptions 2021-06-28 16:17:09 +09:00
f78cedd0e1 Reorder methods and add xmldoc for BlockAllOperations 2021-06-28 16:16:40 +09:00
90f0bc87f5 Add safety against double disposal 2021-06-28 16:12:21 +09:00
842f033522 Remove no longer necessary exception 2021-06-28 16:11:55 +09:00
f7aba7360a Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box
Refactor `SeedSettingsControl` and `SettingsNumberBox`
2021-06-28 16:07:30 +09:00
0d2bc4fc5f Merge branch 'master' into fix-realm-state-change-crashes 2021-06-28 16:03:58 +09:00
e4780d4b06 Update framework 2021-06-28 15:29:47 +09:00
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00
7dd566dc46 Add null check for safety
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-06-28 15:08:49 +09:00
c281e43cd8 Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock 2021-06-28 15:04:14 +09:00
e387feb1d6 Add inline comment mentioning why CreateChildDependencies is being used in this instance 2021-06-28 14:39:55 +09:00
fdd6778f36 Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
a3946a1265 Fix typo in newly added xmldoc
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-06-28 14:07:21 +09:00
3d19364a71 Use BindValueChanged instead of setting the value in property setter 2021-06-28 11:20:00 +08:00
4d6002ab88 Remove redundant string interpolation (and mark all local logging strings as verbatim) 2021-06-28 12:16:15 +09:00
0cceef8da5 Moved the string to int? conversion logic into SettingsNumberBox 2021-06-28 11:00:07 +08:00
4a557e73a7 Add logging to help understand existing case skips better 2021-06-28 10:42:42 +09:00
9c0840268a Merge pull request #13598 from JimmyC7834/supporter-only-filter-content
Add supporter required placeholder in beatmap listing overlay
2021-06-28 10:27:56 +09:00
90b87cbb9e Add back unidirectional online id check 2021-06-28 10:11:27 +09:00
9a96cd4a1d Revert "Remove comparison of online beatmap IDs during dedupe checks"
This reverts commit 15af28d2a0.
2021-06-28 09:54:18 +09:00
a1e8cc5444 Merge pull request #13669 from Naxesss/hitsound-checks
Add hitsound checks
2021-06-28 03:13:43 +09:00
9f9e96ce9e Add check for spanDuration <= 0 prior to division 2021-06-27 15:40:09 +02:00
a4a5325b73 Improve acceptable difference for repeat edges
Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.
2021-06-27 15:39:31 +02:00
e755dcc34d Add log method for new flow 2021-06-27 20:37:12 +09:00
f470b7095d Move private method down in class 2021-06-27 20:36:01 +09:00
f216404952 Fix missing undelete call on using existing 2021-06-27 20:22:48 +09:00
9120321731 Add comments mentioning shortcomings and avoid potential double check 2021-06-27 19:07:35 +09:00
44f875b802 Bypass optimised existing check in SkinManager (due to custom hashing function) 2021-06-27 16:35:13 +09:00
e493685c14 Add optimised existing check earlier in import process 2021-06-27 16:34:40 +09:00
15af28d2a0 Remove comparison of online beatmap IDs during dedupe checks 2021-06-27 14:48:57 +09:00
46f8100f43 Remove overly verbose logging during beatmap imports 2021-06-27 14:29:02 +09:00
d1f852d102 Make Populate abstract to avoid unnecessary base call async complexity 2021-06-27 14:29:02 +09:00
4cfa0ae5ec Improve precision for repeat edges 2021-06-27 03:26:35 +02:00
2cd7eda3c4 Add "or equal to" to volume threshold xmldocs 2021-06-27 02:30:12 +02:00
0c0fd291d9 Order hitobjects by endtime 2021-06-27 01:25:03 +02:00
4796b1b208 Use local variables for hasHitsound & couldHaveHitsound 2021-06-27 00:04:30 +02:00