Commit Graph

2478 Commits

Author SHA1 Message Date
cd48cb1887 Add comment 2018-04-06 19:53:23 +09:00
e59124962c Remove re-instantiation of clock in EditorClockTestCase 2018-04-06 18:38:44 +09:00
c7440201fb Merge branch 'master' into alt-eagerselect 2018-04-06 12:37:16 +03:00
9e8490735f Fix Compose not binding to the editor's beat divisor 2018-04-06 18:22:24 +09:00
c7abd56fc4 Give editor a custom clock to handle seeking 2018-04-06 18:11:37 +09:00
5426432e46 Fix drag select crashing 2018-04-06 11:47:21 +09:00
32e8d93596 Fix selection changing when clicking overlapping hitobjects 2018-04-06 11:22:36 +09:00
24b9a8c983 Allow HitObjectMasks to handle drag events directly 2018-04-06 10:29:34 +09:00
5749e71560 Apply review fixes 2018-04-05 21:06:48 +09:00
345cfb077d No need to sort list any more 2018-04-05 21:03:39 +09:00
7482d5986a Add a loading state to BeatmapSetOverlay.
- Handle null value in header and info sections
- Add item to context menu for carousel beatmaps to show details
2018-04-04 21:46:31 +05:30
216c4629e0 Fix dragging backwards not deselecting pending selection 2018-04-04 20:44:22 +09:00
b7325d73e8 Don't inherit VisbilityContainer 2018-04-04 20:44:11 +09:00
94c3f38541 Pass down input state instead of parent lookup 2018-04-04 20:06:45 +09:00
2b15555ede Remove MaskContainer dependency in MaskSelection 2018-04-04 20:05:01 +09:00
5c036b966b Formatting fixes 2018-04-04 20:04:54 +09:00
31a7db0a35 Fix drag mishaps 2018-04-04 19:42:59 +09:00
bce114a37b Make AliveMasks private 2018-04-04 18:55:17 +09:00
4d71f2084c Move individual mask selection logic out of MaskSelection 2018-04-04 18:29:53 +09:00
b6b8c51657 Remove DragLayer dependency on MaskContainer 2018-04-04 18:20:32 +09:00
c2d371797e Fix unbind failure 2018-04-04 17:38:34 +09:00
c712b29b5b Rename dragBox to dragLayer 2018-04-04 16:24:27 +09:00
4196bb8c24 Move selection logic to MaskContainer 2018-04-04 16:24:13 +09:00
d453c2589a Add an explanatory comment for weird override 2018-04-04 16:02:20 +09:00
788bfde002 Merge branch 'master' into selectionlayer-rewrite 2018-04-04 15:38:27 +09:00
4f19059e55 DragBox -> DragLayer 2018-04-03 21:29:49 +09:00
ddba7254ca Merge remote-tracking branch 'upstream/master' into linq 2018-04-03 13:05:08 +09:00
57b4cdaf85 Merge branch 'master' into selectionlayer-rewrite 2018-04-03 03:05:42 +09:00
69e2d4fd22 Make CarouselRoot a nested class 2018-04-02 15:24:08 +09:00
6f88a80bde Merge branch 'master' into alt-eagerselect 2018-04-02 15:18:22 +09:00
82a847b820 Extract random selection logic into CarouselRoot 2018-04-02 15:16:10 +09:00
32832304a7 Merge branch 'master' into fix-songselect-exit-notimplemented 2018-04-02 13:53:41 +09:00
b842f682eb Use Linq.Append and Prepend. 2018-04-02 12:06:34 +08:00
7e30375443 Use selectNextRandom instead 2018-03-30 10:46:46 +03:00
f1f7d978ec Add some comments 2018-03-30 16:28:59 +09:00
69a7ddbf1e Fix ordering of display/input of HitObjectMasks 2018-03-30 16:28:49 +09:00
53541a5c8d Add license header 2018-03-30 15:53:31 +09:00
5d0a636cc4 Rename SelectionBox -> Selection 2018-03-30 15:51:38 +09:00
1dca1663c3 Handle all selection events within SelectionBox (incl. single-mask) 2018-03-30 15:50:55 +09:00
082e5e4949 Reduce iterations of DragBox 2018-03-30 15:06:52 +09:00
31ade986a7 Scren async changes in line with framework changes
Makes editor not stutter on load, amongst other screens.
2018-03-30 14:58:11 +09:00
3f65e3a7e3 Make selection at random when last was null 2018-03-30 00:15:32 +03:00
6b2ca36657 Add license header 2018-03-29 22:52:42 +09:00
d9c5a0c6d1 Fix position editing not working 2018-03-29 22:38:44 +09:00
4446aeaa0d Commenting + cleanup of HitObjectMask/HitObjectMaskLayer 2018-03-29 22:38:28 +09:00
d8f26f2260 Make HitObjectMaskLayer not iterate through all masks when deselecting 2018-03-29 22:22:42 +09:00
1018711cc9 Cleanup SelectionBox 2018-03-29 22:20:56 +09:00
346de77776 Cleanup DragBox 2018-03-29 22:13:28 +09:00
04874bcda4 "overlay" -> "mask" 2018-03-29 22:09:22 +09:00
6d4f94756e Rewrite the way drag + click selections happen
The general idea here is that we need the masks to handle mouse down events, as they need to handle the drag (mousedown -> drag immediately).

I've rewritten the editor selections to use events, as there are some 3 different components that handle/trigger selections in different ways.

1. All selections/deselections now propagate through `HitObjectMask.Select()`/`HitObjectMask.Deselect()`.
2. Components that react to changes in the selection bind to the masks' `Selected`/`Deselected` events, and track them/change their states locally.
3. Masks provide a `SingleSelectionRequested` event which is invoked on the mouse-down event. Various components bind to this event to perform state changes locally in this scenario.
4. `DragBox` now handles all drag input locally. It triggers `Select`/`Deselect` on the masks it needs to.
5. `SelectionBox` handles the display of itself locally.
6. `SelectionBox` handles movement of groups of masks locally.
7. `HitObjectMasks` handles movement of itself locally.
2018-03-29 22:07:23 +09:00