Commit Graph

25022 Commits

Author SHA1 Message Date
32ff406289 Add database tracking of beatmap creator user_ids 2021-05-14 15:40:29 +09:00
8338f702c3 Remove not required null conditional 2021-05-14 09:32:56 +03:00
dc576c19b4 Fix a potential nullref when starting Player with autoplay enabled and beatmap fails to load 2021-05-14 15:10:02 +09:00
48672f8afd Add very basic test logic to ensure PlayerLoader is present for playlists 2021-05-14 15:02:36 +09:00
1d4bcbaa6e Merge pull request #12796 from peppy/update-framework
Update framework
2021-05-14 14:43:54 +09:00
46e7d9e0ed Randomise the values displayed in the skinning toolbox
To stop the spam of "WYSI" comments everywhere. I guess I underestimated
the negative effect this would have.
2021-05-14 12:15:58 +09:00
b36c991ba1 Fix single case of incorrect usage 2021-05-14 12:04:38 +09:00
a447f20095 Fix formatting of #nullable enable 2021-05-14 03:38:35 +02:00
90e0b3374e Add #nullable enable
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-14 03:34:50 +02:00
9e8c0a7e70 Fix online play subscreens not pushing player loaders when starting gameplay 2021-05-14 04:25:29 +03:00
ddceafb1b0 Update framework 2021-05-14 09:38:25 +09:00
6f248db519 Merge conditional expression. 2021-05-13 19:31:10 +02:00
0caba57945 Make screen properties local to MigrationSelectScreen. 2021-05-13 19:28:23 +02:00
6a64a705b8 Merge branch 'master' into skin-blueprint-aspect-lock 2021-05-13 17:53:00 +02:00
25b1443c50 Remove dead branch and mark implementation as temporary
The previous implementation was checking if the `x0` or `x2` anchors
were selected to decide on which way to transfer the drawable's scale,
but that check actually ends up being always true for corner anchors. To
visualise, this is how the corner anchors correspond to `Anchor` flags:

    x0  x1  x2
    |   |   |
y0 -O---O---O-
    |   |   |
y1 -O---+---O-
    |   |   |
y2 -O---O---O-
    |   |   |

The Os indicate where the reference anchors are on a selection box.
The first conditional eliminates the middle ones, which makes sense.
But after excluding them from further deliberations (marking via X):

    x0  x1  x2
    |   |   |
y0 -O---X---O-
    |   |   |
y1 -X---+---X-
    |   |   |
y2 -O---X---O-
    |   |   |

The remaining anchors always have `x0` or `x2` set. So to avoid
confusion, just always transfer one way for now. At some point this
should be torn out in favour of an actual implementation of the desired
behaviour.
2021-05-13 17:50:12 +02:00
0fa90a80d4 Merge branch 'master' into skin-blueprint-aspect-lock 2021-05-13 23:38:53 +09:00
3ecbb9ec4b Merge branch 'master' into skin-blueprint-anchor-origin 2021-05-13 23:38:04 +09:00
98830dadda Merge pull request #12762 from peppy/skin-blueprint-visual-improvements
Improve the visual appearance of skin editor blueprints
2021-05-13 23:37:21 +09:00
cef39eb4fa Merge pull request #12766 from peppy/stable-anchor-origin
Keep component positions stable when changing anchor/origin
2021-05-13 23:36:40 +09:00
caa3e1dca5 Merge pull request #12767 from peppy/save-on-forced-exit
Save skin editor changes on forced exit
2021-05-13 23:35:52 +09:00
09a5b9c872 Add XMLDoc to protected members. 2021-05-13 16:28:03 +02:00
4183a1c556 Merge pull request #12769 from peppy/remove-skinnable-hud-classes
Remove remaining test usage of SkinnableXXX HUD components
2021-05-13 22:56:18 +09:00
6c12cae105 Remove unnecessary property 2021-05-13 22:25:11 +09:00
c57a2f43fa Merge branch 'master' into skin-blueprint-visual-improvements 2021-05-13 22:22:42 +09:00
38c0ba2d10 Implement current year highlight in YearsPanel 2021-05-13 16:16:19 +03:00
63fbbc848e Merge pull request #12778 from peppy/skin-editor-shortcut-fix
Change default skin editor shortcut to Ctrl+Shift+S
2021-05-13 22:14:03 +09:00
4cf4817ad2 Remove redundant parens 2021-05-13 22:11:58 +09:00
d2fdd1e521 Merge branch 'master' into stable-anchor-origin 2021-05-13 22:06:21 +09:00
94543bf000 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-13 16:00:46 +03:00
67f795cfa6 Merge branch 'master' into save-on-forced-exit 2021-05-13 22:00:38 +09:00
1e23c53507 Fix inspection 2021-05-13 21:59:38 +09:00
362a09ca73 Fix up + reduce complexity of HOCEventQueue 2021-05-13 21:41:49 +09:00
aaf31af326 Add blueprint transferral 2021-05-13 21:16:19 +09:00
86042e1763 Implement HitObjectContainerEventQueue 2021-05-13 21:15:47 +09:00
d5b14b6b99 Merge branch 'master' into remove-skinnable-hud-classes 2021-05-13 21:06:48 +09:00
1b62947469 Merge branch 'master' into skin-editor-default-placement-location 2021-05-13 20:58:31 +09:00
746862dcb1 Merge pull request #12750 from peppy/skin-serialisation
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
ffb6135a1b Rework hitobject blueprints to take in hitobject models 2021-05-13 19:53:32 +09:00
3c471837f8 Merge branch 'master' into skin-serialisation 2021-05-13 19:49:55 +09:00
a3869c02f4 Merge branch 'master' into fix-two-hovered-handles 2021-05-13 19:24:42 +09:00
b939318922 Merge branch 'skin-serialisation' into skin-editor-default-placement-location 2021-05-13 19:09:34 +09:00
e5f765d1a8 Fix broken exception message 2021-05-13 19:06:58 +09:00
bda0ea463a Merge branch 'skin-serialisation' into save-on-forced-exit 2021-05-13 19:05:47 +09:00
c8b7cfc753 Merge branch 'skin-serialisation' into remove-skinnable-hud-classes 2021-05-13 19:05:08 +09:00
07e475cd13 Fix skin blueprint box drawing incorrectly when both scale and rotation are applied 2021-05-13 18:54:40 +09:00
2f025f1967 SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
01bc71acd2 Improve ability to parse xmldoc of SkinnableTargetWrapper
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-05-13 18:40:28 +09:00
df77b28b48 Add a flimsy guard against null parent to avoid crashes on exit sequence 2021-05-13 18:39:21 +09:00
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
eee3cd7c57 Disallow selecting storage root as a valid directory. 2021-05-13 11:14:05 +02:00