Commit Graph

7074 Commits

Author SHA1 Message Date
25dbe6b27c Fix unused null assignment 2022-01-22 12:58:30 +09:00
7025191fdd Move target field outside of Run usage
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-01-22 12:02:44 +09:00
114c9e8c1f Update all usages of CreateContext to use either Run or Write 2022-01-21 17:27:08 +09:00
a5d2047f05 Fix various cases of creating realm contexts from update thread when not necessary 2022-01-21 01:44:56 +09:00
4f86a2cb61 Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
b8184a3005 Fix news sidebar assuming returned posts are always from given year 2022-01-19 23:13:30 +01:00
4cad5890c6 Add test coverage for news sidebar showing wrong headers 2022-01-19 23:12:35 +01:00
33ab356dc5 Fix expanded card content being clipped on beatmap listing overlay 2022-01-19 22:10:05 +01:00
d10d657073 Merge pull request #16421 from Susko3/textbox-AllowIme-false
Add `AllowIme => false` to text boxes where applicable
2022-01-18 18:02:47 +09:00
39c9c4985b Merge branch 'master' into textbox-AllowIme-false 2022-01-18 17:03:51 +09:00
1b62a685f3 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-18 15:07:59 +09:00
e9c96908d5 Merge pull request #16481 from peppy/fix-scores-container-tests
Rewrite `TestSceneScoresContainer` to work again
2022-01-17 20:39:14 +09:00
12fd279b7d Add test to check full flow of rebinding gameplay key bindings
Addresses a regression found in realm PR that was not covered by tests.
2022-01-17 16:00:17 +09:00
51ade3251d Improve ScoresContainer loading overlay logic to work better with tests 2022-01-17 15:15:39 +09:00
88bf406c22 Fix null reference in equality comparison causing beatmap set overlay to crash 2022-01-17 13:05:55 +09:00
5601f6f1fe Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-17 12:29:02 +09:00
6e4214de4d Move VersionManager from osu.Desktop to osu.Game 2022-01-15 19:42:38 +01:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
3a95425a9e Remove left-over methods in MusicController 2022-01-14 19:55:49 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
017285b694 Update MusicController to handle deletions more correctly 2022-01-12 17:49:11 +09:00
72656ae01e Fix beatmap restore/undelete flows 2022-01-12 17:49:11 +09:00
46206f70d6 Fix beatmap mass deletion flow 2022-01-12 17:49:11 +09:00
e8dcbaf29a Fix intro screen hitting null reference if intro beatmap is unavailable 2022-01-12 17:49:11 +09:00
c33e163178 Bind ruleset to toolbar later for safety 2022-01-12 17:49:10 +09:00
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
33060990b7 Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows 2022-01-12 17:00:16 +09:00
1d536fd0bc Start introducing ILive 2022-01-12 17:00:16 +09:00
abd72c496b "Update" MusicController 2022-01-12 17:00:16 +09:00
00e3af3366 Update model manager and many related classes to get things compiling again 2022-01-12 17:00:00 +09:00
4f6a05ce3d Reimplement all query methods 2022-01-12 16:57:27 +09:00
53792811b2 more fixes (almost compiles, except ruleset and manager) 2022-01-12 16:57:27 +09:00
3ecd889fef Replace EF RulesetStore with realm version
Pass full EF context factory to `RealmContextFactory` for migration purposes
2022-01-12 16:39:36 +09:00
11e07c1137 Add button to compact realm on demand
In general we're doing things correctly so the realm file shouldn't
expand (unless mass deletions are made from it), but this is a nice way
to manually confirm the behaviour.

Sometimes if using realm studio with osu! running, for instance, the
realm file size can blow out of proportion. This will recover from such
cases.

Note that calling `RealmFactory.Compact` itself is not enough, as it
will fail unless all instances of the realm have been closed.
2022-01-12 15:22:36 +09:00
a0842838e7 Add AllowIme => false where applicable
Also adds `AllowWordNavigation => false` to password text box.
2022-01-12 00:15:17 +01:00
a8c3fdd383 Update outdated OpenTabletDriver FAQ links 2022-01-11 16:11:07 +01:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
2e9ba40ae2 Add references to web implementation wrt property used 2022-01-09 14:46:15 +01:00
12c8243a9b Fade out inactive player rows on user ranking table 2022-01-09 14:42:26 +01:00
9e84e31eac Add score time to beatmap set overlay scoreboard table 2022-01-07 19:18:16 +01:00
87f7c7e691 Implement scoreboard-specific time formatting 2022-01-07 19:18:16 +01:00
881fa2b86b Add basic test scene for scoreboard time 2022-01-07 19:18:16 +01:00
3cd996eb4a Merge branch 'master' into async-deadlock-safety 2022-01-07 17:28:59 +09:00
8f744c99ee Fix settings toolbox toggle button starting in incorrect state
While displaying replays, the colour of the toolbox toggle button would
not match the actual state of the rest of the toolbox, i.e. both buttons
would be white, even though the "playback settings" section was expanded
and as such should have a yellow toggle button.

In the case of the replay player, the failure scenario was as follows:

1. `SettingsToolboxGroup` calls `updateExpanded()` in its BDL to update
   the initial state of the toolbox, including the toggle button
   colour, by adding a colour fade transform.

2. An ancestor of both the toolbox groups - `PlayerSettingsOverlay`,
   which is a `VisibilityContainer` - calls `FinishTransforms(true)` in
   its `LoadCompleteAsync()`, therefore instantly applying the colour
   from point (1) to the toggle button instantly.

3. However, `IconButton` inherits from `OsuAnimatedButton`. And
   `OsuAnimatedButton` changes its colour in `LoadComplete()`, therefore
   undoing the instant application from point (2).

This conjunction of circumstances is instrumental to reproducing the
bug, because if the `FinishTransforms(true)` call wasn't there, point
(3) wouldn't matter - the transform would get applied at some
indeterminate point in the future, ignoring the write from
`OsuAnimatedButton`.

As for the fix, move the `updateExpanded()` call in
`SettingsToolboxGroup` to `LoadComplete()` to avoid the above
unfortunate order. Applying initial visual state in `LoadComplete()` is
the idiomatic style of doing things these days anyhow.
2022-01-06 20:45:56 +01:00
e02863f780 Avoid accessing DrawWidth from invalidation 2022-01-07 01:24:30 +09:00
f703c5f038 Add comment and reduce how often ChildrenOfType is invoked in ExpandingButtonContainer 2022-01-06 23:38:54 +09:00
5aca2dd4ce Hide header text when it won't fit in the toolbox group 2022-01-06 23:08:50 +09:00
690b425380 Move enum local to usage 2022-01-06 22:56:56 +09:00
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00