Commit Graph

37306 Commits

Author SHA1 Message Date
b62ff8d644 Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-18 23:52:12 +01:00
b8b7442eb8 Make SongProgressInfo.ShowProgress init-only (and remove duplicate init) 2023-01-18 23:35:40 +01:00
903c37bf32 Apply draw colour to segmented graph segments 2023-01-18 23:17:57 +01:00
f8d8a627b8 change property name 2023-01-18 22:00:39 +01:00
769f8c6190 Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}
Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
and the `JudgementCounter.Pop{In,Out}` methods were operating on the
alpha of the `JudgementCounter`. This meant that if the counter display
was created with max judgement initially hidden, it would be hidden
by the `ShowMaxJudgement` callback first, but then _unhidden_
by `PopIn()`.
2023-01-18 21:46:28 +01:00
40e99069fc fix typos and newlines 2023-01-18 21:43:09 +01:00
ab78dd0436 add collection of selection points. 2023-01-18 21:34:23 +01:00
77bc4fbf70 Integrate editor into comment 2023-01-18 20:50:07 +03:00
0d91277ea5 Add ability to change number on replies button 2023-01-18 20:49:30 +03:00
c74500b4b4 Add reply editor 2023-01-18 20:49:07 +03:00
761298cd8e Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation
Fix legacy judgement animation not matching perfectly
2023-01-18 18:27:13 +01:00
150195b887 use extension method to check accuracy impact 2023-01-18 12:24:41 -05:00
e0f3fa1af6 remove this in ruleset assignment 2023-01-18 12:22:27 -05:00
4a6f6300c5 Merge branch 'master' into fix-carousel-sort-change-after-play 2023-01-18 17:15:20 +01:00
7ba448b13c Update comment to match implementation 2023-01-18 17:12:57 +01:00
0f2ca5d5ed Expose method for drawable comment creation 2023-01-18 18:10:35 +03:00
c9375c056e revert back name change 2023-01-18 15:54:24 +01:00
18baf3dd5d Log delete failure 2023-01-18 17:30:34 +03:00
24ed84aad0 Add tiered level badge colouring 2023-01-18 16:25:11 +03:00
12fc5da143 Merge branch 'master' into frame-stable-cache 2023-01-18 14:16:46 +03:00
3b27774561 Remove OnlineID sort consideration 2023-01-18 19:21:02 +09:00
4ef940653b Fix legacy judgement animation not matching perfectly
This will be the final attempt to get it right. I was seemingly drunk
last time I wrote the logic.

Closes #21892.
2023-01-18 19:03:04 +09:00
43a037c189 Merge pull request #21620 from mk56-spn/JudgementCounter
Add a judgement counter to skin components
2023-01-18 18:43:49 +09:00
522bb8bcca Use ComputeAccuracy to get imminent accuracy 2023-01-18 18:08:58 +09:00
ecb4727aec Fix formatting issues 2023-01-18 17:33:14 +09:00
4cfb059170 Merge branch 'frame-stable-cache' into skin/argon-song-progress-cleaner 2023-01-18 17:21:08 +09:00
04705504c5 Move cache to more appropriate location 2023-01-18 17:19:57 +09:00
67b40dd234 Adjust the seek effect to feel better 2023-01-18 17:09:39 +09:00
01558a9199 Tidy up height logic and allow hovering above bar for easier interaction 2023-01-18 17:09:29 +09:00
f3677ab33d Simplify depth change logic 2023-01-18 16:38:21 +09:00
7d0388c55c Cache IFrameStableClock in Player for easier access
Allows directly referencing rather than going through `DrawableRuleset`.
Helps with testing and implementation of the new song progress display
(#22144).
2023-01-18 16:31:58 +09:00
42e9b2b48c Tidy up clock logic in all SongProgress classes 2023-01-18 16:29:42 +09:00
8bfd853889 Fix missing comment 2023-01-18 16:11:14 +09:00
bfb75730a9 Prefix subclasses of DefaultSongProgress with Default 2023-01-18 15:45:16 +09:00
1e5dd9165a Adjust SkinnableTestScene to give more breathing room to RelativeSize components 2023-01-18 15:37:46 +09:00
7266d8e10d Move "show difficulty graph" settings back to respective implementations to avoid legacy version showing it 2023-01-18 15:31:55 +09:00
5a272b4bd6 Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-18 15:25:02 +09:00
742a026077 Add comment mentioning why reference clock fallback logic is required 2023-01-18 15:24:35 +09:00
e8770b84cd Remove no longer necessary interface type 2023-01-18 15:23:55 +09:00
5429979049 Combine common code into SongProgress base class 2023-01-18 15:23:55 +09:00
afc12e0b83 Tidy up ISongProgressBar interface 2023-01-18 14:43:20 +09:00
f7c4199a77 Merge pull request #22262 from Joehuu/chat-mention-user
Add ability to easily mention users in chat by right clicking username
2023-01-18 13:30:02 +09:00
736ff419c0 Merge pull request #22261 from peppy/fix-bad-operation
Fix song select potentially operating on `Carousel` before it is fully loaded
2023-01-18 12:06:33 +09:00
4ad79a8a0a Move IsLoaded check inside BeatmapCarousel 2023-01-18 12:00:47 +09:00
0a47dc733f Merge pull request #22268 from Feodor0090/comments-margin
Reduce padding for too nested comments
2023-01-18 11:45:41 +09:00
ca3be71381 Track comment's nesting and reduce padding for too nested 2023-01-18 02:11:07 +03:00
12544c16ea Remove canBeNull 2023-01-18 02:10:02 +03:00
dfea42fd16 Add space after username mention 2023-01-17 14:13:50 -08:00
254c881ded Also check null for bindable channel value 2023-01-17 14:12:48 -08:00
f7c942ac10 Move user stats into detail header container 2023-01-17 22:32:24 +01:00