Commit Graph

58622 Commits

Author SHA1 Message Date
4dd7727f71 Remove test-specific workaround in overlay 2023-01-02 17:21:14 +01:00
ae3a211da7 Rewrite user profile overlay test to not depend on online API 2023-01-02 17:21:12 +01:00
d7294ac3e6 Substitute APIUser for UserProfile in overlay 2023-01-02 17:21:09 +01:00
608d8ee7d4 Add UserProfile model to be used in user profile overlay
As `APIUser` implements `IEquatable`, attempting to replace an `APIUser`
with another `APIUser` with the same online ID has no effect on the user
profile overlay. This is a significant hurdle in implementing support
for viewing the profile for different rulesets, as in that case the
profile is basically reloaded for the same user, but slightly different
data.

To facilitate this, wrap `APIUser` in a new `UserProfile` class. This
will mean that the equality rules can be changed locally to the user
profile overlay without impacting other components that depend on the
`APIUser` equality rules. The ruleset that the user profile is being
displayed with will eventually be added to `UserProfile`, too.
2023-01-02 17:21:00 +01:00
53cc71c2fe Merge pull request #21991 from bdach/user-profile/nrt
Enable NRT in user profile overlay
2023-01-02 18:17:55 +08:00
73f14bd14f Enable NRT in user profile overlay test scenes 2023-01-01 23:49:15 +01:00
88e90d5fa0 Enable NRT in user profile overlay 2023-01-01 23:49:11 +01:00
b689ad6d80 Fix changing preview point not prompting for save 2023-01-01 19:54:26 +01:00
efdd557f3b Adjust binding logic 2023-01-01 19:45:23 +01:00
452ebddfd2 Adjust visual appearance of preview time part
- Use slightly different hue of green to distinguish from difficulty
  control points. The colour is still not ideal, but picking
  a distinctive enough hue is pretty hard.

- Place the preview time part at the bottom rather at the top.
  Not sure why it was at the top; not only could it overlap with the
  control points, but it also looked quite badly misaligned there
  when bookmarks were displayed at the bottom.
2023-01-01 19:42:55 +01:00
656bf12b3d Add all possible timeline elements to test for demonstrative purposes 2023-01-01 19:42:46 +01:00
a82f1a6abd Adjust method naming and copy 2023-01-01 18:50:47 +01:00
0e59b55a12 Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
b97d4b571e Merge pull request #21916 from Joehuu/remember-chat-textbox-per-channel
Save / sync chat text box messages per channel
2023-01-01 18:02:31 +01:00
2698d58c46 Merge branch 'master' into remember-chat-textbox-per-channel 2023-01-01 17:29:38 +01:00
7e39ee3982 Merge pull request #21945 from cdwcgt/acc-UI
Add new display modes for accuracy counter
2023-01-01 23:20:12 +08:00
a454fa4b8b Merge pull request #21983 from peppy/fix-recent-activity-linking
Fix incorrect domain root being used for recent activity entries on profile overlay
2023-01-01 11:22:26 +01:00
9a4f0cad2c Fix incorrect domain root being used for recent activity entries on profile overlay
Closes https://github.com/ppy/osu/issues/21980.
2023-01-01 17:48:05 +08:00
f7c8986292 Merge pull request #21979 from peppy/add-beatmaps-override-keywords
Add search keywords for beatmap colours / hitsound overrides
2023-01-01 09:27:19 +01:00
87250ad847 Add search keywords for beatmap colours / hitsound overrides 2023-01-01 14:32:28 +08:00
6509d3538c Fix counter initially rolling down from 100% to 0% in minimum achievable mode 2022-12-30 21:13:41 +01:00
7580ab78be Move binding to LoadComplete() 2022-12-30 21:08:48 +01:00
6ed474d4fb Rearrange formula for maximum accuracy
Feels like it's easier to understand this way. The difference of the
maximum scoring values for the entire beatmap and the max values for the
part of the beatmap that has already been played represents the act of
filling the rest of the unjudged objects with maximum results.
2022-12-30 20:56:54 +01:00
ae026e2d2d Add test coverage 2022-12-30 20:55:54 +01:00
8ace635249 Adjust minimum values 2022-12-30 20:55:51 +01:00
bb2822a175 xmldoc pass 2022-12-30 20:55:48 +01:00
6d42cc5a36 Naming pass 2022-12-30 20:30:58 +01:00
ceedc3f934 Merge pull request #21937 from bdach/fix-toolbar-gradient
Fix toolbar gradient not showing when mouse is hovered over buttons
2022-12-31 03:07:59 +08:00
d60349c7c6 add description 2022-12-30 23:24:41 +09:00
8beb168be9 remove nullable disabled 2022-12-30 23:24:20 +09:00
784fe7ecf2 rename AccType to AccuracyDisplay 2022-12-30 23:06:10 +09:00
23c485c763 readonly 2022-12-30 22:59:56 +09:00
a91da2284d safe way to pass bindable 2022-12-30 22:58:46 +09:00
3c32a50c12 add new accuracy counter display 2022-12-30 21:19:46 +09:00
0d70f2c0fd Use alternative workaround 2022-12-30 09:08:17 +01:00
f625c5d744 Fix gradient showing when toggling toolbar with mouse above window 2022-12-29 23:35:45 +01:00
bf975eb48a Fix toolbar gradient not showing when mouse is hovered over buttons 2022-12-29 23:03:53 +01:00
f7febdac5e Add failing assertion 2022-12-29 23:03:50 +01:00
b4e748d97f Merge pull request #21886 from BlauFx/add_linux_hardlink
Add hardlink support for Linux & macOS
2022-12-29 17:03:16 +01:00
ccf713c885 Fix incorrect hard link validity check in stable import screen 2022-12-29 23:18:12 +08:00
0fcf10e10a Also support hard links on macOS 2022-12-29 22:35:13 +08:00
f9f6918fc3 Merge branch 'master' into add_linux_hardlink 2022-12-29 21:29:57 +08:00
1bebfe56f2 Merge pull request #21921 from bdach/fix-toolbar-hover-through
Fix hover propagating through toolbar buttons
2022-12-29 21:03:42 +08:00
c5f7da9a4e Fix hover propagating through toolbar buttons
Closes #21920.

Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3, but then unfixed again in
566e09083f. The second change is no longer
needed since the toolbar became opaque in #9447.
2022-12-29 13:19:14 +01:00
cacc23204d Add failing test coverage 2022-12-29 13:17:39 +01:00
70dbb8edac Fix stand alone chat display textbox not binding to local channel 2022-12-29 01:37:37 -08:00
c326745f96 Save / sync chat text box messages per channel 2022-12-28 16:09:40 -08:00
ffd9359f4a Add tests for chat text box saving / syncing 2022-12-28 15:14:29 -08:00
b40d114e76 Remove context menu from news card for now 2022-12-28 15:00:57 -08:00
74bc5d4666 Disable naming rule inspection on struct stat definition 2022-12-28 22:38:42 +01:00