Commit Graph

39690 Commits

Author SHA1 Message Date
bec16436b0 Merge pull request #12583 from smoogipoo/fix-score-export
Fix exported scores not being compatible with osu-stable
2021-04-26 22:32:18 +09:00
630a6dc46a Fix missing dependency 2021-04-26 22:23:44 +09:00
ed93e26e52 Use single method for starting/restarting spectator screen 2021-04-26 21:56:15 +09:00
7e11d520d5 Remove finished players from multi spectator screen 2021-04-26 21:25:46 +09:00
213ac88a8b Fix exported scores not being compatible with osu-stable 2021-04-26 20:52:20 +09:00
6560dc2d1f Fix exported replays being wrapped in zip packages 2021-04-26 20:46:44 +09:00
559d403abe Rename ColourCodedNotes to TimingBasedNoteColouring 2021-04-26 19:05:12 +08:00
58ebec4803 Move BindValueChanged hooks to LoadComplete() 2021-04-26 19:00:40 +08:00
47925de7ae Merge pull request #12500 from ekrctb/drawable-object
Factor out pooling and lifetime management logic of DHO to a base class
2021-04-26 19:30:43 +09:00
94d0b06493 Expose mute adjustment instead 2021-04-26 19:01:30 +09:00
6d2a5b614c Merge branch 'master' into drawable-object 2021-04-26 18:33:44 +09:00
72d9cdcdf9 Merge pull request #12580 from peppy/fix-editor-slider-repeat-animation
Fix slider repeats and tails still animating with editor hit animations disabled
2021-04-26 17:36:51 +09:00
4c5a5c449a Merge branch 'multiplayer-spectator-screen' of https://github.com/smoogipoo/osu into multiplayer-spectator-screen 2021-04-26 17:35:37 +09:00
d7618b63fa Fix test failure 2021-04-26 17:35:13 +09:00
6626e70c95 Pass in master clock instead of slave clock 2021-04-26 17:30:27 +09:00
120fb8974d Combine more instances of test player IDs 2021-04-26 17:22:16 +09:00
5b4cb71cc7 Change terminology from "slave" to "player clock" 2021-04-26 17:19:44 +09:00
737a15c2d4 Extract out test player IDs to constants 2021-04-26 17:04:39 +09:00
55f383c71e Rename test to match new MultiSpectatorLeaderboard class name 2021-04-26 16:48:40 +09:00
6d30a1a80f Reference constant for test startup delay 2021-04-26 16:45:20 +09:00
1e0ee3cd61 Merge branch 'master' into fix-editor-slider-repeat-animation 2021-04-26 16:45:04 +09:00
0727728771 Merge pull request #12579 from peppy/rename-edit-classes
Rename "EditRuleset" and "EditPlayfield" to use full "Editor" keyword
2021-04-26 16:44:35 +09:00
8b60f6e7fb Merge pull request #12581 from smoogipoo/fix-simultaneous-slider-input
Fix simultaneous slider input not allowing both keys to be accepted
2021-04-26 16:21:48 +09:00
aa99c192d0 Fix type in inline comment 2021-04-26 16:21:12 +09:00
56da0a63da Merge branch 'master' into multiplayer-spectator-screen 2021-04-26 16:09:24 +09:00
0d0b4ea78a Rewrite comment to hopefully be more readable 2021-04-26 15:47:37 +09:00
fd5fbaf0db Rename ruleset wrapper class 2021-04-26 15:37:42 +09:00
f70e45b199 Prevent adding null enumerable 2021-04-26 15:35:08 +09:00
d10aac851d Extract scale constant 2021-04-26 15:30:22 +09:00
8795c5f082 Update osu! editor transform logic to allow adjustments to DrawableSliderRepeat and DrawableSliderTail 2021-04-26 15:27:10 +09:00
4da964c3f3 Expose DrawableSliderRepeat's arrow and move transforms to children 2021-04-26 15:22:42 +09:00
aa7ade8186 Expose presence of MainCirclePiece via an interface 2021-04-26 15:22:17 +09:00
6182181ea1 Fix simultaneous slider input not allowing both keys 2021-04-26 15:20:29 +09:00
bda8f68da4 Add failing test 2021-04-26 15:03:43 +09:00
4898471d68 Merge branch 'master' into fix-editor-slider-repeat-animation 2021-04-26 14:43:22 +09:00
cefdf1bf98 Merge pull request #12574 from frenzibyte/animate-circle-piece-usages
Fix missing animation of slider repeat and tail circle pieces
2021-04-26 14:42:46 +09:00
e8d83f2f99 Rename "EditRuleset" and "EditPlayfield" to use full "Editor" keyword 2021-04-26 14:33:30 +09:00
3b876a43c2 Merge branch 'master' into multiplayer-spectator-screen 2021-04-26 14:12:35 +09:00
2764a42824 Merge pull request #12546 from smoogipoo/gcc-change-source-on-reset
Ensure source is set on GameplayClockContainer.Reset()
2021-04-26 14:12:12 +09:00
049e42fa85 Move snapping responsibility to IBeatmap
Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great.

This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`.

Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.
2021-04-26 05:07:24 +02:00
6561a7c7d6 Rename DrawableObject -> PoolableDrawableWithLifetime 2021-04-26 12:06:21 +09:00
20e3cadd30 freeIfInUse -> free, and add comments 2021-04-26 12:04:59 +09:00
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
e6474e6ff7 Remove redundant statement (lifetime is set in base) 2021-04-26 11:47:38 +09:00
0b9172a1dc Animate back slider repeat and tail circle pieces 2021-04-26 02:39:49 +03:00
8bb1fcd39b Add tests for BeatDivisorFinder 2021-04-26 07:07:32 +08:00
beee318acc Add more distance between each hit object in editor selection test
To avoid potentially hovering over the rotation control instead of wherever the test desired to move the mouse to.
2021-04-26 01:45:52 +03:00
485da47d89 Revert "Inherit VisibilityContainer and make duration constant protected"
This reverts commit c58ef4230d. Uhh, how did I push this..
2021-04-26 01:41:42 +03:00
b252485e1a Remove protected expose of HandlingMouse setter
Regardless of `OnDragEnd()`, `OnMouseUp()` will still be called resetting the value of that state back.
2021-04-25 20:13:23 +03:00
334927ed35 Remove leftover step 2021-04-25 20:13:01 +03:00