Commit Graph

1015 Commits

Author SHA1 Message Date
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
4bf4938b72 Keep cursor hiding feature to gameplay screens for now 2022-10-20 03:44:58 +03:00
d2d589a156 Expose HUD state via Player 2022-10-12 15:11:52 +09:00
a810afafb3 Reschedule results display delegate to avoid potential softlocks in the future 2022-10-02 15:37:56 +03:00
59728b0ccb Fix results display delegate potentially cancelled while not exiting 2022-10-02 15:30:06 +03:00
46db3ad96d Move implementation to individual classes 2022-09-20 00:06:02 +09:00
4c4fdfd153 Provide scores directly to Player instance rather than relying on DI 2022-09-16 18:15:17 +09:00
678eec1c67 Move LeaderboardFlow to HUDOverlay to share positioning logic 2022-09-13 18:45:11 +09:00
5894d2f0bc Ensure gameplay leaderboard hides with rest of HUD when it should 2022-09-13 18:45:11 +09:00
d251c0b2ac Move leaderboard implementation to Player itself 2022-09-13 18:00:21 +09:00
d4afc3629c Merge branch 'master' into kps 2022-09-08 23:00:36 +09:00
b559d4ecdf Rename GameplayAdjustments -> AdjustmentsFromMods 2022-09-08 17:14:06 +09:00
fa15502384 Move full track adjustment flow inside MasterGameplayClockContainer 2022-09-07 19:12:16 +09:00
75d0deef72 Apply proposed changes to remove inheritance from MasterGameplayClockContainer 2022-09-07 17:49:05 +09:00
7084aeee05 Add method flow to reset applied adjustments 2022-09-05 23:22:38 +09:00
7337d4c1aa Merge branch 'master' into kps 2022-08-31 15:41:42 +09:00
cf6bb3b030 Merge pull request #19958 from peppy/fix-fail-freq-stuck
Ensure fail animation sequence isn't run after the player exit sequence has started
2022-08-27 00:58:41 +09:00
8f4a953d11 Ensure fail animation sequence isn't run after the player exit sequence has started 2022-08-25 14:26:42 +09:00
af2e82d7d5 Move operation of setting GameplayClockContainer.StartTime to Reset call 2022-08-22 14:11:06 +09:00
da407aa827 Merge branch 'master' into kps 2022-08-20 15:24:58 +09:00
63819648df Fix up flow of actual skip operation 2022-08-16 14:40:02 +09:00
6761f869f9 Modify flow to avoid weird bindable and value resetting 2022-08-16 14:17:35 +09:00
c9baadcf88 Merge branch 'master' into improve_retry_behaviour 2022-08-16 13:06:04 +09:00
f81c7644b4 Make GameplayClockContainer also an IGameplayClock and expose to remaining tests 2022-08-15 18:30:53 +09:00
6d78218142 Update usages of GameplayClockContainer.GameplayClock to access properties directly 2022-08-15 18:08:49 +09:00
d5f10cbb9d Revert 787dee24 and initialize calculator in HUDOverlay 2022-08-14 18:53:00 +02:00
787dee249d Move KeysPerSecondCalculator instantiation from HUDOverlay to Player
This prevents messing with *future* Skin (de)serialization
2022-08-11 10:37:16 +02:00
a5081826b7 Handle cancellation at more points during Player initialisation
As discussed in discord, this will help avoid null references during
cancellation which can otherwise be quite confusing to debug.
2022-08-09 23:25:19 +09:00
0afa3a5ec8 Fix xml doc 2022-08-08 21:20:09 +02:00
f6e65cf1af Improve implementation 2022-08-08 20:53:05 +02:00
cd68134565 Call skip method directly 2022-08-08 13:10:28 +02:00
09230304a4 Improve implementation 2022-08-07 13:20:29 +02:00
b2557a8d2d Refactor KPS
- Remove '#nullable disable' in KeysPerSecondCalculator and
  KeysPerSecondCounter
- Remove KeysPerSecondCalculator IDisposable implementation
- Make KeysPerSecondCalculator static instance initialized once by
  KeysPerSecondCounters
- Auto transfer dependencies from KeysPerSecondCounter to
  KeysPerSecondCalculator using Resolved properties
- Add internal reset logic to KeysPerSecondCalculator and make it
  independent from Player
- Use GameplayClock.TrueGameplayRate to get real-time rate. If 0 then it
  defaults to the last non 0 rate if no such mod is enabled
2022-08-07 00:53:00 +02:00
fa6d55b5b5 Remove redundant lambda signature parentheses 2022-08-06 18:47:11 +02:00
0d418559bc Skip song intro only in case of a quick restart 2022-08-06 17:02:45 +02:00
445f921756 Move IsSkippable event into load method 2022-08-05 23:21:03 +02:00
99e07aa09a Skip intro if the map gets restarted 2022-08-05 23:01:52 +02:00
0886137e39 Prevent KeysPerSecondCounter from NRE when no instance is initialized 2022-08-05 21:03:00 +02:00
42d1bdfc95 Move KPS calculation to a standalone class 2022-08-05 04:17:01 +02:00
89855cc1d6 Change KPS Counter implementation base and add better replay integration
The counter implementaiton is now list based, and will not invalidate
previous hits by removing them but by testing if they are within the 1
second span, allowing better integration with replays and spectators.
2022-07-31 01:29:57 +02:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
ad09e728fd Move Passed assignment inside FailScore 2022-07-21 08:12:06 +03:00
0f0b19da4a Populate score with remaining "miss" statistics on fail/exit 2022-07-21 06:01:36 +03:00
6285442b7d Fix failed scores not prepared before import 2022-07-15 22:57:12 +03:00
0200ef1d48 Make delegate firing more safe to being set later than BDL 2022-07-15 19:06:44 +09:00
ab6665d88c Merge branch 'master' into Save-Score-Failed 2022-07-15 18:02:58 +09:00
f3a6e646a6 Merge branch 'master' into Save-Score-Failed 2022-07-08 18:32:13 +09:00
9d730f8440 Fix custom rulesets not importing scores at all
Replaces the error with the ability to import, minus replays.

Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
fd0d8b1ce3 Add button state, fix async issues, watch replay method
Most borrowed from `ReplayDownloadButton`
2022-06-29 22:50:47 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00