7c45c571a0
Merge branch 'master' into more-beat-sync-dependence
2022-08-03 20:22:42 +03:00
844430502b
Replace parantheses with nullable-bool equality operation
2022-08-03 20:11:08 +03:00
87cc2db624
Merge branch 'master' into improve-download-limit-message
2022-08-03 20:17:02 +09:00
d3954fc583
Use existing localised error message
2022-08-03 20:15:46 +09:00
a32149fda1
Convert interface methods to extension methods
2022-08-03 20:07:55 +09:00
4063f92381
Merge branch 'master' into fix-legacy-song-progress-mouse-blocking
2022-08-03 12:12:58 +03:00
16ff8d5c38
Use different variable source
2022-08-03 17:47:32 +09:00
6ad6561e1c
Fix LegacySongProgress
incorrectly blocking mouse input from gameplay
...
Closes #19555 .
2022-08-03 17:42:29 +09:00
f743dc623f
Change migration logic to ignore realm pipe files regardless of database filename
2022-08-03 17:37:30 +09:00
258ad7c6b9
Tidy up kiai time access
2022-08-02 18:18:40 +09:00
cc4cde2c79
Improve IBeatSyncProvider
interface and reduce beatmap track dependence
2022-08-02 17:59:18 +09:00
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
fc0914bf77
Merge pull request #19536 from frenzibyte/playlists-settings-leak
...
Fix playlist settings reference leak due to unsafe binding
2022-08-02 13:30:55 +09:00
4295dc3cb9
Merge pull request #19535 from naipofo/overlay-filter-rank
...
Hide F rank from the beatmap overlay
2022-08-02 13:06:27 +09:00
298efa5391
Fix broken ShearedButton
autosizing logic
2022-08-01 22:04:16 +02:00
3356909026
Merge branch 'master' into overlay-filter-rank
2022-08-01 21:54:44 +02:00
7354f9e6ba
Remove localisation for now
2022-08-01 22:05:52 +03:00
c0e5f11c90
Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
...
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00
7e9d11ee24
Enable NRT on playlists settings overlay
2022-08-01 20:15:08 +03:00
c851e3d8f3
Fix playlist settings reference leak due to unsafe callback binding
2022-08-01 20:08:18 +03:00
6686b09549
Hide F rank from beatmap overlay
2022-08-01 18:54:00 +02:00
fc7fc3d673
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-01 19:13:57 +03:00
01cc9bd7ef
Merge pull request #19479 from frenzibyte/carousel-update-on-resume
...
Fix song select not updating selected beatmap card on editor resume
2022-08-02 00:48:18 +09:00
7c9f8648a5
Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace
2022-08-01 15:25:12 +03:00
6cccb6b848
Remove canBeNull: true
.
2022-08-01 19:45:15 +08:00
3ff0327d91
Display readable message when reaching download limit
2022-08-01 14:22:54 +03:00
2a127c6ef8
Merge branch 'master' into fix-tags-overflow
2022-08-01 12:40:43 +03:00
d4eec9122f
Merge pull request #19516 from peppy/fix-editor-track-disposal-crash
...
Fix editor potentially playing a track post-disposal
2022-08-01 18:12:21 +09:00
14c2348df7
Merge pull request #19514 from peppy/dont-throw-copy-failure-migration
...
Fix migration failing on single file copy failure
2022-08-01 17:43:05 +09:00
c65747d1b8
Use masking instead of scrollable container to prevent tags overflow
2022-08-01 10:36:53 +02:00
5f9c3b42e8
Merge pull request #19513 from peppy/isolate-development-storage
...
Isolate development builds' storage from release builds
2022-08-01 17:30:25 +09:00
1d27c4f020
Merge pull request #19504 from peppy/skin-serialisation-test-coverfage
...
Add test coverage of deserialisation of skin layouts
2022-08-01 17:17:16 +09:00
cc8a71b65d
Re-query file existence before failing a recursive copy operation during migration
2022-08-01 17:01:19 +09:00
59210ecc9d
Revert "Fix migration failing on single file copy failure"
...
This reverts commit fc8835d43a
.
2022-08-01 16:57:50 +09:00
6e7c298aaf
Fix changes to audio / background not triggering an editor state change
2022-08-01 16:53:49 +09:00
2f60f91a0e
Fix editor potentially using a track post-disposal
...
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
fc8835d43a
Fix migration failing on single file copy failure
...
No longer throw if copying of single files fails during data migration.
Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true , which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).
If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).
Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.
2022-08-01 15:02:39 +09:00
8ee4f1e60b
Merge pull request #19510 from bdach/mod-overlay/presets-persistence
...
Add persistence of mod presets to realm
2022-08-01 14:43:52 +09:00
a5f48e336a
Isolate development builds' storage from release builds
2022-08-01 14:38:02 +09:00
5b98a73edc
Apply nullability to SkinComponentToolbox
and split out reflection method to get all skinnable components
2022-08-01 14:04:08 +09:00
85f77abee1
Fix code quality inspection about ambiguous equality
2022-07-31 23:53:46 +02:00
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
fa3b9ee32f
remove unneded guard
2022-07-31 23:42:20 +02:00
cbabc4886c
Convert ModPreset
to realm object
2022-07-31 22:10:15 +02:00
98214beb6c
Prevent overflow on beatmap info using scrollable container
2022-07-31 21:24:41 +02:00
57b43e0065
Stop capturing arrow keys on Playlist
2022-07-31 19:12:29 +02:00
094793bbe3
Mark the GetTrack() return type as nullable.
2022-07-31 22:01:30 +08:00
6c964dee30
Rename the nullable disable annotation in the Audio namespace and mark some properties as nullable.
2022-07-31 22:00:14 +08:00
93b783d9ea
Fix previous skins not loading due to namespace changes
2022-07-31 03:25:38 +09:00
faefda9143
Fix song select not updating selected beatmap card on editor resume
2022-07-30 19:47:42 +03:00