Commit Graph

54086 Commits

Author SHA1 Message Date
369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
ecf7cc77dd Merge pull request #19469 from frenzibyte/fix-dodgy-tests
Fix potential nullref in `TestSceneAutoplay` check steps method
2022-07-30 16:46:51 +09:00
ec1a7994cc Switch method to statement body for better readability
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
0c125db197 Fix potential nullref on TestSceneAutoplay check steps 2022-07-30 10:11:01 +03:00
b32ff68a95 Enable NRT on taiko legacy skin transformer and tests 2022-07-30 09:43:51 +03:00
40858c4cb7 Adjust existing test coverage 2022-07-30 09:32:39 +03:00
0940e703b3 Fix normal skin hitsounds prioritised over default taiko hitsounds 2022-07-30 09:15:28 +03:00
d590219779 Merge pull request #19466 from naipofo/taiko-flashlight-fix
Fix osu!taiko flashlight positioned incorrectly on gameplay restart
2022-07-29 22:05:52 +03:00
1e90ea9e77 Merge branch 'master' into taiko-flashlight-fix 2022-07-29 21:32:35 +03:00
8d1f7970a3 Merge pull request #19465 from peppy/update-framework
Update framework
2022-07-29 21:32:25 +03:00
e0107fc3dc Use RequiredParentSizeToFit to handle misc geometry changes 2022-07-29 21:11:43 +03:00
4e32d510c3 Invalidate flashlightProperties on DrawInfo 2022-07-29 20:08:32 +02:00
eea211eb45 Update framework 2022-07-30 02:46:39 +09:00
f79d749fea Merge pull request #19457 from peppy/fix-summary-kiai-ranges
Fix editor summary timeline not responding to kiai changes correctly
2022-07-29 20:09:45 +03:00
2500e5c533 Merge branch 'master' into fix-summary-kiai-ranges 2022-07-29 19:38:28 +03:00
f07a416c4d Merge pull request #19408 from LeNitrous/pie-chart-progress
Add osu!stable style circular song progress for legacy skins
2022-07-29 17:27:45 +03:00
acf9ad1429 Apply nullability to EffectPointVisualisation 2022-07-29 23:26:38 +09:00
3bc1774c87 Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
3b1a76b190 Remove redundant/overwritten specifications 2022-07-29 16:45:29 +03:00
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
3f72e76348 Expose StartTime from gameplay clock 2022-07-29 16:18:05 +03:00
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
6703b8df02 Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
70420e6238 Merge pull request #19440 from peppy/bypass-local-metadata-cache
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
0a2265b0e8 Add test coverage of playlist exit confirmation 2022-07-29 17:11:37 +09:00
9d457535c6 Add confirmation dialog when about to discard a playlist
The confirmation will only show if items have been added to the
playlist.

Closes https://github.com/ppy/osu/issues/19444.
2022-07-29 17:11:37 +09:00
eb92c35335 Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
cb52b696ed Merge branch 'master' into bypass-local-metadata-cache 2022-07-29 16:05:54 +09:00
2ff6ff06d3 Use tuple to better explain new bool parameter 2022-07-29 16:05:41 +09:00
e07e761c10 Ensure realm is in a good state before asserts in TestSceneFilterControl 2022-07-29 15:59:53 +09:00
be7a9e1487 Merge pull request #19453 from smoogipoo/multiplayer-test-misordering
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:59:51 +09:00
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
bc685918b6 Merge pull request #19451 from peppy/dont-wait-spectator-frames
Revert blocking call when sending spectator frames
2022-07-29 14:17:57 +09:00
fd09155990 Revert blocking call when sending spectator frames
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.

Reverts part of 0533249d11.

Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.
2022-07-29 12:24:54 +09:00
45879f7836 Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
0d6b45e515 Merge pull request #19431 from peppy/collections-track-beatmap-updates
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 22:52:54 +09:00
e664690fe2 Remove unnecessary LoadTrack call 2022-07-28 22:19:46 +09:00
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
a59d7f6710 Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
aa03df905f Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
5003eb5629 Merge pull request #19430 from peppy/realm-collections
Move beatmap collections to realm
2022-07-28 22:05:10 +09:00
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
4b140e1f5a Adjust metrics 2022-07-28 18:50:46 +09:00
86c2b7e449 Apply nullability to DefaultSongProgress and clean up more stuff 2022-07-28 18:37:17 +09:00
ea027eda46 Move initial show to base implementation and add transition for legacy version 2022-07-28 18:29:49 +09:00
bfa026879c Remove pointless null check 2022-07-28 18:28:03 +09:00
d5e5761892 Fix DefaultSongProgress graph not resetting if time is in intro 2022-07-28 18:25:24 +09:00
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00