Commit Graph

1810 Commits

Author SHA1 Message Date
954ae60b81 Merge branch 'master' into copy-existing-difficulty 2022-02-16 08:55:12 +09:00
f5d0eb41cb Update further ChangeFocus usages 2022-02-15 02:42:39 +03:00
e45a2ae0fc Restructure difficulty copy flow to adapt to latest changes 2022-02-14 22:02:37 +01:00
6221447164 Append copy suffix on creating copy of difficulty 2022-02-14 20:19:12 +01:00
6fd663a718 Apply some renames to convey difference between creation options better 2022-02-13 14:01:23 +01:00
a144d6f8d6 Fix beatmap skin properties not copying 2022-02-13 14:01:22 +01:00
a2c2b2bbb3 Add flow for copying existing difficulty content 2022-02-13 14:01:20 +01:00
6f0e32826c Standardise ordering/grouping of IRulesetInfo/RulesetInfos 2022-02-11 04:27:11 +03:00
ee1feae806 Remove unnecessary ruleset ordering
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-02-04 11:06:18 +09:00
afc48d86df Add failing test coverage for save after safeties addition 2022-02-02 21:57:10 +01:00
4f1aac9345 Add safeties preventing creating multiple difficulties with same name 2022-02-02 21:57:09 +01:00
0d51c015ad Add basic test coverage for new difficulty creation 2022-02-02 21:55:34 +01:00
dc96c4888b Add support for creating new blank difficulties 2022-02-02 21:55:33 +01:00
3386f038ba Add new difficulty creation menu 2022-02-02 21:23:35 +01:00
e2fcdc394b Extract method for difficulty switch menu creation 2022-02-02 21:23:35 +01:00
c6a65ccfed Remove unused parameter from createContent()
No longer used since 513e470b52.
2022-02-01 21:35:40 +01:00
b3856c9005 Fix editor crashing on custom rulesets due to ChangeHandler not being supported
As per https://github.com/ppy/osu/discussions/16668, even without proper
saving support some ruleset developers do want to work on the editor.
This brings things back into a workable state.
2022-01-28 14:03:31 +09:00
91be77ad3d Fix null ref in ComposeScreen when ruleset doesn't provide a composer 2022-01-28 14:01:10 +09:00
a5d422e82c Merge branch 'master' into ruleset-id-fixes 2022-01-27 17:07:18 +09:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
d760283665 Ensure edited beatmap is restored to a baseline state on exit 2022-01-26 21:15:49 +01:00
bdf215c576 Merge branch 'master' into improve-timeline-zoom 2022-01-26 03:40:53 +09:00
4169e5592e Reword event handler name and update xmldoc 2022-01-25 19:36:19 +03:00
d1cbdf63f0 Add support for reading/saving timeline zoom in editor 2022-01-25 18:57:39 +03:00
f7f58b06a1 Fix beat divisor not saving in editor 2022-01-25 11:56:38 +03:00
5a9524a74e Decrease default timeline zoom to "6 seconds visible" range 2022-01-25 10:43:51 +03:00
bd748686fa Adjust spacing of time signature numerator input box 2022-01-23 15:21:32 +01:00
e4758c9dbb Mark LabelledTimeSignature as public 2022-01-23 10:14:37 +03:00
54f7b1b8d0 Use new time signature control on timing screen 2022-01-22 20:50:32 +01:00
f39f2c93b5 Add control for arbitrary-numerator time signatures 2022-01-22 20:50:31 +01:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
5f5765d6a2 Reduce redundancy time range to create a bit more visual blending on the timeline 2022-01-19 14:57:01 +09:00
03ac91a3ee Consider all points in a group to meet redundancy check 2022-01-19 14:56:44 +09:00
93cd07f7fb Merge branch 'master' into summary-timeline-control-point-optimisation 2022-01-19 14:50:45 +09:00
67bf95bc91 Remove all usage of AuthorString 2022-01-18 23:30:40 +09:00
d10d657073 Merge pull request #16421 from Susko3/textbox-AllowIme-false
Add `AllowIme => false` to text boxes where applicable
2022-01-18 18:02:47 +09:00
39c9c4985b Merge branch 'master' into textbox-AllowIme-false 2022-01-18 17:03:51 +09:00
566d341b1e Split conditions out for readability 2022-01-16 22:04:29 +09:00
565611ee00 Fix typo in inline comment 2022-01-15 23:57:20 +09:00
236fa6da7e Rename ControlPointVisualisation interface type to be less specific 2022-01-15 23:56:00 +09:00
c5cae4e3ee Rename methods and add xmldoc 2022-01-15 23:55:11 +09:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
64c499d9d6 Revert unintended temporary commenting (was used during benchmarking) 2022-01-15 15:24:30 +09:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
c64a919a9d Reduce number of redundant control points displayed on summary timeline
As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps
with too many control points (usually added via external automation
apps) could cause the lazer editor to grind to a halt.

The overheads here are mostly from the GL side. An eventual goal would
be to render this in a smarter way, rather than using thousands of
drawables. Until that, this optimisation should help reduce the overhead
by omitting control points in close proximity that are redundant for
display purposes.

I've tried to contain this in the display logic directly, with the goal
that it can be ripped out as fast as it was added. Certainly required
more changes than I hoped for, but I don't think it's too ugly.
2022-01-14 17:13:26 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
7509a9ff8f Update BeatmapModelManager.Save to work for editor scenarios 2022-01-12 17:49:11 +09:00
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
a3276758b8 Remove unnecessary re-query of beatmap set in editor menu construction 2022-01-12 17:00:16 +09:00
b8cd3cdbbc Various updates to ruleset and primary key usages to move closer to realm support 2022-01-12 16:57:13 +09:00