Commit Graph

34622 Commits

Author SHA1 Message Date
094793bbe3 Mark the GetTrack() return type as nullable. 2022-07-31 22:01:30 +08:00
6c964dee30 Rename the nullable disable annotation in the Audio namespace and mark some properties as nullable. 2022-07-31 22:00:14 +08:00
93b783d9ea Fix previous skins not loading due to namespace changes 2022-07-31 03:25:38 +09:00
faefda9143 Fix song select not updating selected beatmap card on editor resume 2022-07-30 19:47:42 +03:00
6ad86ce5b7 Run collection import process asynchronously
Actually required to avoid deadlocking..
2022-07-31 01:06:57 +09:00
80ffa2cf20 Move collection database rather than deleting post-migration for safety 2022-07-31 00:54:00 +09:00
8e06d55960 Fix collection migration incorrectly running asynchronously 2022-07-31 00:53:39 +09:00
38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
43e612f6d4 Merge pull request #19455 from peppy/confirm-playlist-discard
Add confirmation dialog when about to discard a playlist
2022-07-30 19:17:49 +09:00
8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
eea211eb45 Update framework 2022-07-30 02:46:39 +09:00
2500e5c533 Merge branch 'master' into fix-summary-kiai-ranges 2022-07-29 19:38:28 +03:00
e06f39a69f Apply IRenderer shader changes 2022-07-30 01:29:11 +09:00
09979d44aa Apply DrawNode batching changes 2022-07-29 23:32:09 +09:00
acf9ad1429 Apply nullability to EffectPointVisualisation 2022-07-29 23:26:38 +09:00
3bc1774c87 Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
155dac55d0 Apply DrawNode parameter changes 2022-07-29 22:33:34 +09:00
3f72e76348 Expose StartTime from gameplay clock 2022-07-29 16:18:05 +03:00
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
70420e6238 Merge pull request #19440 from peppy/bypass-local-metadata-cache
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
9d457535c6 Add confirmation dialog when about to discard a playlist
The confirmation will only show if items have been added to the
playlist.

Closes https://github.com/ppy/osu/issues/19444.
2022-07-29 17:11:37 +09:00
eb92c35335 Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
cb52b696ed Merge branch 'master' into bypass-local-metadata-cache 2022-07-29 16:05:54 +09:00
2ff6ff06d3 Use tuple to better explain new bool parameter 2022-07-29 16:05:41 +09:00
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
fd09155990 Revert blocking call when sending spectator frames
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.

Reverts part of 0533249d11.

Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.
2022-07-29 12:24:54 +09:00
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
a59d7f6710 Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
aa03df905f Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
4b140e1f5a Adjust metrics 2022-07-28 18:50:46 +09:00
86c2b7e449 Apply nullability to DefaultSongProgress and clean up more stuff 2022-07-28 18:37:17 +09:00
ea027eda46 Move initial show to base implementation and add transition for legacy version 2022-07-28 18:29:49 +09:00
bfa026879c Remove pointless null check 2022-07-28 18:28:03 +09:00
d5e5761892 Fix DefaultSongProgress graph not resetting if time is in intro 2022-07-28 18:25:24 +09:00
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
628a30193f Remove incorrect TrackLoaded override from TestWorkingBeatmap 2022-07-28 17:49:17 +09:00
1da9830145 Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
8cb4fb35e0 Rename parameter to read better (and still use local cache if no online API is available) 2022-07-28 17:08:59 +09:00
c35da62224 Add flow for bypassing local cache lookups when refreshing beatmap metadata 2022-07-28 16:33:51 +09:00
17a3fd30fb Move scheduler from OnlineLookupQueue to BeatmapUpdater 2022-07-28 16:32:22 +09:00
0d36907cad apply code quality fixes 2022-07-28 15:30:45 +08:00
bca3994d91 set FirstHitTime and LastHitTime once 2022-07-28 15:25:12 +08:00
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
db62d4be3a apply suggestions
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
c1aaf27c54 Link to correct model in xmldoc 2022-07-28 16:02:19 +09:00