Commit Graph

25980 Commits

Author SHA1 Message Date
35032e2ddd Make variables private 2020-02-02 14:34:06 +01:00
f7abfdb40e Remove unnecessary parameter 2020-02-02 14:33:48 +01:00
aa1daa0ad5 Merge pull request #7703 from bdach/beatmap-stats-precision
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
c7e281348a Merge branch 'master' into profile-page-corrections 2020-02-02 13:36:21 +01:00
6103674b54 Add tests for changing HUD visibility on hidden key counter configuration 2020-02-02 14:50:05 +03:00
6a11c3a8f9 Expose ConfigVisibility bindable for testing purposes 2020-02-02 14:48:07 +03:00
abccf05155 Update visibility of each key counter instead of this container
For isolating changing visibility of the key counter display based on config and internal values from just fading the container.
2020-02-02 14:47:14 +03:00
52aae68411 Adjust profile scores to closer match osu-web 2020-02-02 17:52:34 +07:00
e2589b2dcb Rename drawable 2020-02-02 11:24:28 +01:00
a70385f2b2 Simplify getRulesetName 2020-02-02 12:19:09 +03:00
36116f8c45 Refactor ruleset presentation 2020-02-02 12:03:51 +03:00
8786d6264f Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-recent-info 2020-02-02 12:03:33 +03:00
ed48e3014c Merge pull request #7709 from bdach/bindable-float-double
Remove all usages of Bindable<float> and Bindable<double>
2020-02-02 11:25:36 +09:00
434c0d92e4 Use Bindable{Float,Double}s everywhere
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
e894acf53c Make star filter range bindables BindableDoubles
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
2020-02-01 22:48:46 +01:00
583fee074f Fix mod select not showing up in mod settings test 2020-02-01 11:50:24 -08:00
609ee26030 Fix mod select overlay not showing up in test 2020-02-01 11:41:41 -08:00
2d42a83bb9 Fix mod select overlay overflowing toolbar at max ui scale 2020-02-01 11:24:29 -08:00
9f4261111b Match osu-stable behaviour and size 2020-02-01 16:55:30 +01:00
0bfadfbbf1 Apply precision when comparing adjusted values
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
e90ae667b7 Add failing tests 2020-02-01 16:08:24 +01:00
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
c904ae485a Make use of ElementAtOrDefault() when possible (#7695)
Make use of ElementAtOrDefault() when possible
2020-02-01 11:05:00 +09:00
5e834b64cd Merge branch 'master' into use_ElementAtOrDefault 2020-02-01 10:42:40 +09:00
6d30e425a1 Revert change to avoid conflict with another PR 2020-01-31 18:51:29 +01:00
b7f4dd8dd4 Fix Alt+number shortcuts for tabs in chat overlay (#7687)
Fix Alt+number shortcuts for tabs in chat overlay
2020-02-01 02:51:18 +09:00
9596030e1d Make use of ElementAtOrDefault() when possible 2020-01-31 18:32:47 +01:00
5312586351 Merge remote-tracking branch 'origin/perform-from-screen' into present-replay-from-ss 2020-02-01 02:14:17 +09:00
89cdf8ec2b Merge remote-tracking branch 'origin/decouple-mod-select-bindable' into present-replay-from-ss 2020-02-01 02:14:11 +09:00
d94045e612 Fix remaining merge conflict 2020-02-01 02:12:50 +09:00
ed368e44ea Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
3291d7b6c9 Merge branch 'master' into present-replay-from-ss 2020-02-01 02:08:00 +09:00
c5422743e2 Merge branch 'master' into decouple-mod-select-bindable 2020-02-01 02:06:23 +09:00
90caa61245 Reverse comparison for readability
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-02-01 02:05:26 +09:00
8db1a8ddb9 Merge branch 'master' into perform-from-screen 2020-02-01 02:04:30 +09:00
b3e63d8869 Merge branch 'master' into fix-chat-tab-shortcuts 2020-02-01 02:03:43 +09:00
9a1df491cd Merge pull request #7690 from peppy/exit-all-screens-centrally
Centralise screen exit logic to ScreenTestScene
2020-02-01 02:03:07 +09:00
e728d2be17 Use ElementAtOrDefault 2020-02-01 01:19:04 +09:00
0c305b96d1 Merge branch 'master' into fix-chat-tab-shortcuts 2020-01-31 22:22:04 +09:00
c4331f34d5 Consume TearDownSteps 2020-01-31 22:09:39 +09:00
f8aee122b6 Merge remote-tracking branch 'upstream/master' into exit-all-screens-centrally 2020-01-31 22:09:12 +09:00
3e15265a53 Update framework 2020-01-31 22:09:02 +09:00
a66cdee5e9 Fix missed issues 2020-01-31 21:36:19 +09:00
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
a547d2ed5c Don't least at Player just yet 2020-01-31 18:37:16 +09:00
2f61d3f5ad Fix song select remaining issue locally 2020-01-31 17:35:53 +09:00
f736bbfccb Merge pull request #7691 from peppy/fix-incorrect-nunit
Fix incorrect nUnit adapter version causing rider failures
2020-01-31 17:05:53 +09:00
ab7bbf38a8 Set default beatmap later in test initialisation 2020-01-31 16:14:55 +09:00
3b5b799d60 Adjust height of ShowMore button 2020-01-31 09:51:56 +03:00
4a444face1 Change ShowMoreButton hide logic 2020-01-31 09:46:35 +03:00