c221058f0f
Simplify fetching DrawableChannel in ChatOverlayV2 test
2022-05-09 00:26:00 +01:00
5f80e344c3
Update day separator date text to right align against username
2022-05-09 00:15:08 +01:00
21e1f4546a
Fix popup dialog potentially not clicking last button when dismissed
2022-05-08 14:40:30 -07:00
bc839be4d8
Add failing rapid back button exit test
2022-05-08 14:40:29 -07:00
172d14bcc6
Improve code quality of mod column flow container
2022-05-08 11:40:14 -07:00
158f134260
Fix duration is negative while placing banana shower in catch editor.
...
Timeline blueprint is glitched when the hit object has negative duration.
Negative duration is unwanted anyways so placement implementation is fixed instead of supporting it in timline blueprint.
2022-05-09 00:01:05 +09:00
483a611c41
Fix BeginPlacement location.
2022-05-08 23:10:51 +09:00
d964b4f23c
Fix uneven spacing when some mod columns are hidden
2022-05-08 15:40:21 +02:00
6bdcf893b7
Move alpha management closer to screen level
...
Felt bad messing with alpha at the column level.
2022-05-08 15:40:10 +02:00
d8a4f9d37d
Update juice stream blueprint tests
...
No "clipping" occur anymore for vertex positions. Instead, clipping may occur when the path is converted to a slider.
Add tests for automatic slider velocity change.
2022-05-08 22:36:33 +09:00
7daa3d8eb7
Remove now-redundant velocity calculation
...
Velocity is computed from the up-to-date SV now.
2022-05-08 22:36:33 +09:00
37c9aac49f
Make ScrollingPath use time instead of distance.
...
This is consistent as other components now use time instead of distance.
2022-05-08 22:36:33 +09:00
670922c8e5
Use latest slider velocity for juice stream velocity computation.
...
This fixes one-frame glitch in editor when slider velocity is changed.
2022-05-08 22:36:33 +09:00
0e98bb28bd
Fix wrong resampling times are used for juice stream path
2022-05-08 22:36:33 +09:00
9ffa90602b
Automatically set slider velocity from juice stream path
2022-05-08 22:36:33 +09:00
4e0155fa4b
Make JuiceStreamPath time based instead of distance based.
...
And remove the "slope limit" feature.
TODO: for a juice stream with a large slope, the slider velocity of the hit object should be changed.
2022-05-08 22:36:33 +09:00
6f4cdccf6c
Remove no longer required constant
2022-05-08 16:20:26 +03:00
7f1ad149d5
Remove no longer necessary horizontal scroll blocker
2022-05-08 16:04:24 +03:00
298c2a1828
Replace vertical scrolling in results screen with size-preserving container
2022-05-08 16:03:57 +03:00
077c77d524
Add method for scaling results screen in tests
2022-05-08 16:00:07 +03:00
38c004d734
Add test coverage for hiding mod columns
2022-05-08 14:54:06 +02:00
92ccec20d7
Hide mod columns if all mods within are filtered out
2022-05-08 14:53:59 +02:00
dcf0d5a9d5
Fix slider velocity wrongly decoded as scrolling speed in osu!catch
2022-05-08 21:49:42 +09:00
569b73cf69
Merge pull request #18152 from peppy/scroll-mod-select-into-view
...
Scroll mod select slightly into view on first display
2022-05-08 13:58:16 +02:00
b8cb2c1b82
Increase scroll amount slightly
2022-05-08 19:57:03 +09:00
778497b9e2
Scroll mod select slightly into view on first display
2022-05-08 18:58:54 +09:00
aef5093e47
Merge pull request #18151 from bdach/mod-overlay/samples-playing-while-hidden
...
Fix mod panel samples playing when using autoplay shortcut
2022-05-08 18:45:52 +09:00
b92d95a17a
Fix mod panels playing samples when hidden at a higher level
2022-05-08 10:39:49 +02:00
81ca534f87
Implement ISamplePlaybackDisabler in mod select
2022-05-08 10:39:49 +02:00
cbd1169495
Move cache declarations of ISamplePlaybackDisabler to interface
2022-05-08 10:38:58 +02:00
9ae019eb39
Move ISamplePlaybackDisabler to more general namespace
2022-05-08 10:38:58 +02:00
4199bab1f1
Merge pull request #18145 from peppy/simplify-hide-logic
...
Simplify and centralise hiding logic for mod overlay
2022-05-08 10:26:57 +02:00
125628dd20
Fix hit object not shown in timline while placement is waiting
2022-05-08 15:52:14 +09:00
3eeedd8024
Fix per-hit object slider velocity ignored in osu!catch
2022-05-08 13:45:21 +09:00
230c4e27b8
Simplify and centralise hiding logic for mod overlay
...
Behaviourally, this also always toggles via button triggering to add the
button flash animation.
2022-05-08 13:03:28 +09:00
dabe295196
Merge pull request #18141 from bdach/mod-overlay/multiple-instance-loop
...
Fix toggling mods after exiting first run setup overlay at UI scale step causing stack overflow
2022-05-08 12:36:06 +09:00
8da7bbd322
Code quality
2022-05-07 23:30:46 +01:00
c0643cae75
Create ChatOverlayDaySeparator and use in ChatOverlayDrawableChannel
2022-05-07 23:24:34 +01:00
834e7b4323
Merge pull request #18142 from bdach/mod-overlay/skin-editor-breakage
...
Fix skin editor overlay showing behind mod select overlay
2022-05-08 00:30:31 +03:00
f4acfbd0df
Change return type of CreateDaySeparator to Drawable
2022-05-07 22:23:46 +01:00
bec28c5b28
Remove virtual ColourInfo properties from DaySeparator
2022-05-07 22:16:11 +01:00
a45ca2ad10
Fix focused overlays not registering as such
...
Also fixes bug wherein opening skin editor at song select with mod
select open would show mod select on top of the skin editor.
2022-05-07 22:50:14 +02:00
bdea6d8654
Add failing test for mod overlay not closing on entering skin editor
2022-05-07 22:47:19 +02:00
a3e61fddcb
Rename skin editor scene library test scene to be more general
2022-05-07 22:43:53 +02:00
836de49135
Adjust skin editor scene library test for extensibility
2022-05-07 22:43:47 +02:00
46d3220c07
Isolate sample screens from global mods bindable
...
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.
The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.
This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
3bb22dece6
Merge pull request #18111 from bdach/mod-overlay/integration
...
Replace old mod overlay with new design
2022-05-08 02:44:50 +09:00
2278da563e
Add various xmldoc for nested classes
2022-05-08 02:03:28 +09:00
03c80d9197
Reorder methods / properties in ModSelectScreen for legibility
2022-05-08 01:58:37 +09:00
1d27ef18dc
Add xmldoc for IsValidMod
2022-05-08 01:49:29 +09:00
