Commit Graph

213 Commits

Author SHA1 Message Date
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
f6f24220c2 Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs
This has been wrong from the outside, but hidden by the fact that the
default values are equal. I've changed to MD5Hash which actually asserts
that the correct beatmap has likely arrived.

Found this in my realm changes, where it fails due to the beatmap ID
being a differing Guid in each case.
2022-01-08 15:28:13 +09:00
b0d14526ea Move test ScoreInfo creation to TestResources
The main goal here is to remove the inheritance, since realm doesn't
like that. Unfortunate that we can't use object initialisers in a few of
these places, but no real way around that.
2021-12-13 16:34:50 +09:00
ea6766d940 Add failing test case 2021-12-04 17:13:43 +01:00
bbd3ea5b77 Update all actual usages of RulesetInfo.ID to use OnlineID instead 2021-11-24 15:50:26 +09:00
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
ed07ee8c61 Update all existing usages of AuthorString/AuthorId
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00
09f9731d74 Add temporary disable of failing r# inspection 2021-11-04 15:09:04 +09:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
aa0762ebe2 Add test coverage for failing slider case 2021-10-26 17:35:03 +09:00
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
281a3a0cea Add test case for legacy loop count behaviour 2021-10-02 18:40:41 +02:00
46bafb6252 Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-28 13:53:56 +09:00
cd181452be Add decoding support for SamplesMatchPlaybackRate 2021-09-12 16:45:27 +02:00
5f61936700 Update legacy encoder tests to only compare pieces we care about 2021-09-10 17:29:09 +09:00
1952ebece9 Update tests to use more correct control point definitions 2021-09-06 22:04:51 +09:00
8ffcea2e51 Remove unnecessary null checks 2021-09-06 21:32:43 +09:00
3c7a34bdbd Move mania-specific conversion to converter 2021-09-06 21:06:13 +09:00
b2a14b13dc Update outdated tests 2021-09-03 17:11:12 +09:00
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
071c56e90b Update usages of DifficultyPointAt 2021-09-03 16:58:16 +09:00
eb21ed08f8 Update test to only compare HitObjects 2021-08-31 14:51:14 +09:00
ce0d7cce2d Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info 2021-08-31 14:40:54 +09:00
a2cff75fc0 Fix editor not cloning control points as expected 2021-08-30 21:55:08 +09:00
2115d6f93e Add test coverage of legacy sample point recreation 2021-08-30 17:14:53 +09:00
ccacf56dd8 Move to legacy namespace 2021-08-30 17:14:53 +09:00
7257aae7f2 Move samples to LegacyControlPointInfo 2021-08-30 17:14:53 +09:00
4adfe9a6dc Add test coverage of double-convert stability 2021-08-30 15:30:04 +09:00
6dcd9427ac Remove bindable usage in PathControlPoint
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
a6c2cbd2e5 Add countdown settings to beatmap info model 2021-08-24 21:55:10 +02:00
6108451449 Retrieve separated skin instance from working beatmap for editing 2021-08-15 21:18:09 +02:00
399c3b0be8 Rename property, reword xmldoc and improve readability of update code 2021-07-21 17:32:56 +09:00
9d92b795fa Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead 2021-07-20 14:15:43 +03:00
554652b033 Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset 2021-07-20 10:11:52 +03:00
4f6de6fdc6 Implement GetSkin() for other working beatmaps 2021-05-21 20:21:29 +03:00
bf6e98345c Remove and update pre-existing test cases 2021-05-05 14:23:18 +03:00
400f8b3938 Add GetStream to IWorkingBeatmap
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
dd902441b0 Add tests for consecutive perfect-curve segments 2021-04-06 13:32:17 +02:00
9c1320e18b Add test 2021-04-06 14:34:26 +09:00
42e816fcae Add failing tests 2021-04-05 17:48:29 +09:00
d7e5a21213 Add failing test case 2021-01-31 15:43:58 +01:00
20d04d6933 Fix Storyboard's FirstEventTime not finding the true earliest event 2021-01-04 15:16:01 +09:00
cb7df0fe11 Add failing test for storyboard start time ordering 2021-01-04 15:15:23 +09:00
fed4accfea Update tests to refect new mappings 2020-10-30 12:12:30 +09:00
88ffcb9234 Update EndsWith usages 2020-10-16 12:58:34 +09:00
58194b4a31 Fix incorrect blank lines 2020-10-12 19:36:35 +09:00
36a8f61d26 Add failing test for implicit segments 2020-10-12 18:58:07 +09:00