59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
1d4d31e35c
Trim comments
...
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
27fabd99fb
Rename variables for legibility
...
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00
a45f0b65a1
Merge pull request #23372 from peppy/fix-slider-end-circle-appear-delay
...
Fix fade in delay for first slider end circle being incorrect when snaking disabled
2023-05-03 19:06:39 +02:00
d1d4b54c64
Simplified
2023-05-03 18:31:35 +02:00
fa3f42ba75
Merge pull request #23386 from peppy/fix-osu-logo-input-handling
...
Extend input handling of osu! logo to full border area
2023-05-03 17:48:51 +02:00
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
967e801f9c
code inspect
2023-05-03 23:26:58 +09:00
debbd376bd
move scrollContent update logic to updateActiveState()
2023-05-03 23:24:14 +09:00
f4b1264cc9
use button Enable status to ensure preset name is not null
2023-05-03 23:22:46 +09:00
aa5a026c67
remove local button handle
2023-05-03 23:14:24 +09:00
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
3a15783a3c
remove wait, use AddUntilStep
2023-05-03 22:59:01 +09:00
25bf4e68ec
remove useless wait
2023-05-03 22:53:13 +09:00
0ba31c5709
Merge pull request #23388 from peppy/fix-song-select-drawable-carousel-beatmap-leak
...
Fix runaway memory usage at song select when opening many beatmaps many times
2023-05-03 14:32:13 +02:00
be15d07b17
Tidy up various implementation details
2023-05-03 18:59:39 +09:00
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
b28d7b1a92
Fix non-block namespace
2023-05-03 18:51:02 +09:00
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
444f66b0ee
Move to base class for added safety
2023-05-03 18:46:30 +09:00
cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
5757eb7529
Update a few more instances of 0.96f scale constants
2023-05-03 18:20:12 +09:00
88135a3be8
Merge pull request #23384 from peppy/fix-incorrect-transform-thread
...
Fix potentially incorrect thread access in `OsuTabControlCheckbox`
2023-05-03 10:37:27 +02:00
ff28d941b3
Merge pull request #23385 from Joehuu/scroll-back-button-block-hover
...
Fix overlay scroll back button not absorbing hover from behind
2023-05-03 16:28:05 +09:00
de1b28bcb2
Fix incorrect initial state of checkbox
...
This only ever barely used to work without the `(..., true)`
in `master` because of haphazard operation ordering.
2023-05-03 09:27:23 +02:00
5f781bd6de
Move callback to LoadComplete()
...
Is the more correct place for `BindValueChanged()` callbacks.
2023-05-03 09:26:54 +02:00
29a943d514
Merge pull request #23383 from peppy/fix-multi-freemod-overlays-test-failure
...
Fix test failure in `MultiplayerMatchSongSelect` due to multiple overlays present
2023-05-03 09:09:41 +02:00
2add8e119f
Merge pull request #23379 from peppy/legacy-skin-reverse-arrow-colour-flip
...
Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
2023-05-03 08:48:32 +02:00
6a59ded1ba
Move logic to Update instead
2023-05-03 15:18:37 +09:00
4013cdcfa8
Merge branch 'master' into mania-fix-hold-note-rewind
2023-05-03 15:04:59 +09:00
453143813f
Extend input handling of osu! logo to full border area
...
This is the easiest way to make this happen. It does mean the pink area
is being drawn behind the white border, but I haven't found a scenario
where this is noticeable.
Closes #4217 .
2023-05-03 14:57:57 +09:00
1c74f6e8ea
Fix regressed button hover fade in
2023-05-02 22:54:42 -07:00
bede1292de
Fix overlay scroll back button not absorbing hover from behind
2023-05-02 22:40:37 -07:00
a3efae3690
Fix potentially incorrect thread access in OsuTabControlCheckbox
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829 .
2023-05-03 14:33:32 +09:00
384693a431
Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
f930c4bd0a
Move struct to bottom of file
2023-05-03 13:33:31 +09:00
48fd99818e
Split out default and sample application
2023-05-03 13:30:45 +09:00
cca15f930c
Refactor applyLegacyInfoAndDefaults for legibility
2023-05-03 13:26:50 +09:00
588a4e6196
Move pragma disable to top of LegacyBeatmapDecoder
...
Makes more sense as it's used multiple times in the class.
2023-05-03 13:19:14 +09:00
16c624fb61
Ensure static banana samples are not mutated
2023-05-03 13:02:37 +09:00
9c4312b407
Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
2023-05-03 12:37:07 +09:00
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
03459a4f19
Merge pull request #23371 from peppy/argon-slider-ball-fade-faster
...
Increase the rate of slider ball fade on argon skins to match other implementations
2023-05-02 19:03:47 +02:00
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
2023-05-02 18:45:45 +02:00
ec8362c6fc
Merge pull request #23367 from peppy/fix-uo-tooltip
...
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
48dd42407b
Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
...
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
1b565ab9e8
Merge pull request #21789 from mk56-spn/bubble_mod_implementation_clean
...
Add "bubble" mod to osu! ruleset
2023-05-02 19:52:32 +09:00
