Commit Graph

47958 Commits

Author SHA1 Message Date
797d3f5d65 Update framework 2022-01-11 15:09:51 +09:00
38c32d5c3f Merge branch 'master' into fix-most-common-beatlength 2022-01-11 14:49:00 +09:00
38a51b9ce0 Add comment 2022-01-11 13:54:12 +09:00
81fed4c6bf Use time=0 as for the first control point 2022-01-11 12:55:17 +09:00
a09563a7d9 Fix calculation of most common beat length for mania scroll speed 2022-01-11 11:00:30 +09:00
261b8ecad6 Merge pull request #16405 from smoogipoo/fix-pp-counter-underflow
Fix PP counter underflow with SpunOut mod
2022-01-11 10:55:47 +09:00
b88a65166e Fix pp counter underflow with SpunOut mod 2022-01-11 10:22:16 +09:00
90558f809f Merge branch 'master' into slider-snapping 2022-01-10 22:42:16 +09:00
e333831c45 Merge pull request #16371 from bdach/angle-of-rotation-display
Add tooltip with relative rotation in degrees to rotation handles
2022-01-10 22:19:50 +09:00
9756c0ab5c Merge pull request #16309 from peppy/async-deadlock-safety
Apply osu! side fixes for usage of `Task.Wait` and `Task.Result`
2022-01-10 16:39:33 +09:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
928023fabb Merge pull request #16362 from bdach/multiplayer-wrong-ruleset
Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset
2022-01-10 15:10:27 +09:00
5aaf5953f4 Merge pull request #16393 from peppy/detach-already-detached
Add mention to detach methods of only running once
2022-01-10 13:42:50 +09:00
c2843249e8 Merge pull request #16359 from peppy/fix-legacy-score-decoer-test
Fix `LegacyScoreDecoderTest` incorrectly comparing unset beatmap IDs
2022-01-10 13:10:58 +09:00
6f18db2136 Merge pull request #16390 from peppy/fix-filter-matching-tests
Update `FilterMatchingTest` and filter code to use ruleset's `OnlineID`
2022-01-10 13:10:51 +09:00
d072f1d08d Add mention to detach methods of only running once 2022-01-10 13:09:26 +09:00
3c3210e8ef Merge pull request #16389 from peppy/update-resources
Update resources
2022-01-10 12:47:25 +09:00
02d8a6359a Update FilterMatchingTest and filter code to use ruleset's OnlineID
The tests were relying on the `RulesetID` being set to 0 in the example
beatmap, even though the ruleset *instance* was set to ID 5.

This explicitly adds that 0 value to show intent, and also removes the
incorrect specification of 5 (which would cause the convert filter tests
to fail).

Also updates the filter code to use `OnlineID`, which is required in
realm changes.
2022-01-10 12:30:34 +09:00
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
ca162ed09a Update resources 2022-01-10 11:36:26 +09:00
ed992eed64 Merge pull request #16382 from bdach/rankings-table-inactive
Fade out inactive player rows on user ranking table
2022-01-10 00:30:06 +09:00
2e9ba40ae2 Add references to web implementation wrt property used 2022-01-09 14:46:15 +01:00
12c8243a9b Fade out inactive player rows on user ranking table 2022-01-09 14:42:26 +01:00
82d6639a3b Decouple rankings table test from online API 2022-01-09 14:42:19 +01:00
d76c674abc Add tooltip with relative rotation in degrees to rotation handles 2022-01-08 20:24:15 +01:00
24d377fddb Move implementation of drag handle operations to concrete classes 2022-01-08 20:24:00 +01:00
dcbeca2407 Merge pull request #16366 from bdach/fix-editor-text-box-precision
Fix effect point multiplier text box displaying too much decimal digits
2022-01-09 00:58:44 +09:00
9370e84460 Fix effect point multiplier text box displaying too much decimal digits 2022-01-08 16:12:52 +01:00
c5ac996e3f Restore ruleset using current playlist item on resuming room sub screen
Ensures that the ruleset selected at the multiplayer song selection
screen does not overwrite the current playlist item's ruleset.
2022-01-08 14:56:01 +01:00
446962446e Add test coverage for correct revert of mods when play starts at song select 2022-01-08 14:50:58 +01:00
3dd5705a81 Add test coverage for correct revert of mods after new item is queued 2022-01-08 14:50:58 +01:00
50077f05bd Add test coverage for correct revert of ruleset when play starts at song select 2022-01-08 14:50:57 +01:00
f026973b19 Add failing test for ruleset incorrectly applying from latest picked item 2022-01-08 14:50:54 +01:00
34135138b6 Merge pull request #16355 from bdach/scoreboard-time
Add basic "time ago" display to leaderboards on beatmap overlay
2022-01-08 17:11:43 +09:00
f6f24220c2 Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs
This has been wrong from the outside, but hidden by the fact that the
default values are equal. I've changed to MD5Hash which actually asserts
that the correct beatmap has likely arrived.

Found this in my realm changes, where it fails due to the beatmap ID
being a differing Guid in each case.
2022-01-08 15:28:13 +09:00
9e84e31eac Add score time to beatmap set overlay scoreboard table 2022-01-07 19:18:16 +01:00
87f7c7e691 Implement scoreboard-specific time formatting 2022-01-07 19:18:16 +01:00
881fa2b86b Add basic test scene for scoreboard time 2022-01-07 19:18:16 +01:00
c09f6ee052 Use slider snapping more liberally to match user expectations
Previously the slider path length would be snapped using the current
beat snap setting on *every* change of the slider path. As it turns out
this is unexpected behaviour in some situations (e.g. when reversing a
path, which is expected to preserve the previous duration, even though
the slider may be technically "unsnapped" at that point in time due to a
different beat snap setting being selected afterwards).
2022-01-07 16:02:04 +01:00
d2f44813dd Add test coverage for slider snapping when adding/removing control points 2022-01-07 15:47:02 +01:00
814b318a10 Add test coverage of slider end snapping behaviour 2022-01-07 15:47:02 +01:00
f440aadcbc Merge pull request #16341 from bdach/score-submission-test-failures
Fix intermittent failure in score submission test
2022-01-07 22:24:04 +09:00
398a67a4bc Merge pull request #16350 from peppy/fix-ipc-location-test
Fix `IPCLocationTest` not waiting for load of component
2022-01-07 22:22:45 +09:00
12c3e56881 Fix IPCLocationTest not waiting for load of component
As seen at
https://github.com/ppy/osu/runs/4731480384?check_suite_focus=true.
2022-01-07 19:01:06 +09:00
0698ef6330 Fix one missed rename 2022-01-07 17:36:29 +09:00
2ef791069c Fix typon on AdvancedStats 2022-01-07 17:33:38 +09:00
6a1e1d186f Update framework 2022-01-07 17:29:09 +09:00
3cd996eb4a Merge branch 'master' into async-deadlock-safety 2022-01-07 17:28:59 +09:00
bf328dc9e0 Merge pull request #16291 from peppy/fix-mods-mutated-outside-lease
Fix `MultiplayerMatchSubScreen` mutating mods outside of bindable lease
2022-01-07 17:12:12 +09:00
ee0a2ce54c Merge pull request #16347 from bdach/fix-toolbox-expand-button
Fix settings toolbox toggle button starting in incorrect state
2022-01-07 11:17:23 +09:00