4719fcc291
Actually use the cancellation token
2020-05-15 18:17:39 +09:00
98125102a7
Add cancellation token support to CreateNestedHitObjects()
2020-05-15 18:07:41 +09:00
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
848a3fb6d7
Take hitobject start/end times into account in drain
2020-05-11 19:06:36 +02:00
1d999bb634
Integrate PeriodTracker changes
2020-05-10 18:32:38 +02:00
ee2ff77b89
Merge branch 'master' into fix-draining-in-between-break-sections
2020-05-10 17:57:44 +02:00
44fdf1e6b0
Reword xmldoc
2020-05-10 20:09:41 +09:00
c712e98f2b
Merge branch 'master' into publicly-expose-hud
2020-05-10 20:06:28 +09:00
729585e151
Merge branch 'master' into mania-holdnote-selection-fix
2020-05-10 15:07:30 +09:00
2f12c4126a
Apply suggestions from code review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2020-05-10 13:49:08 +09:00
5c2778d5f0
Change comparison direction
2020-05-08 20:33:02 +09:00
be3b77cf25
Fix potentially skipping hitobject updates
2020-05-08 20:09:59 +09:00
22dda3fe02
Make ScrollingHitObjectContainer respond to defaults applied events
2020-05-08 18:49:58 +09:00
efff2bf15d
Add HitObject to DefaultsApplied event
2020-05-08 18:49:19 +09:00
a59db976d6
Fix loading a ruleset with a new version specification causing a crash
2020-05-08 18:05:06 +09:00
30dd158c33
Rename property to AllowGameplayOverlays and update XMLDoc accordingly.
2020-05-08 09:37:50 +02:00
83998d5ba5
Trim whitespace.
2020-05-07 09:39:14 +02:00
83be5455d3
Disable the display of HUD through DisplayHud property.
2020-05-07 08:52:36 +02:00
c8134162b5
Merge pull request #8934 from smoogipoo/sorcerer-catch-changes
...
Implement Sorcerer's osu!catch difficulty calculation adjustments
2020-05-06 18:10:33 +09:00
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
6d3a24ff01
Reorder tick hit results
2020-05-04 15:55:42 +09:00
f42be7a6d7
Merge branch 'master' into sorcerer-catch-changes
2020-05-04 15:25:09 +09:00
064e5004ed
Merge branch 'master' into fix-mania-selection
2020-04-29 17:15:48 +09:00
1aaab40228
Fix mods affecting mania scroll speed
2020-04-28 19:34:02 +09:00
da30eafa30
Prevent potential exception
2020-04-28 14:47:45 +09:00
86ef73aa27
Implement HitObjectContainer.Clear()
2020-04-23 11:16:59 +09:00
93151f7612
Add back necessary events + addition to list
2020-04-22 18:32:59 +09:00
8b0274fedd
Remove obsolete methods
2020-04-22 17:55:50 +09:00
07a73ba83c
Merge branch 'master' into rulesetstore-ruleset-dir
2020-04-22 10:23:04 +09:00
af32f51116
Merge pull request #8800 from iiSaLMaN/allow-cancelling-completion
...
Fix results screen pushed after rewinding in-between push delay
2020-04-21 12:49:49 +09:00
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
a541f92682
Resolve ruleset dependencies on game core / framework assemblies by checking already loaded assemblies in AppDomain.
2020-04-20 13:56:15 +02:00
a842f17630
Merge branch 'master' into taiko-drumroll-skinning
2020-04-20 20:48:41 +09:00
8ebc2ae03d
Never run subtree masking
2020-04-20 20:48:35 +09:00
6f233917b1
Centralize updating HasCompleted bindable logic
2020-04-20 06:40:51 +03:00
1dcb0f53a2
Fix whitespace formatting
2020-04-19 16:29:32 +02:00
ba1c465edf
Add comment in regards to the attaching of event handler to the assembly lookup event before call to loadUserRulesets().
2020-04-19 15:26:00 +02:00
a7179d1c87
Fix comment wording
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2020-04-19 15:15:04 +02:00
fc6c245de5
Replace all judged event logic with HasCompleted bindable
2020-04-19 05:36:04 +03:00
ae210d567d
Add temporary solution for tick hit/miss count
2020-04-16 18:16:08 +09:00
9dda7da489
Fix spinners being considered the "first object" for increased visibility in hidden
2020-04-16 14:11:38 +09:00
4eefe47ce3
Merge branch 'master' into fix-0-customsampleset
2020-04-16 11:20:31 +09:00
44981431c5
Remove suffix hackery
2020-04-14 21:33:32 +09:00
6935221463
Improve logic for CSB transfer
2020-04-14 21:05:07 +09:00
06407a1081
Merge branch 'master' into fix-classic-scoring
2020-04-14 02:13:45 +02:00
13c81db0cf
Fix incorrect classic score formula
...
Upon closer inspection the classic score formula was subtly wrong. The
version given in the wiki is:
Score = Hit Value + (Hit Value * ((Combo multiplier * Difficulty
multiplier * Mod multiplier) / 25))
The code previously used:
bonusScore + baseScore * ((1 + Math.Max(0, HighestCombo.Value - 1)
* scoreMultiplier) / 25);
which is not equivalent to the version on the wiki. The error is in the 1
factor, as in the above version it is being divided by 25, while it should
be outside the division to keep parity with the previous formula.
The tests attached in the previous commit demonstrate that this change
causes a single hit without combo to increase total score by its exact
numeric value.
2020-04-14 01:09:58 +02:00
63de493c85
Merge branch 'master' into fix-red-point-placement
2020-04-13 20:56:50 +09:00
58a7313091
Fix fallback for file hit samples
2020-04-13 20:09:17 +09:00
cee4b005e6
Fix custom sample set 0 not falling back to default samples
2020-04-13 20:00:06 +09:00
f38b64d201
Fix placement blueprints handling double clicks
2020-04-13 13:57:15 +09:00
