8de0d33c5a
Revert "Move collection change bind to LoadComplete"
...
This reverts commit d6d87e1975
2021-06-11 17:59:29 +03:00
b6947c25ec
Fix potentially adding the same skin multiple times
2021-06-11 17:55:07 +03:00
d6d87e1975
Move collection change bind to LoadComplete
...
Best practice anyways
2021-06-11 17:35:33 +03:00
108a3deb27
Also handle null Ruleset.CreateLegacySkinProvider values
...
Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point
2021-06-11 16:26:54 +03:00
f20146d446
Fix potentially adding null skin sources
2021-06-11 12:58:38 +03:00
e59beffc4e
Forward all base transformer lookup methods to Skin
2021-06-11 12:44:25 +03:00
9e16359f18
Refactor disallowing in SkinProvidingContainer to become per source
...
Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.
2021-06-11 12:29:29 +03:00
2e01e61177
Move TODO comment to correct location
2021-06-11 11:46:30 +03:00
8132852753
Add other affectable change action cases
2021-06-11 11:34:22 +03:00
a985e3b8d3
Apply documentation settings for better readability
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-06-11 11:25:07 +03:00
debd359d2e
Update xmldoc
2021-06-11 14:50:21 +09:00
b9050f91a4
Expose as Skins and consume SkinInfo from instances
2021-06-11 14:49:35 +09:00
2240e2c39c
Refrain from attempting to clear skin sources in disposal
...
`Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.
2021-06-10 17:23:16 +03:00
680791301f
Consume new method rather than caching skin sources on top of Player
2021-06-10 16:36:46 +03:00
23d6c366ac
Add method for assigning arbitrary skins to player in test scenes
2021-06-10 16:36:46 +03:00
ef2c4fd0d8
Make RulesetSkinProvidingContainer able to be overriden for testing purposes
2021-06-10 16:36:46 +03:00
09a2d008d2
Refrain from attempting to transform null skins
2021-06-10 16:36:45 +03:00
5c9c424a0d
Switch state case placements for consistency
...
Tickled me.
2021-06-10 13:15:18 +03:00
c3a2f2c2a4
Expose default SkinManager providers for use in RulesetSkinProvidingContainer
2021-06-10 13:07:32 +03:00
59be3588eb
Change SkinSources to a bindable list for binding SourceChanged events
2021-06-10 13:07:32 +03:00
dde84e5cbd
Merge branch 'master' into transformers-per-skin
2021-06-10 11:58:52 +03:00
58cca9da06
Revert "Expose the skin lookup layers of SkinManager to a property"
...
This reverts commit 9e652715ce
2021-06-10 11:57:28 +03:00
530026b675
Add simple xmldoc to ctors explaining their deal with SkinSources
2021-06-10 11:56:13 +03:00
18edbdd135
Remove mentioning of "layer" in skin providers
...
`SkinSources` sounds better.
2021-06-10 11:55:26 +03:00
3cd7d45b0f
Merge pull request #13401 from peppy/no-unranked-display
...
Remove the concept of "unranked" mods
2021-06-10 17:51:31 +09:00
a44fd887ee
Merge branch 'master' into no-unranked-display
2021-06-10 17:09:46 +09:00
479d6d3fc5
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-10 16:37:58 +09:00
4eab717a80
Merge pull request #13408 from peppy/default-skin-fallback
...
Add fallback lookup support for `DefaultSkin`
2021-06-10 16:37:48 +09:00
cc38556f61
Fix background being dimmed forever after toggling statistics in results screen
2021-06-09 23:26:57 -07:00
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
...
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
b55a4053cf
Merge pull request #13426 from gagahpangeran/wiki-image-title
...
Fix wiki image tooltips not showing inside table views
2021-06-10 14:28:49 +09:00
05cb935a94
change WikiMarkdownImage to extend OsuMarkdownImage
2021-06-10 09:38:48 +07:00
28d7b06908
create OsuMarkdownImage
2021-06-10 09:38:07 +07:00
e3f3c37953
Add ability to navigate score panels with left/right arrows
2021-06-09 17:03:46 -07:00
1aaad7bfd4
Apply few adjustments to skinning overlays comment
2021-06-09 22:49:31 +03:00
e30f6581b3
Wrap gameplay content within a RulesetSkinProvidingContainer
2021-06-09 22:49:31 +03:00
33a9cac398
Add special RulesetSkinProvidingContainer managing ruleset-compatible skin setup
2021-06-09 22:49:31 +03:00
9e652715ce
Expose the skin lookup layers of SkinManager to a property
2021-06-09 22:49:31 +03:00
6538d44708
Make SkinProvidingContainer able to perform lookup on multiple skins
...
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
209f658d05
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 20:22:00 +02:00
89cdea8123
Merge branch 'master' into fix-results-exit-transition
2021-06-09 19:40:56 +02:00
266c1e2e25
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 18:43:15 +02:00
222ae40a04
Merge branch 'master' into update-framework
2021-06-09 17:36:17 +02:00
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
f113c095ce
Update framework
2021-06-09 20:29:06 +09:00
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
0cf7c56e7e
Add fallback lookup support for DefaultSkin
2021-06-09 18:51:42 +09:00
2438c20d63
Fix SourceChanged not being correctly forwarded through LegacySkinTransformer
2021-06-09 17:56:07 +09:00
a65b76bdbf
Add a simple fade to the results screen
...
Stops it from immediately disappearing.
2021-06-09 17:19:37 +09:00
