Commit Graph

1045 Commits

Author SHA1 Message Date
b259708915 Merge branch 'master' into spun-out 2020-03-29 13:24:48 +09:00
d3114ca858 Don't snake when hit 2020-03-28 23:12:13 +02:00
fb4b334ce2 Add support for legacy skin sliderstartcircle / sliderstartcircleoverlay 2020-03-28 14:10:26 +09:00
3763457a1d Merge pull request #8451 from peppy/fix-slider-end-sounds
Only play slider end sounds if tracking
2020-03-27 20:38:59 +09:00
d36f5fb96f Fix animated follow points not (re)animating after rewind 2020-03-27 18:03:02 +09:00
f80efd10c2 Avoid using a miss judgement 2020-03-26 19:54:17 +09:00
6555ab6ede Only play slider end sounds if tracking 2020-03-26 17:18:27 +09:00
8e4896fbbe Make slider judgements count towards base score / accuracy 2020-03-26 17:13:53 +09:00
9ea0137b01 Merge branch 'master' into spun-out 2020-03-23 18:13:53 +08:00
19b6e496ef Fix (very) long spinners degrading in performance due to high transform count 2020-03-22 04:18:03 +09:00
d96f684077 Merge pull request #8358 from peppy/remove-slider-implicit-judgement
Remove slider implicit judgement
2020-03-20 01:13:58 +09:00
6b482c057a Merge pull request #8362 from peppy/fix-slidertick-judgement-accuracy
Fix slider ticks/repeats contributing to accuracy
2020-03-20 01:13:49 +09:00
12a48d2774 Cause all earlier hitobjects to get missed 2020-03-19 19:16:24 +09:00
0c1f385d5a Add OsuIgnoreJudgement to get correct result type 2020-03-19 18:19:10 +09:00
114b46c4f0 Change slider tail to give repeat judgement; slider itself to give none (managed by head already) 2020-03-19 15:01:14 +09:00
08b5ab8ec4 SliderRepeatPoint -> SliderRepeat 2020-03-19 14:42:02 +09:00
94c3ffb6e5 Fix slider ticks contributing to accuracy 2020-03-19 14:36:15 +09:00
1c0c269852 Reduce allocations of followpoints by reusing existing 2020-03-19 00:34:24 +09:00
1d680b7a00 Better english
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2020-03-18 19:13:25 +09:00
210e5c672f Merge branch 'master' into add-notelock 2020-03-18 16:24:31 +09:00
d6be8eec0c Merge branch 'master' into click-disabled-difficulty-icons 2020-03-16 11:30:57 +09:00
c271d17557 Remove useless field 2020-03-14 14:07:52 +03:00
74c9d5fc93 Use AccentColour 2020-03-14 13:45:55 +03:00
7e9d28b1b1 Fix slider ball colour affects follow circle 2020-03-13 13:42:33 +03:00
ed837d3115 Use framework extension method for FromHex 2020-03-11 10:18:41 +09:00
742698acab Add notelock implementation 2020-03-10 15:30:24 +09:00
77fd748035 Fix incorrect circle piece hitbox
Hitboxes of circle pieces in osu! have regressed with commit 8592335.
The reason for the regression was that hit detection was moved from
DrawableHitCircle itself to a newly-introduced private HitArea class
(now named HitReceptor).

As HitArea inherited from Drawable, it would return IsHovered == true
over its entire bounding box. This meant that the hit area could wrongly
pick up actions that are not within circle radius and make them into
hits.

To resolve, make HitReceptor a CompositeDrawable and set its corner
radius to match the circle piece. This fixes the invalid hitbox, as
IsHovered takes radius into account.
2020-03-06 21:21:20 +01:00
cf88e3ff19 Merge branch 'master' into spun-out 2020-03-04 17:38:35 +08:00
5e218697c5 Use stacked positions 2020-03-04 09:46:53 +09:00
900882610d Merge branch 'master' into expand-number-piece-on-old-skins 2020-03-02 16:40:59 +09:00
ff063b229b Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
e6cfafffe9 Fix incorrect LifetimeStart and add todo regarding Expire usage 2020-02-24 12:24:15 +09:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
090d9d9350 Make FollowPointRenderer a LifetimeManagementContainer 2020-02-23 04:37:04 +09:00
cb9a7ee0bb Give FollowPointConnections a valid lifetime 2020-02-23 04:36:50 +09:00
00b4fc1e1f Add fill to default skin slider ball when tracking 2020-02-21 17:38:23 +09:00
958c891d15 Update with framework-side bindable list changes 2020-02-17 15:06:14 +09:00
9aa5db88d4 move auto fade in to mod 2020-02-10 14:14:04 +08:00
68873830aa make spm counter show up automatically with spun out 2020-02-09 13:49:08 +08:00
d314b38699 rename trackable to enabled and cleanup code 2020-02-09 13:46:06 +08:00
8d480c794a Merge branch 'master' into spun-out 2020-02-08 13:54:39 +08:00
efa95ecebb fix spinner unspinnable 2020-02-08 10:52:59 +08:00
4d9232a895 Move autospin logic to mods 2020-02-08 09:51:32 +08:00
25a930c438 Implement OsuModSpunOut 2020-02-08 08:59:35 +08:00
6297606baa Make sMake spinner's EndTime correct on construction 2020-02-07 19:08:37 +09:00
daf5fa9da4 Throw NotSupportedException instead 2020-02-06 13:16:32 +09:00
cd6902a312 Make EndTime and RepeatCount settable 2020-02-05 17:52:51 +09:00
9f79713fb3 move rotation logic to its own method 2020-02-05 14:23:59 +08:00
d773eb2c22 refactor rotation logic to use explicit delta value 2020-02-05 14:05:12 +08:00
84fcf45aae Make slider tracking match what is on screen 2020-02-03 11:55:14 +09:00