70ed347b06
simplify helper methods
2022-07-28 15:19:35 +08:00
2b9d46d803
Remove unused RulesetStore from BeatmapManager constructor
2022-07-28 16:19:05 +09:00
db62d4be3a
apply suggestions
...
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
6bf293e130
Fix managed object reused between test runs
2022-07-28 15:45:33 +09:00
8ac886a247
Update test to account for sort order
2022-07-28 15:20:25 +09:00
67c44552cb
Add realm Refresh calls to ensure tests are stable
2022-07-28 15:18:04 +09:00
485d140a21
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 15:15:41 +09:00
2ae5a34c0e
Add test coverage of beatmap updates transferring collection hashes
2022-07-28 15:02:58 +09:00
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
34a2d1a6e1
Fix ManageCollectionsDialog and remove weird placeholder logic
2022-07-28 13:57:21 +09:00
67c7f324ee
Simplify CollectionFilterDropdown filter flow weirdness
2022-07-28 13:57:21 +09:00
0913cf013c
Split out tests and fix variable conflict
2022-07-28 13:24:14 +09:00
aa65b73f19
Merge branch 'master' into add-notif-externalbutton
2022-07-28 12:17:36 +09:00
8da499fb0f
Add proper test coverage
2022-07-28 12:16:21 +09:00
9088caa377
move LegacyComboCounter to osu.Game.Skinning
2022-07-28 08:36:26 +08:00
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
6af6f03e29
refactor song progress test scene
2022-07-27 15:57:47 +08:00
1e013bd4e9
move song progress graph to its own test scene
2022-07-27 15:57:23 +08:00
494486ad09
Fix potential test failure if scores are added to the beatmap which is subsequently removed
2022-07-27 16:27:10 +09:00
37e642b0bd
make SongProgress abstract
...
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
2022-07-27 15:19:21 +08:00
6b73f7c7ec
Split out legacy import path from realm manager
2022-07-27 15:04:09 +09:00
8f7dff5c2c
Merge pull request #19378 from peppy/beatmap-update-test
...
Add separate beatmap update flow to handle edge cases better
2022-07-26 18:49:20 +09:00
6ff44ed2c6
Merge pull request #19399 from frenzibyte/carousel-order-stability
...
Maintain sort stability by using carousel item ID as a fallback
2022-07-26 17:33:30 +09:00
7f75184a01
Merge branch 'master' into beatmap-update-test
2022-07-26 17:27:36 +09:00
ee694c1257
Add test coverage of no online ID scenario
2022-07-26 17:27:23 +09:00
1221cb1a42
Add comprehensive test coverage of update scenarios
2022-07-26 17:22:52 +09:00
28e81b7c32
Merge pull request #19392 from peppy/fix-test-leftovers
...
Avoid leaving left-over files after test run completes
2022-07-26 16:33:14 +09:00
846291d203
Refactor new tests to not suck as much as the old importer tests
2022-07-26 16:33:00 +09:00
91ffa7007f
Improve existing test coverage to cover order changes from other sort modes
2022-07-26 10:24:51 +03:00
8370ca9765
Add ImportAsUpdate method to IModelImporter to avoid otehr changes
2022-07-26 15:49:04 +09:00
4efe09e7c2
Merge pull request #19377 from frenzibyte/fix-timeline-tests
...
Fix intermittent timeline zoom test failures
2022-07-26 15:18:35 +09:00
ac553d22ea
Fix left over resource file which isn't actually imported
2022-07-26 15:08:18 +09:00
59d3cc52c4
Avoid leaving left-over files after test run completes
2022-07-26 15:08:18 +09:00
7d8a78ef01
Move tests to own class
2022-07-26 14:53:20 +09:00
ef10145d6f
Rename MenuCursorContainer and clean up code
2022-07-26 14:11:52 +09:00
e5355f314d
Use longer hash string
2022-07-25 15:19:32 +03:00
9c411c2250
Fix test nullability assertions
2022-07-25 20:06:37 +09:00
92dd1bcddb
Add test coverage of actual update flow
2022-07-25 19:51:19 +09:00
2e14d8730c
Move implementation of updating a beatmap to BeatmapImporter
2022-07-25 19:51:19 +09:00
6a3e8e31de
Centralise calls to reset online info of a BeatmapInfo
2022-07-25 19:51:19 +09:00
ec477a3ebf
Add basic coverage of current behaviour of beatmap reimport
2022-07-25 19:51:19 +09:00
1b6ebcfd87
Remove SubmittableScore and replace with SoloScoreInfo extension method
2022-07-25 13:43:43 +03:00
d04df19c7e
Remove APIScore and replace its final usage
2022-07-25 13:13:46 +03:00
068063a43a
Merge pull request #19371 from peppy/fix-working-cache-invalidation
...
Fix calls to `GetWorkingBeatmap` invalidating cache too often
2022-07-25 18:29:46 +09:00
1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display
...
Fix star ratings which are still being calculated showing as "-1" at song select
2022-07-25 18:20:30 +09:00
bc2b629ee7
Let tests wait until track load before testing zoom
2022-07-25 12:07:50 +03:00
123930306b
Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
2022-07-25 12:07:50 +03:00
93175eaf6e
Re-enable timeline zoom test and remove flaky attribute
2022-07-25 11:39:23 +03:00
