Commit Graph

972 Commits

Author SHA1 Message Date
ac8fb4f9b2 Fix beatmap cards still potentially showing twice in listing 2022-11-04 03:23:34 +03:00
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
b3219526a5 Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo() 2022-10-28 14:42:45 +09:00
dcff8a193c Use better method of forcing serialisation 2022-10-28 01:26:10 +09:00
3c4ba6e9fc Fix SoloScoreInfo.Rank not being serialised if rank is D 2022-10-27 19:02:32 +09:00
af84f708b7 Avoid serialising some more properties of SoloScoreInfo unless present 2022-10-21 19:30:35 +09:00
e1785f73a2 Make report's comment not optional 2022-10-16 20:14:05 +03:00
7251d41deb Add request class 2022-10-14 16:15:28 +03:00
7645fe20f5 Merge branch 'master' into comment-deletion 2022-09-28 17:55:22 +03:00
58d9509ce6 Apply NRT to Comment 2022-09-27 22:45:05 +03:00
5282c8b8c6 Fix CQ 2022-09-27 19:40:18 +03:00
5da7cb5397 Make comment ID public for test 2022-09-27 19:02:18 +03:00
1721b8e47a Add request class 2022-09-27 16:25:26 +03:00
1811647e34 Make room requests handler handle GetBeatmapRequest 2022-09-27 20:30:41 +09:00
de6709d12c Fix rank_history serialisation order dependence
```csharp
[network] 2022-09-26 18:18:39 [verbose]: Processing response from https://dev.ppy.sh/api/v2/me/ failed with Newtonsoft.Json.JsonSerializationException: Error setting value to 'rankHistory' on 'osu.Game.Online.API.Requests.Responses.APIUser'.
[network] 2022-09-26 18:18:39 [verbose]: ---> System.NullReferenceException: Object reference not set to an instance of an object.
[network] 2022-09-26 18:18:39 [verbose]: at osu.Game.Online.API.Requests.Responses.APIUser.set_rankHistory(APIRankHistory
value) in /tmp/osu/osu.Game/Online/API/Requests/Responses/APIUser.cs:line 231
```
2022-09-27 12:46:17 +09:00
9a10ecb378 Clarify purpose of APIUserScoreAggregate 2022-09-17 19:37:30 +03:00
581a4d2d6d Use APIBeatmap for realm migration requiring ShortName mapping 2022-09-15 16:58:58 +09:00
1398a7e11e Property should accept the nullable state. 2022-09-10 10:46:40 +08:00
ba2ef424d4 Turn score ids into ulongs 2022-09-09 11:46:06 +09:00
b10026993a Don't serialise has_replay 2022-09-02 16:41:53 +09:00
a277431266 Add has_replay and legacy_score_id to SoloScoreInfo 2022-09-01 21:10:38 +09:00
799c015bff Add LegacyTotalScore to SoloScoreInfo 2022-08-30 15:50:19 +09:00
f70af779a4 Add maximum statistics to ScoreInfo/SoloScoreInfo 2022-08-24 17:28:41 +09:00
a1e849c4db Ensure that DummyAPIAccess runs all queued tasks on disposal 2022-08-20 16:22:35 +09:00
865d63f768 Refactor APIAccess main loop to read better 2022-08-11 15:43:39 +09:00
47196b19a5 Stop setting Online state in handleRequest
This is already handled amicably by the `Failing` -> `Connecting` flow.
Having this set in `handleRequest` throws things off, potentially
leading to the `Online` state change before the user has been populated.
2022-08-11 14:36:30 +09:00
7ec67c28b9 Set Online state sooner in connection process
This isn't really required as such, but feels more correct. There was no
reason for it to wait for the friend population to complete before
deeming things to be "online".
2022-08-11 14:35:56 +09:00
e5b534bb26 Add thread safety to APIAccess.LocalUser 2022-08-11 12:45:26 +09:00
4a312d5658 Use a placeholder user with the correct username during connecting process
This allows for various components (like gameplay) to obtain a correct
username even if the API is not yet in a connected state. The most
common case is during startup, where a connection may not have been
established yet, but the user's username was restored from their config
file.

By making the change, local scores will now have the correct username
(although avatar etc. will be missing, which I think it fine) even if
the API is not yet connected. Previously, they would show up as "Guest".
2022-08-09 17:13:09 +09:00
f9d0cc3c4e Change APIAccess.IsLoggedIn to also return true when connecting
All usages of this are made with the intention of showing data when an
api is going to eventually become available. In the case of a login
failure, components are also able to display a correct state.

With this change, it makes online components display in a more correct
state during startup or initial logging in phase.
2022-08-09 17:11:44 +09:00
0537c471dc Merge pull request #19582 from smoogipoo/apimod-json-cleanup
Don't serialise empty mod settings
2022-08-08 11:49:08 +09:00
0de00e9b3f Don't serialise empty mod settings 2022-08-05 14:00:53 +09:00
2d9da07eb6 Trim zero values from hit statistics 2022-08-04 19:27:50 +09:00
8ff7770a71 Omit irrelevant data from SoloScoreInfo serialisation 2022-08-04 19:11:39 +09:00
1b6ebcfd87 Remove SubmittableScore and replace with SoloScoreInfo extension method 2022-07-25 13:43:43 +03:00
d04df19c7e Remove APIScore and replace its final usage 2022-07-25 13:13:46 +03:00
62133fa069 Merge pull request #19246 from frenzibyte/fix-wiki-navigation
Fix wiki overlay not handling path redirection properly
2022-07-20 20:08:11 +09:00
e7f35701db Add failing test case 2022-07-20 09:06:11 +03:00
07874efa7f Set last online update to actual value provided by data source 2022-07-19 19:39:51 +09:00
2716bd41d9 Use more correct json casing in APIScoresCollection
osu-web API is already returning both of these casings for backwards
compatibility, but the former will be removed at some point.

e540276721/app/Http/Controllers/BeatmapsController.php (L314-L315)
2022-07-19 15:34:17 +09:00
6f37487528 Replace calls to defective Humanizer methods with correct version 2022-07-18 22:34:58 +02:00
2befcfedbb Merge branch 'master' into fix-multiplayer-participant-panel-null-ruleset 2022-07-18 12:24:47 +03:00
b5c7d07ba8 Merge branch 'master' into fix-user-profile-overlay 2022-07-18 10:27:33 +03:00
a7f19cc796 Merge pull request #19137 from frenzibyte/country-enum
Replace `Country` class with enumeration
2022-07-18 16:12:24 +09:00
84c1c26a7f Merge branch 'master' into fix-user-profile-overlay 2022-07-18 09:45:25 +03:00
21bf7ee448 Turn on nullability in ParticipantPanel 2022-07-18 15:27:55 +09:00
018da74fe8 Replace default with CountryCode.Unknown 2022-07-18 08:54:35 +03:00
05d692bd55 Move Country to end of class 2022-07-18 08:43:41 +03:00
566bad0b5f Make SoloScoreInfo.EndedAt non-null
Seems to already be the case for databased scores. Will be assured by
https://github.com/ppy/osu-web/issues/9116.

I've updated the `osu-score-statistics-processor` with this
consideration.
2022-07-18 14:42:43 +09:00
ef6e16b1cb UserCountry -> Country 2022-07-18 08:40:43 +03:00