Commit Graph

56765 Commits

Author SHA1 Message Date
fc8835d43a Fix migration failing on single file copy failure
No longer throw if copying of single files fails during data migration.

Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).

If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).

Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.
2022-08-01 15:02:39 +09:00
5335d60748 Merge pull request #19407 from andy840119/remove-nullable-disable-in-the-mods-for-osu-ruleset
Remove nullable disable annotation in mods for osu ruleset.
2022-08-01 14:51:48 +09:00
8ee4f1e60b Merge pull request #19510 from bdach/mod-overlay/presets-persistence
Add persistence of mod presets to realm
2022-08-01 14:43:52 +09:00
a5f48e336a Isolate development builds' storage from release builds 2022-08-01 14:38:02 +09:00
3b6349a145 Add test coverage of remaining components which weren't already included 2022-08-01 14:16:26 +09:00
d112743cea Improve test coverage of skin serialisation to ensure full coverage
Will fail when new skinnable components are added until they have
coverage in resources.
2022-08-01 14:04:12 +09:00
5b98a73edc Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components 2022-08-01 14:04:08 +09:00
415d6def2d Remove unnecessary AsNonNull() 2022-08-01 13:22:58 +09:00
195396309a Merge pull request #19507 from naipofo/playlist-capture-fix
Prevent capturing arrow keys on playlist creation.
2022-08-01 11:46:00 +09:00
85f77abee1 Fix code quality inspection about ambiguous equality 2022-07-31 23:53:46 +02:00
5a34122a85 Fix test breakage after realm migration 2022-07-31 23:53:46 +02:00
9d3cdae4bb Fix test scene to handle restarts properly 2022-07-31 23:53:46 +02:00
9dea8e3d12 Add test coverage of preset soft deletion 2022-07-31 23:53:46 +02:00
c837848238 Add extended test coverage of preset realm subscription 2022-07-31 23:53:45 +02:00
345f103119 Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
fa3b9ee32f remove unneded guard 2022-07-31 23:42:20 +02:00
cbabc4886c Convert ModPreset to realm object 2022-07-31 22:10:15 +02:00
98214beb6c Prevent overflow on beatmap info using scrollable container 2022-07-31 21:24:41 +02:00
57b43e0065 Stop capturing arrow keys on Playlist 2022-07-31 19:12:29 +02:00
f9f9b65c86 Add test coverage of deserialisation skin layouts 2022-08-01 01:14:05 +09:00
db4c6aa3d3 Add test skin layout json resources 2022-08-01 01:13:47 +09:00
5dd641bc60 Remove the nullable disable annotation in the test project. 2022-07-31 22:02:07 +08:00
094793bbe3 Mark the GetTrack() return type as nullable. 2022-07-31 22:01:30 +08:00
6c964dee30 Rename the nullable disable annotation in the Audio namespace and mark some properties as nullable. 2022-07-31 22:00:14 +08:00
632577389d Mark the property as non-nullable. 2022-07-31 21:43:16 +08:00
89855cc1d6 Change KPS Counter implementation base and add better replay integration
The counter implementaiton is now list based, and will not invalidate
previous hits by removing them but by testing if they are within the 1
second span, allowing better integration with replays and spectators.
2022-07-31 01:29:57 +02:00
998e3b74d6 Merge pull request #19481 from peppy/fix-skin-migration
Fix previous skins not loading due to namespace changes
2022-07-30 21:56:28 +03:00
93b783d9ea Fix previous skins not loading due to namespace changes 2022-07-31 03:25:38 +09:00
faefda9143 Fix song select not updating selected beatmap card on editor resume 2022-07-30 19:47:42 +03:00
498c796c81 Merge pull request #19478 from peppy/fix-collection-migration
Fix collection migration potentially deleting the database before finishing migration
2022-07-30 19:44:22 +03:00
6ad86ce5b7 Run collection import process asynchronously
Actually required to avoid deadlocking..
2022-07-31 01:06:57 +09:00
80ffa2cf20 Move collection database rather than deleting post-migration for safety 2022-07-31 00:54:00 +09:00
8e06d55960 Fix collection migration incorrectly running asynchronously 2022-07-31 00:53:39 +09:00
b95aff3e5f Add failing test case 2022-07-30 18:50:41 +03:00
471a06883a Merge pull request #19471 from Susko3/desktop-BatteryInfo
Add battery info / low battery warning for desktop platforms
2022-07-30 18:15:51 +03:00
e5118130db Add 'SDL' acronym 2022-07-30 16:05:35 +02:00
38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
43e612f6d4 Merge pull request #19455 from peppy/confirm-playlist-discard
Add confirmation dialog when about to discard a playlist
2022-07-30 19:17:49 +09:00
8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
ecf7cc77dd Merge pull request #19469 from frenzibyte/fix-dodgy-tests
Fix potential nullref in `TestSceneAutoplay` check steps method
2022-07-30 16:46:51 +09:00
ec1a7994cc Switch method to statement body for better readability
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
0c125db197 Fix potential nullref on TestSceneAutoplay check steps 2022-07-30 10:11:01 +03:00
b32ff68a95 Enable NRT on taiko legacy skin transformer and tests 2022-07-30 09:43:51 +03:00
40858c4cb7 Adjust existing test coverage 2022-07-30 09:32:39 +03:00
0940e703b3 Fix normal skin hitsounds prioritised over default taiko hitsounds 2022-07-30 09:15:28 +03:00
d590219779 Merge pull request #19466 from naipofo/taiko-flashlight-fix
Fix osu!taiko flashlight positioned incorrectly on gameplay restart
2022-07-29 22:05:52 +03:00
1e90ea9e77 Merge branch 'master' into taiko-flashlight-fix 2022-07-29 21:32:35 +03:00
8d1f7970a3 Merge pull request #19465 from peppy/update-framework
Update framework
2022-07-29 21:32:25 +03:00
e0107fc3dc Use RequiredParentSizeToFit to handle misc geometry changes 2022-07-29 21:11:43 +03:00