a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
6e6421caea
Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
4ec46c7476
Merge branch 'master' into footer_V2_implementation
2023-02-03 16:30:16 +09:00
a1200b8fe8
Adjust footer button colour handling to read better and take into account mouse down
2023-02-03 16:27:20 +09:00
f5d579144b
Remove free mods button
2023-01-30 12:57:24 +01:00
bc94f1b773
add free mods button to test
2023-01-23 16:43:38 +01:00
f0464b0340
Actually fix intermittent failure in beatmap options state test
2023-01-19 22:47:35 +03:00
3b27774561
Remove OnlineID sort consideration
2023-01-18 19:21:02 +09:00
92fc439f82
Add test coverage of carousel sort expectations
...
This covers the fail case of removing and adding items (see
https://github.com/ppy/osu/issues/21926 ) but also covers the proposed
forward implementation, which now considers `DateAdded` and `OnlineID`.
2023-01-17 16:40:25 +09:00
1552726150
Fix intermittent failure in beatmap options state test
2023-01-16 14:06:02 +03:00
e6ff262521
Fix potential nullref in certain beatmap carousel tests
2023-01-13 19:42:09 +03:00
69260ca3c3
remove unnecessary usages of nullable forgiveness, add asserts for debugging
2023-01-09 18:36:55 +01:00
a32c4a64e7
Fix errors in test
2023-01-08 19:18:28 +01:00
47fb467012
Remove nullable disabling in carousel
2023-01-08 19:02:48 +01:00
877413524f
Cherry-picked android changes from #17462
2022-12-19 15:46:54 +09:00
c5bad816db
Add button colouring whilst corresponding overlay is present
2022-12-02 18:44:21 +01:00
d7cea51551
Add functionality of Random button
2022-12-01 16:29:52 +01:00
1530495e7c
Add button "accent" colour, bottom bar, icon, text
2022-12-01 15:34:09 +01:00
774eb178a1
Add basic button design and footer button addition flow
2022-12-01 13:13:37 +01:00
18b4317e99
Create Basic V2 footer and test
2022-12-01 11:57:50 +01:00
0aba119056
Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
# osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
92ed2ed4ef
Refactor star "DifficultyRangeFilterControl" into generic range slider class
2022-11-26 12:19:08 +01:00
b3667821eb
Add failing test case
2022-11-20 10:07:32 +01:00
039ab83a46
Disable beatmap options button when none selected
2022-11-17 04:00:23 +03:00
0e46614c57
Revert beatmap option button state changes
2022-11-17 03:57:01 +03:00
46c7451ede
remove redundant code
2022-11-16 09:57:23 +08:00
9101ad0cbd
fixed naming
2022-11-16 09:42:40 +08:00
7aec5ca1e8
visual tests
2022-11-15 20:57:42 +08:00
20dd405c2b
Merge branch 'master' into maintain-common-mod-selection
2022-11-03 15:32:40 +09:00
b95091fbb0
Move test to improve diff readability
2022-10-24 22:55:09 +03:00
9def12c60b
Write new tests
2022-10-24 22:50:56 +03:00
841e20c336
Remove unused usings
2022-10-15 17:16:08 +03:00
7d53d35bf6
Remove duplicate & outdated test case
2022-10-15 16:23:54 +03:00
df66a0c2e9
Fix flaky update beatmap set test
...
It is generally not possible to click a button that's not yet there,
and it turns out that when the test in question is ran headless, it may
not necessarily be there immediately.
2022-10-13 21:03:52 +02:00
7db7bcc283
Add test coverage
2022-10-13 02:40:20 +03:00
a1297af441
Apply NRT to base Leaderboard classes
2022-09-26 16:12:47 +09:00
a6f68e4a90
Fix NRT inspections
2022-09-13 03:08:13 +03:00
ae53e27e6c
Adjust test coverage to read better
2022-09-09 19:39:06 +03:00
dd10a06e3d
Merge branch 'master' into top-rank-badge-order
2022-09-09 19:38:44 +03:00
3d9bf25c8a
Apply NRT to TestScenePlaySongSelect
...
Very mess.
2022-09-08 14:49:57 +09:00
b50116e9e4
Add missing null check in BeatmapCarousel tests
2022-09-07 16:22:11 +09:00
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
148e487c02
Add failing test of date submitted search failing
2022-09-01 19:59:27 +09:00
82b9e1f0eb
Merge pull request #20011 from smoogipoo/scoring-refactor
...
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
e8ae6840ea
Add test coverage of selection being retained
2022-08-29 15:23:34 +09:00
