552ec5282f
Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo
...
A lot of tests are using test resources that populate the length field,
but do not populate hitobjects. The general expectation is that
components should be using the cached length in cases where hitobjects
are not relevant, but `GetVirtualTrack` was doing its own local
calculation.
This could cause tests to fail due to `MusicController` changing track
in the background.
2022-04-06 14:51:15 +09:00
32e55e7d78
Merge branch 'master' into osu-diff-calc-max-combo
2022-03-31 15:08:08 +09:00
478174dd58
Merge pull request #17416 from peppy/skin-fuck
...
Refactor skin construction
2022-03-25 15:36:06 +09:00
a7554dcdf7
Use a constant for the early version timing offset
2022-03-24 16:43:41 +09:00
a7f63fb034
Make providing a custom ResourceStore to LegacyBeatmapSkin optional (for tests only)
2022-03-23 14:57:42 +09:00
b9859f9f21
Obsolete BeatmapInfo.MaxCombo and suppress in usages
2022-03-20 16:30:29 +03:00
c2063f415d
Remove unnecessary MaxCombo migration between unmapped database fields
2022-03-20 16:27:54 +03:00
c5cc7eec79
Add explicit todo about removing BeatmapInfo.MaxCombo
...
Using that property is a trap basically.
2022-03-20 05:38:14 +03:00
e1610b5d32
Merge branch 'master' into ruleset-leaderboard-unavailable
2022-03-03 22:52:20 +01:00
42e07b7308
Convert to extension method to avoid recursive calls
2022-03-03 14:15:37 +09:00
fab9323707
Replace all legacy ruleset checks with a helper property call
2022-03-03 14:08:48 +09:00
acf8db13ac
Store user settings to realm
2022-03-01 18:44:15 +09:00
d0c01afc2e
Add flow for changing set of valid divisors between presets
2022-02-27 15:37:51 +01:00
c869be87d1
Update FlatFileWorkingBeatmap to not require a ruleset store
2022-02-19 20:53:04 +09:00
567da9214e
Merge branch 'master' into osu-diff-calc-max-combo
2022-02-18 18:35:24 +09:00
a029e418cf
Use internal instead of protected internal
2022-02-18 17:06:04 +09:00
cf1dd1ebd3
Disallow registering a null RulesetStore
2022-02-18 16:52:34 +09:00
420e2c538f
Automatically use an AssemblyRulesetStore if no custom store is registered
2022-02-18 16:52:34 +09:00
631c23ea3a
Merge branch 'master' into beatmap-decoder-ruleset-store
2022-02-18 16:52:33 +09:00
8a08bb7aaf
Use best-name-finding helper in new difficulty creation flow
2022-02-17 00:28:18 +01:00
5477af08c5
Register an AssemblyRulesetStore in tests which don't use OsuGameBase
2022-02-16 17:21:57 +09:00
13086541f0
Add static RulesetStore to LegacyBeatmapDecoder
2022-02-16 17:13:54 +09:00
3d3f0a89c2
Remove legacy RulesetID property from BeatmapInfo
2022-02-16 16:46:53 +09:00
215da7e933
Reimplement as extension method on IBeatmap
...
Implementation has changed slightly to support arbitrary levels of
nested hitobjects.
2022-02-16 12:06:49 +09:00
e45a2ae0fc
Restructure difficulty copy flow to adapt to latest changes
2022-02-14 22:02:37 +01:00
6221447164
Append copy suffix on creating copy of difficulty
2022-02-14 20:19:12 +01:00
40cfee3421
Explicitly reset online ID and beatmap status on copy
2022-02-14 19:54:40 +01:00
7e75fa7117
Revert "Change BeatmapInfo copy logic to be opt-in rather than opt-out"
...
This reverts commit 5dabc9282c
2022-02-14 19:52:08 +01:00
5dabc9282c
Change BeatmapInfo copy logic to be opt-in rather than opt-out
2022-02-13 19:04:11 +01:00
ecd6a68c6f
Clear hash when creating copy of existing difficulty
2022-02-13 14:01:23 +01:00
6fd663a718
Apply some renames to convey difference between creation options better
2022-02-13 14:01:23 +01:00
a144d6f8d6
Fix beatmap skin properties not copying
2022-02-13 14:01:22 +01:00
1bf5375e74
Fix BeatmapInfo-associated member not copying
2022-02-13 14:01:21 +01:00
a2c2b2bbb3
Add flow for copying existing difficulty content
2022-02-13 14:01:20 +01:00
6f0e32826c
Standardise ordering/grouping of IRulesetInfo/RulesetInfos
2022-02-11 04:27:11 +03:00
6dc0f3fd96
Merge difficulty creation methods into one
...
One of them wasn't really doing much anymore and was more obfuscating
what was actually happening at this point.
2022-02-03 18:14:30 +01:00
bef0a2da21
Remove return type from AddDifficultyToBeatmapSet
...
Also removes a pointless realm encapsulation.
2022-02-03 19:43:43 +09:00
ad47649d1c
Make BeatmapModelManager.Save non-virtual
2022-02-03 19:38:53 +09:00
a8ffc4fc2a
Add editor override to respect IsolateSavingFromDatabase
2022-02-02 21:57:21 +01:00
47429fb0c6
Fix same-name safety firing wrongly
2022-02-02 21:57:21 +01:00
4f1aac9345
Add safeties preventing creating multiple difficulties with same name
2022-02-02 21:57:09 +01:00
54bb6ad40c
Fix working beatmaps not seeing new difficulties after add
2022-02-02 21:55:34 +01:00
dc96c4888b
Add support for creating new blank difficulties
2022-02-02 21:55:33 +01:00
6d962e7925
Merge pull request #16726 from dekrain/leaderboard-score-tooltip
...
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
3d7af805a3
Fix BeatmapMetadata not using its user param correctly
2022-02-01 21:16:28 +01:00
8eace12fe3
Synchronise (roughly) backgrounds of all custom tooltips
2022-02-01 16:35:25 +09:00
142a67e163
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 18:53:28 +09:00
6674567af1
Use -1 as the default preview time globally in metadata
2022-01-27 21:51:51 +01:00
1b8136e3e0
Change some BeatmapInfo defaults in a backwards compatible manner
2022-01-27 21:49:37 +01:00
5288eedd31
Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
2022-01-27 15:38:03 +09:00
